Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Migrate `TestExtractVariables` to subtests… 

… as suggested in previous PR comment.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
This commit is contained in:
Vincent Demeester 2018-08-07 16:06:13 +02:00
parent b5768bea9b
commit 9cd7c1361c
No known key found for this signature in database
GPG Key ID: 083CC6FD6EB699A3
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cli/compose/template/template_test.go
View File

@ -175,20 +175,24 @@ func TestSubstituteWithCustomFunc(t *testing.T) {
func TestExtractVariables(t *testing.T) { func TestExtractVariables(t *testing.T) {
testCases := []struct { testCases := []struct {
name string
dict map[string]interface{} dict map[string]interface{}
expected map[string]string expected map[string]string
}{ }{
{ {
name: "empty",
dict: map[string]interface{}{}, dict: map[string]interface{}{},
expected: map[string]string{}, expected: map[string]string{},
}, },
{ {
name: "no-variables",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "bar", "foo": "bar",
}, },
expected: map[string]string{}, expected: map[string]string{},
}, },
{ {
name: "variable-without-curly-braces",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "$bar", "foo": "$bar",
}, },
@ -197,6 +201,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "variable",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar}", "foo": "${bar}",
}, },
@ -205,6 +210,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "required-variable",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar?:foo}", "foo": "${bar?:foo}",
}, },
@ -213,6 +219,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "required-variable2",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar?foo}", "foo": "${bar?foo}",
}, },
@ -221,6 +228,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "default-variable",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar:-foo}", "foo": "${bar:-foo}",
}, },
@ -229,6 +237,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "default-variable2",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar-foo}", "foo": "${bar-foo}",
}, },
@ -237,6 +246,7 @@ func TestExtractVariables(t *testing.T) {
}, },
}, },
{ {
name: "multiple-values",
dict: map[string]interface{}{ dict: map[string]interface{}{
"foo": "${bar:-foo}", "foo": "${bar:-foo}",
"bar": map[string]interface{}{ "bar": map[string]interface{}{
@ -259,7 +269,9 @@ func TestExtractVariables(t *testing.T) {
}, },
} }
for _, tc := range testCases { for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
actual := ExtractVariables(tc.dict, defaultPattern) actual := ExtractVariables(tc.dict, defaultPattern)
assert.Check(t, is.DeepEqual(actual, tc.expected)) assert.Check(t, is.DeepEqual(actual, tc.expected))
})
} }
} }