From 9847e96765d70ca5c3f3bf072077ff4eeac53b61 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 12 Jul 2018 14:25:19 +0200 Subject: [PATCH] Update hints for linting - remove some hints that are no longer needed - added a nolint: unparam for removeSingleSigner() (return bool is only used in tests) Signed-off-by: Sebastiaan van Stijn --- cli/command/container/opts_test.go | 1 - cli/command/registry/login_test.go | 1 - cli/command/trust/signer_remove.go | 1 + 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cli/command/container/opts_test.go b/cli/command/container/opts_test.go index 67f0cad44d..6d7c95a5dd 100644 --- a/cli/command/container/opts_test.go +++ b/cli/command/container/opts_test.go @@ -42,7 +42,6 @@ func TestValidateAttach(t *testing.T) { } } -// nolint: unparam func parseRun(args []string) (*container.Config, *container.HostConfig, *networktypes.NetworkingConfig, error) { flags, copts := setupRunFlags() if err := flags.Parse(args); err != nil { diff --git a/cli/command/registry/login_test.go b/cli/command/registry/login_test.go index 7e77494186..d050ff59ab 100644 --- a/cli/command/registry/login_test.go +++ b/cli/command/registry/login_test.go @@ -28,7 +28,6 @@ type fakeClient struct { client.Client } -// nolint: unparam func (c fakeClient) RegistryLogin(ctx context.Context, auth types.AuthConfig) (registrytypes.AuthenticateOKBody, error) { if auth.Password == expiredPassword { return registrytypes.AuthenticateOKBody{}, fmt.Errorf("Invalid Username or Password") diff --git a/cli/command/trust/signer_remove.go b/cli/command/trust/signer_remove.go index d4e8eec42b..6945f54e03 100644 --- a/cli/command/trust/signer_remove.go +++ b/cli/command/trust/signer_remove.go @@ -78,6 +78,7 @@ func isLastSignerForReleases(roleWithSig data.Role, allRoles []client.RoleWithSi // removeSingleSigner attempts to remove a single signer and returns whether signer removal happened. // The signer not being removed doesn't necessarily raise an error e.g. user choosing "No" when prompted for confirmation. +// nolint: unparam func removeSingleSigner(cli command.Cli, repoName, signerName string, forceYes bool) (bool, error) { ctx := context.Background() imgRefAndAuth, err := trust.GetImageReferencesAndAuth(ctx, nil, image.AuthResolver(cli), repoName)