Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/service: SA1012: do not pass a nil Context (staticcheck) 

```
cli/command/service/update_test.go:31:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
cli/command/service/update_test.go:535:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
cli/command/service/update_test.go:540:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2019-10-29 01:49:41 +01:00
parent 1850a0595b
commit 8d64c2af1a
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
cli/command/service/update_test.go
View File

@ -28,7 +28,7 @@ func TestUpdateServiceArgs(t *testing.T) {
cspec := spec.TaskTemplate.ContainerSpec cspec := spec.TaskTemplate.ContainerSpec
cspec.Args = []string{"old", "args"} cspec.Args = []string{"old", "args"}
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.DeepEqual([]string{"the", "new args"}, cspec.Args)) assert.Check(t, is.DeepEqual([]string{"the", "new args"}, cspec.Args))
} }
@ -532,18 +532,18 @@ func TestUpdateReadOnly(t *testing.T) {
// Update with --read-only=true, changed to true // Update with --read-only=true, changed to true
flags := newUpdateCommand(nil).Flags() flags := newUpdateCommand(nil).Flags()
flags.Set("read-only", "true") flags.Set("read-only", "true")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, cspec.ReadOnly) assert.Check(t, cspec.ReadOnly)
// Update without --read-only, no change // Update without --read-only, no change
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, cspec.ReadOnly) assert.Check(t, cspec.ReadOnly)
// Update with --read-only=false, changed to false // Update with --read-only=false, changed to false
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
flags.Set("read-only", "false") flags.Set("read-only", "false")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, !cspec.ReadOnly) assert.Check(t, !cspec.ReadOnly)
} }
@ -558,18 +558,18 @@ func TestUpdateInit(t *testing.T) {
// Update with --init=true // Update with --init=true
flags := newUpdateCommand(nil).Flags() flags := newUpdateCommand(nil).Flags()
flags.Set("init", "true") flags.Set("init", "true")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal(true, *cspec.Init)) assert.Check(t, is.Equal(true, *cspec.Init))
// Update without --init, no change // Update without --init, no change
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal(true, *cspec.Init)) assert.Check(t, is.Equal(true, *cspec.Init))
// Update with --init=false // Update with --init=false
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
flags.Set("init", "false") flags.Set("init", "false")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal(false, *cspec.Init)) assert.Check(t, is.Equal(false, *cspec.Init))
} }
@ -584,18 +584,18 @@ func TestUpdateStopSignal(t *testing.T) {
// Update with --stop-signal=SIGUSR1 // Update with --stop-signal=SIGUSR1
flags := newUpdateCommand(nil).Flags() flags := newUpdateCommand(nil).Flags()
flags.Set("stop-signal", "SIGUSR1") flags.Set("stop-signal", "SIGUSR1")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal("SIGUSR1", cspec.StopSignal)) assert.Check(t, is.Equal("SIGUSR1", cspec.StopSignal))
// Update without --stop-signal, no change // Update without --stop-signal, no change
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal("SIGUSR1", cspec.StopSignal)) assert.Check(t, is.Equal("SIGUSR1", cspec.StopSignal))
// Update with --stop-signal=SIGWINCH // Update with --stop-signal=SIGWINCH
flags = newUpdateCommand(nil).Flags() flags = newUpdateCommand(nil).Flags()
flags.Set("stop-signal", "SIGWINCH") flags.Set("stop-signal", "SIGWINCH")
updateService(nil, nil, flags, spec) updateService(context.TODO(), nil, flags, spec)
assert.Check(t, is.Equal("SIGWINCH", cspec.StopSignal)) assert.Check(t, is.Equal("SIGWINCH", cspec.StopSignal))
} }