From 868adb13c6801ea4b0f157ca6be22595e8d99369 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 24 Oct 2019 16:27:12 +0200 Subject: [PATCH] lint: update some nolint comments: ``` cli/command/container/hijack.go:188:1:warning: nolint directive did not match any issue (nolint) cli/command/image/trust.go:346:1:warning: nolint directive did not match any issue (nolint) cli/command/manifest/push.go:211:1:warning: nolint directive did not match any issue (nolint) cli/command/trust/signer_remove.go:79:1:warning: nolint directive did not match any issue (nolint) internal/pkg/containerized/snapshot.go:95:1:warning: nolint directive did not match any issue (nolint) internal/pkg/containerized/snapshot.go:138:1:warning: nolint directive did not match any issue (nolint) ``` Signed-off-by: Sebastiaan van Stijn --- cli/command/container/hijack.go | 1 - cli/command/image/trust.go | 1 - cli/command/manifest/push.go | 1 - cli/command/trust/signer_remove.go | 1 - 4 files changed, 4 deletions(-) diff --git a/cli/command/container/hijack.go b/cli/command/container/hijack.go index 433a1c81a9..7ecf5f5057 100644 --- a/cli/command/container/hijack.go +++ b/cli/command/container/hijack.go @@ -185,7 +185,6 @@ func setRawTerminal(streams command.Streams) error { return streams.Out().SetRawTerminal() } -// nolint: unparam func restoreTerminal(streams command.Streams, in io.Closer) error { streams.In().RestoreTerminal() streams.Out().RestoreTerminal() diff --git a/cli/command/image/trust.go b/cli/command/image/trust.go index 1f240f4fdb..13b87afe3a 100644 --- a/cli/command/image/trust.go +++ b/cli/command/image/trust.go @@ -329,7 +329,6 @@ func convertTarget(t client.Target) (target, error) { } // TagTrusted tags a trusted ref -// nolint: interfacer func TagTrusted(ctx context.Context, cli command.Cli, trustedRef reference.Canonical, ref reference.NamedTagged) error { // Use familiar references when interacting with client and output familiarRef := reference.FamiliarString(ref) diff --git a/cli/command/manifest/push.go b/cli/command/manifest/push.go index fa734afa2e..afd0e1fbbf 100644 --- a/cli/command/manifest/push.go +++ b/cli/command/manifest/push.go @@ -208,7 +208,6 @@ func buildBlobRequestList(imageManifest types.ImageManifest, repoName reference. return blobReqs, nil } -// nolint: interfacer func buildPutManifestRequest(imageManifest types.ImageManifest, targetRef reference.Named) (mountRequest, error) { refWithoutTag, err := reference.WithName(targetRef.Name()) if err != nil { diff --git a/cli/command/trust/signer_remove.go b/cli/command/trust/signer_remove.go index 6945f54e03..d4e8eec42b 100644 --- a/cli/command/trust/signer_remove.go +++ b/cli/command/trust/signer_remove.go @@ -78,7 +78,6 @@ func isLastSignerForReleases(roleWithSig data.Role, allRoles []client.RoleWithSi // removeSingleSigner attempts to remove a single signer and returns whether signer removal happened. // The signer not being removed doesn't necessarily raise an error e.g. user choosing "No" when prompted for confirmation. -// nolint: unparam func removeSingleSigner(cli command.Cli, repoName, signerName string, forceYes bool) (bool, error) { ctx := context.Background() imgRefAndAuth, err := trust.GetImageReferencesAndAuth(ctx, nil, image.AuthResolver(cli), repoName)