From 80a3add604fb551a6a0ddb38b8573cb8ffaeb41f Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sun, 27 Mar 2022 19:48:55 +0200 Subject: [PATCH] cli/command/container: unnecessary use of fmt.Sprintf (gosimple) cli/command/container/formatter_stats.go:184:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("--") ^ cli/command/container/formatter_stats.go:191:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("-- / --") ^ cli/command/container/formatter_stats.go:201:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("--") ^ cli/command/container/formatter_stats.go:184:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("--") ^ cli/command/container/formatter_stats.go:191:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("-- / --") ^ cli/command/container/formatter_stats.go:201:10: S1039: unnecessary use of fmt.Sprintf (gosimple) return fmt.Sprintf("--") ^ Signed-off-by: Sebastiaan van Stijn (cherry picked from commit 5a65aadd8d2ec8aaa6830c21cdee0d1fe14c3341) Signed-off-by: Sebastiaan van Stijn --- cli/command/container/formatter_stats.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cli/command/container/formatter_stats.go b/cli/command/container/formatter_stats.go index 80fdd586d6..4909405cf3 100644 --- a/cli/command/container/formatter_stats.go +++ b/cli/command/container/formatter_stats.go @@ -181,14 +181,14 @@ func (c *statsContext) ID() string { func (c *statsContext) CPUPerc() string { if c.s.IsInvalid { - return fmt.Sprintf("--") + return "--" } return fmt.Sprintf("%.2f%%", c.s.CPUPercentage) } func (c *statsContext) MemUsage() string { if c.s.IsInvalid { - return fmt.Sprintf("-- / --") + return "-- / --" } if c.os == winOSType { return units.BytesSize(c.s.Memory) @@ -198,28 +198,28 @@ func (c *statsContext) MemUsage() string { func (c *statsContext) MemPerc() string { if c.s.IsInvalid || c.os == winOSType { - return fmt.Sprintf("--") + return "--" } return fmt.Sprintf("%.2f%%", c.s.MemoryPercentage) } func (c *statsContext) NetIO() string { if c.s.IsInvalid { - return fmt.Sprintf("--") + return "--" } return fmt.Sprintf("%s / %s", units.HumanSizeWithPrecision(c.s.NetworkRx, 3), units.HumanSizeWithPrecision(c.s.NetworkTx, 3)) } func (c *statsContext) BlockIO() string { if c.s.IsInvalid { - return fmt.Sprintf("--") + return "--" } return fmt.Sprintf("%s / %s", units.HumanSizeWithPrecision(c.s.BlockRead, 3), units.HumanSizeWithPrecision(c.s.BlockWrite, 3)) } func (c *statsContext) PIDs() string { if c.s.IsInvalid || c.os == winOSType { - return fmt.Sprintf("--") + return "--" } return fmt.Sprintf("%d", c.s.PidsCurrent) }