From 70a29b492d935b80260adbd84504d2e62eea3739 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 27 Dec 2017 12:45:19 +0100 Subject: [PATCH] Add "pid" to unsupported options list Services do not support custom "pid"-modes (e.g. `--pid=host`), but this option was ignored silently when deploying a stack. This patch adds `pid` to the list of unsupported options so that a warning is printed; With this patch applied: $ docker stack deploy -c docker-compose.yml foobar Ignoring unsupported options: pid Creating network foobar_default Creating service foobar_test Signed-off-by: Sebastiaan van Stijn --- cli/compose/loader/loader_test.go | 3 ++- cli/compose/types/types.go | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/compose/loader/loader_test.go b/cli/compose/loader/loader_test.go index c2df0f8252..2e607be17f 100644 --- a/cli/compose/loader/loader_test.go +++ b/cli/compose/loader/loader_test.go @@ -657,6 +657,7 @@ services: context: ./web links: - bar + pid: host db: image: db build: @@ -670,7 +671,7 @@ services: require.NoError(t, err) unsupported := GetUnsupportedProperties(configDetails) - assert.Equal(t, []string{"build", "links"}, unsupported) + assert.Equal(t, []string{"build", "links", "pid"}, unsupported) } func TestBuildProperties(t *testing.T) { diff --git a/cli/compose/types/types.go b/cli/compose/types/types.go index 852c400060..6a9b8c80c0 100644 --- a/cli/compose/types/types.go +++ b/cli/compose/types/types.go @@ -17,6 +17,7 @@ var UnsupportedProperties = []string{ "links", "mac_address", "network_mode", + "pid", "privileged", "restart", "security_opt",