From 6fbb9227cbe22f16cfd0885ff295f5fbf7c471ed Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 28 Sep 2016 12:34:31 +0200 Subject: [PATCH] Remove --name flag from service update The --name flag was inadvertently added to docker service update, but is not supported, as it has various side-effects (e.g., existing tasks are not renamed). This removes the flag from the service update command. Signed-off-by: Sebastiaan van Stijn --- contrib/completion/bash/docker | 2 +- contrib/completion/zsh/_docker | 2 +- docs/reference/commandline/service_update.md | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/contrib/completion/bash/docker b/contrib/completion/bash/docker index ee4b00c794..b948a63916 100644 --- a/contrib/completion/bash/docker +++ b/contrib/completion/bash/docker @@ -2576,7 +2576,6 @@ _docker_service_update() { --log-driver --log-opt --mount - --name --network --publish -p --replicas @@ -2608,6 +2607,7 @@ _docker_service_update() { options_with_args="$options_with_args --container-label --mode + --name " case "$prev" in diff --git a/contrib/completion/zsh/_docker b/contrib/completion/zsh/_docker index 5c6f26e729..99ef3e7480 100644 --- a/contrib/completion/zsh/_docker +++ b/contrib/completion/zsh/_docker @@ -1095,7 +1095,6 @@ __docker_service_subcommand() { "($help)--log-driver=[Logging driver for service]:logging driver:__docker_log_drivers" "($help)*--log-opt=[Logging driver options]:log driver options:__docker_log_options" "($help)*--mount=[Attach a mount to the service]:mount: " - "($help)--name=[Service name]:name: " "($help)*--network=[Network attachments]:network: " "($help)*"{-p=,--publish=}"[Publish a port as a node port]:port: " "($help)--replicas=[Number of tasks]:replicas: " @@ -1123,6 +1122,7 @@ __docker_service_subcommand() { $opts_create_update \ "($help)*--container-label=[Container labels]:label: " \ "($help)--mode=[Service Mode]:mode:(global replicated)" \ + "($help)--name=[Service name]:name: " \ "($help -): :__docker_images" \ "($help -):command: _command_names -e" \ "($help -)*::arguments: _normal" && ret=0 diff --git a/docs/reference/commandline/service_update.md b/docs/reference/commandline/service_update.md index 90b78a4541..c30e5e973e 100644 --- a/docs/reference/commandline/service_update.md +++ b/docs/reference/commandline/service_update.md @@ -42,7 +42,6 @@ Options: --log-opt value Logging driver options (default []) --mount-add value Add or update a mount on a service --mount-rm value Remove a mount by its target path (default []) - --name string Service name --publish-add value Add or update a published port (default []) --publish-rm value Remove a published port by its target port (default []) --replicas value Number of tasks (default none)