mirror of https://github.com/docker/cli.git
Add myself to command/stack codeowners
Cleanup a test Signed-off-by: Daniel Nephin <dnephin@docker.com>
This commit is contained in:
parent
45a7e1ca87
commit
60991e943b
|
@ -1,6 +1,7 @@
|
|||
# Github code owners
|
||||
# See https://github.com/blog/2392-introducing-code-owners
|
||||
|
||||
cli/command/stack/** @dnephin @vdemeester
|
||||
cli/compose/** @dnephin @vdemeester
|
||||
contrib/completion/bash/** @albers
|
||||
contrib/completion/zsh/** @sdurrheimer
|
||||
|
|
|
@ -42,8 +42,6 @@ func (n notFound) NotFound() bool {
|
|||
|
||||
func TestValidateExternalNetworks(t *testing.T) {
|
||||
var testcases = []struct {
|
||||
inspected bool
|
||||
noInspect bool
|
||||
inspectResponse types.NetworkResource
|
||||
inspectError error
|
||||
expectedMsg string
|
||||
|
@ -58,7 +56,7 @@ func TestValidateExternalNetworks(t *testing.T) {
|
|||
expectedMsg: "Unexpected",
|
||||
},
|
||||
{
|
||||
noInspect: true,
|
||||
inspectError: errors.New("host net does not exist on swarm classic"),
|
||||
network: "host",
|
||||
},
|
||||
{
|
||||
|
@ -74,15 +72,11 @@ func TestValidateExternalNetworks(t *testing.T) {
|
|||
for _, testcase := range testcases {
|
||||
fakeClient := &network.FakeClient{
|
||||
NetworkInspectFunc: func(_ context.Context, _ string, _ types.NetworkInspectOptions) (types.NetworkResource, error) {
|
||||
testcase.inspected = true
|
||||
return testcase.inspectResponse, testcase.inspectError
|
||||
},
|
||||
}
|
||||
networks := []string{testcase.network}
|
||||
err := validateExternalNetworks(context.Background(), fakeClient, networks)
|
||||
if testcase.noInspect && testcase.inspected {
|
||||
assert.Fail(t, "expected no network inspect operation but one occurent")
|
||||
}
|
||||
if testcase.expectedMsg == "" {
|
||||
assert.NoError(t, err)
|
||||
} else {
|
||||
|
|
Loading…
Reference in New Issue