From 5e76d41bf60d8c991184410cb83f16e864fd470f Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 12 Apr 2023 10:29:27 +0200 Subject: [PATCH] cli/command: ConfigureAuth: fix links to related tickets Also adds a TODO to verify if this special handling is still needed. Signed-off-by: Sebastiaan van Stijn --- cli/command/registry.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/cli/command/registry.go b/cli/command/registry.go index 243e26c928..2248f6515d 100644 --- a/cli/command/registry.go +++ b/cli/command/registry.go @@ -89,7 +89,14 @@ func GetDefaultAuthConfig(cli Cli, checkCredStore bool, serverAddress string, is // ConfigureAuth handles prompting of user's username and password if needed func ConfigureAuth(cli Cli, flUser, flPassword string, authconfig *registrytypes.AuthConfig, isDefaultRegistry bool) error { - // On Windows, force the use of the regular OS stdin stream. Fixes #14336/#14210 + // On Windows, force the use of the regular OS stdin stream. + // + // See: + // - https://github.com/moby/moby/issues/14336 + // - https://github.com/moby/moby/issues/14210 + // - https://github.com/moby/moby/pull/17738 + // + // TODO(thaJeztah): we need to confirm if this special handling is still needed, as we may not be doing this in other places. if runtime.GOOS == "windows" { cli.SetIn(streams.NewIn(os.Stdin)) }