Merge pull request #2174 from thaJeztah/fix_isabs_test

compose/loader: fix TestIsAbs not testing all combinations
This commit is contained in:
Silvin Lubecki 2019-10-29 15:59:37 +01:00 committed by GitHub
commit 57b7b75df8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions

View File

@ -43,7 +43,8 @@ var winisabstests = []IsAbsTest{
}
func TestIsAbs(t *testing.T) {
tests := append(isabstests, winisabstests...)
tests := winisabstests
// All non-windows tests should fail, because they have no volume letter.
for _, test := range isabstests {
tests = append(tests, IsAbsTest{test.path, false})
@ -53,7 +54,7 @@ func TestIsAbs(t *testing.T) {
tests = append(tests, IsAbsTest{"c:" + test.path, test.isAbs})
}
for _, test := range winisabstests {
for _, test := range tests {
if r := isAbs(test.path); r != test.isAbs {
t.Errorf("IsAbs(%q) = %v, want %v", test.path, r, test.isAbs)
}