From 4cf1c50ad174f9e1bb19785f6f4c2db508c539eb Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 9 Nov 2023 10:54:54 +0100 Subject: [PATCH] Revert "update to go1.21.4" due to regressions / breaking changes. Unfortunately, the go1.21.4 security update exposed some regressions / breaking changes in moby (docker engine) and containerd. These issues are looked into, but in the meantime we should revert this patch. This temporarily reintroduces CVE-2023-45284 and CVE-2023-45283. This reverts commit 6472dabe4c9b5bdad472ff5c809dafe82f7c7064. Signed-off-by: Sebastiaan van Stijn --- .github/workflows/test.yml | 2 +- Dockerfile | 2 +- docker-bake.hcl | 2 +- dockerfiles/Dockerfile.dev | 2 +- dockerfiles/Dockerfile.lint | 2 +- dockerfiles/Dockerfile.vendor | 2 +- e2e/testdata/Dockerfile.gencerts | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e2586bcbc9..0907ba26d1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -63,7 +63,7 @@ jobs: name: Set up Go uses: actions/setup-go@v4 with: - go-version: 1.21.4 + go-version: 1.21.3 - name: Test run: | diff --git a/Dockerfile b/Dockerfile index a7212a21c2..c1d3082da2 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,7 +1,7 @@ # syntax=docker/dockerfile:1 ARG BASE_VARIANT=alpine -ARG GO_VERSION=1.21.4 +ARG GO_VERSION=1.21.3 ARG ALPINE_VERSION=3.17 ARG XX_VERSION=1.2.1 ARG GOVERSIONINFO_VERSION=v1.3.0 diff --git a/docker-bake.hcl b/docker-bake.hcl index 49c6da3c81..21c3687201 100644 --- a/docker-bake.hcl +++ b/docker-bake.hcl @@ -1,5 +1,5 @@ variable "GO_VERSION" { - default = "1.21.4" + default = "1.21.3" } variable "VERSION" { default = "" diff --git a/dockerfiles/Dockerfile.dev b/dockerfiles/Dockerfile.dev index b6782620e6..2aeb488259 100644 --- a/dockerfiles/Dockerfile.dev +++ b/dockerfiles/Dockerfile.dev @@ -1,6 +1,6 @@ # syntax=docker/dockerfile:1 -ARG GO_VERSION=1.21.4 +ARG GO_VERSION=1.21.3 ARG ALPINE_VERSION=3.17 ARG BUILDX_VERSION=0.11.2 diff --git a/dockerfiles/Dockerfile.lint b/dockerfiles/Dockerfile.lint index cccaef570e..d1ac42b1ad 100644 --- a/dockerfiles/Dockerfile.lint +++ b/dockerfiles/Dockerfile.lint @@ -1,6 +1,6 @@ # syntax=docker/dockerfile:1 -ARG GO_VERSION=1.21.4 +ARG GO_VERSION=1.21.3 ARG ALPINE_VERSION=3.17 ARG GOLANGCI_LINT_VERSION=v1.55.0 diff --git a/dockerfiles/Dockerfile.vendor b/dockerfiles/Dockerfile.vendor index 60e60bfb19..16761fe769 100644 --- a/dockerfiles/Dockerfile.vendor +++ b/dockerfiles/Dockerfile.vendor @@ -1,6 +1,6 @@ # syntax=docker/dockerfile:1 -ARG GO_VERSION=1.21.4 +ARG GO_VERSION=1.21.3 ARG ALPINE_VERSION=3.17 ARG MODOUTDATED_VERSION=v0.8.0 diff --git a/e2e/testdata/Dockerfile.gencerts b/e2e/testdata/Dockerfile.gencerts index aaa4c90b90..e6d5d6923f 100644 --- a/e2e/testdata/Dockerfile.gencerts +++ b/e2e/testdata/Dockerfile.gencerts @@ -1,6 +1,6 @@ # syntax=docker/dockerfile:1 -ARG GO_VERSION=1.21.4 +ARG GO_VERSION=1.21.3 FROM golang:${GO_VERSION}-alpine AS generated ENV GOTOOLCHAIN=local