Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tests: fix other flaky `connhelper` tests 

Follow up to cc68c66c95 (there were more
tests with incorrect syntax).

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
This commit is contained in:
Laura Brehm 2024-07-24 11:52:23 +01:00
parent 482bf8613c
commit 4a7388f0dd
No known key found for this signature in database
GPG Key ID: 08EC1B0491948487
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cli/connhelper/commandconn/commandconn_unix_test.go
View File

@ -145,7 +145,7 @@ func (mockStdoutEOF) Close() error {
func TestCloseWhileWriting(t *testing.T) { func TestCloseWhileWriting(t *testing.T) {
ctx := context.TODO() ctx := context.TODO()
c, err := New(ctx, "sh", "-c", "while true; sleep 1; done") c, err := New(ctx, "sh", "-c", "while true; do sleep 1; done")
assert.NilError(t, err) assert.NilError(t, err)
cmdConn := c.(*commandConn) cmdConn := c.(*commandConn)
assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid)) assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid))
@ -173,7 +173,7 @@ func TestCloseWhileWriting(t *testing.T) {
func TestCloseWhileReading(t *testing.T) { func TestCloseWhileReading(t *testing.T) {
ctx := context.TODO() ctx := context.TODO()
c, err := New(ctx, "sh", "-c", "while true; sleep 1; done") c, err := New(ctx, "sh", "-c", "while true; do sleep 1; done")
assert.NilError(t, err) assert.NilError(t, err)
cmdConn := c.(*commandConn) cmdConn := c.(*commandConn)
assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid)) assert.Check(t, process.Alive(cmdConn.cmd.Process.Pid))