Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #920 from dnephin/fix-image-build-github 

Don't prompt for github creds in unit test
This commit is contained in:
Sebastiaan van Stijn 2018-03-07 14:22:52 +01:00 committed by GitHub
parent f351f00f9e 0f11a310fd
commit 485a01fb53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cli/command/image/build_test.go
View File

@ -161,12 +161,16 @@ COPY data /data
// TestRunBuildFromLocalGitHubDirNonExistingRepo tests that build contexts // TestRunBuildFromLocalGitHubDirNonExistingRepo tests that build contexts
// starting with `github.com/` are special-cased, and the build command attempts // starting with `github.com/` are special-cased, and the build command attempts
// to clone the remote repo. // to clone the remote repo.
// TODO: test "context selection" logic directly when runBuild is refactored
// to support testing (ex: docker/cli#294)
func TestRunBuildFromGitHubSpecialCase(t *testing.T) { func TestRunBuildFromGitHubSpecialCase(t *testing.T) {
cmd := NewBuildCommand(test.NewFakeCli(nil)) cmd := NewBuildCommand(test.NewFakeCli(nil))
cmd.SetArgs([]string{"github.com/docker/no-such-repository"}) // Clone a small repo that exists so git doesn't prompt for credentials
cmd.SetArgs([]string{"github.com/docker/for-win"})
cmd.SetOutput(ioutil.Discard) cmd.SetOutput(ioutil.Discard)
err := cmd.Execute() err := cmd.Execute()
assert.ErrorContains(t, err, "unable to prepare context: unable to 'git clone'") assert.ErrorContains(t, err, "unable to prepare context")
assert.ErrorContains(t, err, "docker-build-git")
} }
// TestRunBuildFromLocalGitHubDirNonExistingRepo tests that a local directory // TestRunBuildFromLocalGitHubDirNonExistingRepo tests that a local directory