Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

golangci-lint: update to v1.49.0 for compatibilty with go1.19 

Remove the "deadcode", "structcheck", and "varcheck" linters, as they are
deprecated:

    WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.

And ignore gosec G113, which only affects gp < 1.16.14. and go < 1.17.7

    opts/opts.go:398:13: G113: Potential uncontrolled memory consumption in Rat.SetString (CVE-2022-23772) (gosec)
        cpu, ok := new(big.Rat).SetString(value)
                   ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0dd2c18082)
Signed-off-by: Cory Snider <csnider@mirantis.com>
This commit is contained in:
Sebastiaan van Stijn 2022-09-02 21:24:26 +02:00 committed by Cory Snider
parent 2d955cbeed
commit 48151d432c
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
.golangci.yml
View File

@ -1,7 +1,6 @@
linters: linters:
enable: enable:
- bodyclose - bodyclose
- deadcode
- dogsled - dogsled
- gocyclo - gocyclo
- goimports - goimports
@ -13,14 +12,12 @@ linters:
- megacheck - megacheck
- misspell - misspell
- nakedret - nakedret
- revive
- staticcheck - staticcheck
- structcheck
- typecheck - typecheck
- unconvert - unconvert
- unparam - unparam
- unused - unused
- revive
- varcheck
disable: disable:
- errcheck - errcheck
@ -93,6 +90,12 @@ issues:
linters: linters:
- gosec - gosec
# G113 Potential uncontrolled memory consumption in Rat.SetString (CVE-2022-23772)
# only affects gp < 1.16.14. and go < 1.17.7
- text: "(G113)"
linters:
- gosec
# Looks like the match in "EXC0007" above doesn't catch this one # Looks like the match in "EXC0007" above doesn't catch this one
# TODO: consider upstreaming this to golangci-lint's default exclusion rules # TODO: consider upstreaming this to golangci-lint's default exclusion rules
- text: "G204: Subprocess launched with a potential tainted input or cmd arguments" - text: "G204: Subprocess launched with a potential tainted input or cmd arguments"
@ -104,6 +107,11 @@ issues:
linters: linters:
- gosec - gosec
# TODO: make sure all packages have a description. Currently, there's 67 packages without.
- text: "package-comments: should have a package comment"
linters:
- revive
# Exclude some linters from running on tests files. # Exclude some linters from running on tests files.
- path: _test\.go - path: _test\.go
linters: linters:

2
dockerfiles/Dockerfile.lint
View File

@ -2,7 +2,7 @@
ARG GO_VERSION=1.18.10 ARG GO_VERSION=1.18.10
ARG ALPINE_VERSION=3.16 ARG ALPINE_VERSION=3.16
ARG GOLANGCI_LINT_VERSION=v1.45.2 ARG GOLANGCI_LINT_VERSION=v1.49.0
FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS build FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS build
ENV CGO_ENABLED=0 ENV CGO_ENABLED=0