From b296abd5429bc9754a6d8ddf448295043b9d9b2c Mon Sep 17 00:00:00 2001 From: Arash Deshmeh Date: Fri, 30 Jun 2017 17:09:37 -0400 Subject: [PATCH] add unit tests to cli/command/checkpoint package Signed-off-by: Arash Deshmeh --- cli/command/checkpoint/client_test.go | 35 +++++++++ cli/command/checkpoint/create_test.go | 74 +++++++++++++++++++ cli/command/checkpoint/list_test.go | 71 ++++++++++++++++++ cli/command/checkpoint/remove_test.go | 66 +++++++++++++++++ .../checkpoint-list-with-options.golden | 2 + 5 files changed, 248 insertions(+) create mode 100644 cli/command/checkpoint/client_test.go create mode 100644 cli/command/checkpoint/create_test.go create mode 100644 cli/command/checkpoint/list_test.go create mode 100644 cli/command/checkpoint/remove_test.go create mode 100644 cli/command/checkpoint/testdata/checkpoint-list-with-options.golden diff --git a/cli/command/checkpoint/client_test.go b/cli/command/checkpoint/client_test.go new file mode 100644 index 0000000000..ca91719617 --- /dev/null +++ b/cli/command/checkpoint/client_test.go @@ -0,0 +1,35 @@ +package checkpoint + +import ( + "github.com/docker/docker/api/types" + "github.com/docker/docker/client" + "golang.org/x/net/context" +) + +type fakeClient struct { + client.Client + checkpointCreateFunc func(container string, options types.CheckpointCreateOptions) error + checkpointDeleteFunc func(container string, options types.CheckpointDeleteOptions) error + checkpointListFunc func(container string, options types.CheckpointListOptions) ([]types.Checkpoint, error) +} + +func (cli *fakeClient) CheckpointCreate(ctx context.Context, container string, options types.CheckpointCreateOptions) error { + if cli.checkpointCreateFunc != nil { + return cli.checkpointCreateFunc(container, options) + } + return nil +} + +func (cli *fakeClient) CheckpointDelete(ctx context.Context, container string, options types.CheckpointDeleteOptions) error { + if cli.checkpointDeleteFunc != nil { + return cli.checkpointDeleteFunc(container, options) + } + return nil +} + +func (cli *fakeClient) CheckpointList(ctx context.Context, container string, options types.CheckpointListOptions) ([]types.Checkpoint, error) { + if cli.checkpointListFunc != nil { + return cli.checkpointListFunc(container, options) + } + return []types.Checkpoint{}, nil +} diff --git a/cli/command/checkpoint/create_test.go b/cli/command/checkpoint/create_test.go new file mode 100644 index 0000000000..dfbf6317a1 --- /dev/null +++ b/cli/command/checkpoint/create_test.go @@ -0,0 +1,74 @@ +package checkpoint + +import ( + "bytes" + "io/ioutil" + "strings" + "testing" + + "github.com/docker/cli/cli/internal/test" + "github.com/docker/docker/api/types" + "github.com/docker/docker/pkg/testutil" + "github.com/pkg/errors" + "github.com/stretchr/testify/assert" +) + +func TestCheckpointCreateErrors(t *testing.T) { + testCases := []struct { + args []string + checkpointCreateFunc func(container string, options types.CheckpointCreateOptions) error + expectedError string + }{ + { + args: []string{"too-few-arguments"}, + expectedError: "requires exactly 2 argument(s)", + }, + { + args: []string{"too", "many", "arguments"}, + expectedError: "requires exactly 2 argument(s)", + }, + { + args: []string{"foo", "bar"}, + checkpointCreateFunc: func(container string, options types.CheckpointCreateOptions) error { + return errors.Errorf("error creating checkpoint for container foo") + }, + expectedError: "error creating checkpoint for container foo", + }, + } + + for _, tc := range testCases { + cli := test.NewFakeCli(&fakeClient{ + checkpointCreateFunc: tc.checkpointCreateFunc, + }, &bytes.Buffer{}) + cmd := newCreateCommand(cli) + cmd.SetArgs(tc.args) + cmd.SetOutput(ioutil.Discard) + testutil.ErrorContains(t, cmd.Execute(), tc.expectedError) + } +} + +func TestCheckpointCreateWithOptions(t *testing.T) { + var containerID, checkpointID, checkpointDir string + var exit bool + buf := new(bytes.Buffer) + cli := test.NewFakeCli(&fakeClient{ + checkpointCreateFunc: func(container string, options types.CheckpointCreateOptions) error { + containerID = container + checkpointID = options.CheckpointID + checkpointDir = options.CheckpointDir + exit = options.Exit + return nil + }, + }, buf) + cmd := newCreateCommand(cli) + checkpoint := "checkpoint-bar" + cmd.SetArgs([]string{"container-foo", checkpoint}) + cmd.Flags().Set("leave-running", "true") + cmd.Flags().Set("checkpoint-dir", "/dir/foo") + assert.NoError(t, cmd.Execute()) + assert.Equal(t, "container-foo", containerID) + assert.Equal(t, checkpoint, checkpointID) + assert.Equal(t, "/dir/foo", checkpointDir) + assert.Equal(t, false, exit) + assert.Equal(t, checkpoint, strings.TrimSpace(buf.String())) +} diff --git a/cli/command/checkpoint/list_test.go b/cli/command/checkpoint/list_test.go new file mode 100644 index 0000000000..7d4f2e1b73 --- /dev/null +++ b/cli/command/checkpoint/list_test.go @@ -0,0 +1,71 @@ +package checkpoint + +import ( + "bytes" + "io/ioutil" + "testing" + + "github.com/docker/cli/cli/internal/test" + "github.com/docker/docker/api/types" + "github.com/docker/docker/pkg/testutil" + "github.com/docker/docker/pkg/testutil/golden" + "github.com/pkg/errors" + "github.com/stretchr/testify/assert" +) + +func TestCheckpointListErrors(t *testing.T) { + testCases := []struct { + args []string + checkpointListFunc func(container string, options types.CheckpointListOptions) ([]types.Checkpoint, error) + expectedError string + }{ + { + args: []string{}, + expectedError: "requires exactly 1 argument", + }, + { + args: []string{"too", "many", "arguments"}, + expectedError: "requires exactly 1 argument", + }, + { + args: []string{"foo"}, + checkpointListFunc: func(container string, options types.CheckpointListOptions) ([]types.Checkpoint, error) { + return []types.Checkpoint{}, errors.Errorf("error getting checkpoints for container foo") + }, + expectedError: "error getting checkpoints for container foo", + }, + } + + for _, tc := range testCases { + cli := test.NewFakeCli(&fakeClient{ + checkpointListFunc: tc.checkpointListFunc, + }, &bytes.Buffer{}) + cmd := newListCommand(cli) + cmd.SetArgs(tc.args) + cmd.SetOutput(ioutil.Discard) + testutil.ErrorContains(t, cmd.Execute(), tc.expectedError) + } +} + +func TestCheckpointListWithOptions(t *testing.T) { + var containerID, checkpointDir string + buf := new(bytes.Buffer) + cli := test.NewFakeCli(&fakeClient{ + checkpointListFunc: func(container string, options types.CheckpointListOptions) ([]types.Checkpoint, error) { + containerID = container + checkpointDir = options.CheckpointDir + return []types.Checkpoint{ + {Name: "checkpoint-foo"}, + }, nil + }, + }, buf) + cmd := newListCommand(cli) + cmd.SetArgs([]string{"container-foo"}) + cmd.Flags().Set("checkpoint-dir", "/dir/foo") + assert.NoError(t, cmd.Execute()) + assert.Equal(t, "container-foo", containerID) + assert.Equal(t, "/dir/foo", checkpointDir) + actual := buf.String() + expected := golden.Get(t, []byte(actual), "checkpoint-list-with-options.golden") + testutil.EqualNormalizedString(t, testutil.RemoveSpace, actual, string(expected)) +} diff --git a/cli/command/checkpoint/remove_test.go b/cli/command/checkpoint/remove_test.go new file mode 100644 index 0000000000..2ca8e32d66 --- /dev/null +++ b/cli/command/checkpoint/remove_test.go @@ -0,0 +1,66 @@ +package checkpoint + +import ( + "bytes" + "io/ioutil" + "testing" + + "github.com/docker/cli/cli/internal/test" + "github.com/docker/docker/api/types" + "github.com/docker/docker/pkg/testutil" + "github.com/pkg/errors" + "github.com/stretchr/testify/assert" +) + +func TestCheckpointRemoveErrors(t *testing.T) { + testCases := []struct { + args []string + checkpointDeleteFunc func(container string, options types.CheckpointDeleteOptions) error + expectedError string + }{ + { + args: []string{"too-few-arguments"}, + expectedError: "requires exactly 2 argument(s)", + }, + { + args: []string{"too", "many", "arguments"}, + expectedError: "requires exactly 2 argument(s)", + }, + { + args: []string{"foo", "bar"}, + checkpointDeleteFunc: func(container string, options types.CheckpointDeleteOptions) error { + return errors.Errorf("error deleting checkpoint") + }, + expectedError: "error deleting checkpoint", + }, + } + + for _, tc := range testCases { + cli := test.NewFakeCli(&fakeClient{ + checkpointDeleteFunc: tc.checkpointDeleteFunc, + }, &bytes.Buffer{}) + cmd := newRemoveCommand(cli) + cmd.SetArgs(tc.args) + cmd.SetOutput(ioutil.Discard) + testutil.ErrorContains(t, cmd.Execute(), tc.expectedError) + } +} + +func TestCheckpointRemoveWithOptions(t *testing.T) { + var containerID, checkpointID, checkpointDir string + cli := test.NewFakeCli(&fakeClient{ + checkpointDeleteFunc: func(container string, options types.CheckpointDeleteOptions) error { + containerID = container + checkpointID = options.CheckpointID + checkpointDir = options.CheckpointDir + return nil + }, + }, &bytes.Buffer{}) + cmd := newRemoveCommand(cli) + cmd.SetArgs([]string{"container-foo", "checkpoint-bar"}) + cmd.Flags().Set("checkpoint-dir", "/dir/foo") + assert.NoError(t, cmd.Execute()) + assert.Equal(t, "container-foo", containerID) + assert.Equal(t, "checkpoint-bar", checkpointID) + assert.Equal(t, "/dir/foo", checkpointDir) +} diff --git a/cli/command/checkpoint/testdata/checkpoint-list-with-options.golden b/cli/command/checkpoint/testdata/checkpoint-list-with-options.golden new file mode 100644 index 0000000000..f53f016ae9 --- /dev/null +++ b/cli/command/checkpoint/testdata/checkpoint-list-with-options.golden @@ -0,0 +1,2 @@ +CHECKPOINT NAME +checkpoint-foo