From 34b6ee10a19d2871059fb065eccd03f6574800dd Mon Sep 17 00:00:00 2001 From: Reed Allman Date: Fri, 24 May 2019 19:03:48 -0700 Subject: [PATCH] container start wrong error check noticed that when checking for if the user has entered the escape sequence after starting the container, the code was checking that the error from inspect was a term.EscapeError rather than the error from attach in order to mask the error returned to a nil one - I think this is the error that was intended to be checked here. Signed-off-by: Reed Allman --- cli/command/container/start.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/command/container/start.go b/cli/command/container/start.go index e388302841..2cca4e011e 100644 --- a/cli/command/container/start.go +++ b/cli/command/container/start.go @@ -154,7 +154,7 @@ func runStart(dockerCli command.Cli, opts *startOptions) error { } } if attachErr := <-cErr; attachErr != nil { - if _, ok := err.(term.EscapeError); ok { + if _, ok := attachErr.(term.EscapeError); ok { // The user entered the detach escape sequence. return nil }