Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

scripts/warn-outside-container: fix escapes 

By default, echo does not interpret escape sequences,
resulting in the following output (literal):

	\033[1mWARNING\033[0m: you are not in a container.

I don't think this was intended.

Add -e option to echo so it can work as intended.

Also, use bash instead of sh because in POSIX shell echo does not take
any options.

Fixes: 94e08f2e2d
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This commit is contained in:
Kir Kolyshkin 2023-04-17 12:40:18 -07:00
parent 67c4570f28
commit 2b8dbb67a7
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/warn-outside-container
View File

@ -1,4 +1,4 @@
#!/usr/bin/env sh #!/usr/bin/env bash
set -eu set -eu
target="${1:-}" target="${1:-}"
@ -11,14 +11,14 @@ if [ -z "${DISABLE_WARN_OUTSIDE_CONTAINER:-}" ]; then
*) *)
( (
echo echo
echo "\033[1mWARNING\033[0m: you are not in a container." echo -e "\033[1mWARNING\033[0m: you are not in a container."
echo echo
echo 'Use "\033[1mmake dev\033[0m" to start an interactive development container,' echo -e 'Use "\033[1mmake dev\033[0m" to start an interactive development container,'
echo "use \"\033[1mmake -f docker.Makefile $target\033[0m\" to execute this target" echo -e "use \"\033[1mmake -f docker.Makefile $target\033[0m\" to execute this target"
echo "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to" echo -e "in a container, or set \033[1mDISABLE_WARN_OUTSIDE_CONTAINER=1\033[0m to"
echo "disable this warning." echo -e "disable this warning."
echo echo
echo "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue.." echo -e "Press \033[1mCtrl+C\033[0m now to abort, or wait for the script to continue.."
echo echo
) >&2 ) >&2
sleep 5 sleep 5