Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cli/command/image: fix TestNewSaveCommandSuccess to actually test 

This test was added in [moby@b2551c6] as part of a larger PR that implemented
unit tests in various packages. In this specific test, it looks like the
`imageSaveFunc` that's defined in the test-table was forgotten to be wired
up, causing all tests to effectively be skipped.

This patch wires up the function so that it's used in the test.

[moby@b2551c6]: b2551c619d

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2024-10-08 19:41:05 +02:00
parent 185622986e
commit 19eeb10155
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cli/command/image/save_test.go
View File

@ -70,13 +70,13 @@ func TestNewSaveCommandSuccess(t *testing.T) {
testCases := []struct { testCases := []struct {
args []string args []string
isTerminal bool isTerminal bool
imageSaveFunc func(images []string) (io.ReadCloser, error) imageSaveFunc func(images []string, options image.SaveOptions) (io.ReadCloser, error)
deferredFunc func() deferredFunc func()
}{ }{
{ {
args: []string{"-o", "save_tmp_file", "arg1"}, args: []string{"-o", "save_tmp_file", "arg1"},
isTerminal: true, isTerminal: true,
imageSaveFunc: func(images []string) (io.ReadCloser, error) { imageSaveFunc: func(images []string, _ image.SaveOptions) (io.ReadCloser, error) {
assert.Assert(t, is.Len(images, 1)) assert.Assert(t, is.Len(images, 1))
assert.Check(t, is.Equal("arg1", images[0])) assert.Check(t, is.Equal("arg1", images[0]))
return io.NopCloser(strings.NewReader("")), nil return io.NopCloser(strings.NewReader("")), nil
@ -88,7 +88,7 @@ func TestNewSaveCommandSuccess(t *testing.T) {
{ {
args: []string{"arg1", "arg2"}, args: []string{"arg1", "arg2"},
isTerminal: false, isTerminal: false,
imageSaveFunc: func(images []string) (io.ReadCloser, error) { imageSaveFunc: func(images []string, _ image.SaveOptions) (io.ReadCloser, error) {
assert.Assert(t, is.Len(images, 2)) assert.Assert(t, is.Len(images, 2))
assert.Check(t, is.Equal("arg1", images[0])) assert.Check(t, is.Equal("arg1", images[0]))
assert.Check(t, is.Equal("arg2", images[1])) assert.Check(t, is.Equal("arg2", images[1]))
@ -100,9 +100,7 @@ func TestNewSaveCommandSuccess(t *testing.T) {
tc := tc tc := tc
t.Run(strings.Join(tc.args, " "), func(t *testing.T) { t.Run(strings.Join(tc.args, " "), func(t *testing.T) {
cmd := NewSaveCommand(test.NewFakeCli(&fakeClient{ cmd := NewSaveCommand(test.NewFakeCli(&fakeClient{
imageSaveFunc: func(images []string, options image.SaveOptions) (io.ReadCloser, error) { imageSaveFunc: tc.imageSaveFunc,
return io.NopCloser(strings.NewReader("")), nil
},
})) }))
cmd.SetOut(io.Discard) cmd.SetOut(io.Discard)
cmd.SetErr(io.Discard) cmd.SetErr(io.Discard)