From e1a7517514fbde432f4316f64959fbcff5036a1a Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Tue, 2 Mar 2021 00:54:13 +0000 Subject: [PATCH] Fix `docker start` blocking on signal handling We refactorted `ForwardAllSignals` so it blocks but did not update the call in `start` to call it in a goroutine. Signed-off-by: Brian Goff --- cli/command/container/start.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/command/container/start.go b/cli/command/container/start.go index 9029061e09..bec948225f 100644 --- a/cli/command/container/start.go +++ b/cli/command/container/start.go @@ -75,7 +75,7 @@ func runStart(dockerCli command.Cli, opts *startOptions) error { // We always use c.ID instead of container to maintain consistency during `docker start` if !c.Config.Tty { sigc := notfiyAllSignals() - ForwardAllSignals(ctx, dockerCli, c.ID, sigc) + go ForwardAllSignals(ctx, dockerCli, c.ID, sigc) defer signal.StopCatch(sigc) }