mirror of https://github.com/docker/cli.git
Reverse order of long-form ports
Reverses the order long-form port options when converted to short-form to correctly match the documentation and `docker service create`. Post change `-p published=8111,target=8112` is the equivalent of `8111:8112` Signed-off-by: Nick Adcock <nick.adcock@docker.com>
This commit is contained in:
parent
34d8486237
commit
154a1f6df8
|
@ -808,7 +808,7 @@ func parsePortOpts(publishOpts []string) ([]string, error) {
|
||||||
|
|
||||||
params[opt[0]] = opt[1]
|
params[opt[0]] = opt[1]
|
||||||
}
|
}
|
||||||
optsList = append(optsList, fmt.Sprintf("%s:%s/%s", params["target"], params["published"], params["protocol"]))
|
optsList = append(optsList, fmt.Sprintf("%s:%s/%s", params["published"], params["target"], params["protocol"]))
|
||||||
}
|
}
|
||||||
return optsList, nil
|
return optsList, nil
|
||||||
}
|
}
|
||||||
|
|
|
@ -872,3 +872,9 @@ func TestParseSystemPaths(t *testing.T) {
|
||||||
assert.DeepEqual(t, readonlyPaths, tc.readonly)
|
assert.DeepEqual(t, readonlyPaths, tc.readonly)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestParsePortOpts(t *testing.T) {
|
||||||
|
parsed, err := parsePortOpts([]string{"published=1500,target=200", "target=80,published=90"})
|
||||||
|
assert.NilError(t, err)
|
||||||
|
assert.DeepEqual(t, []string{"1500:200/tcp", "90:80/tcp"}, parsed)
|
||||||
|
}
|
||||||
|
|
Loading…
Reference in New Issue