Check for `.exe` case insensitively

On Windows `foo.exe`, `foo.eXe` and `foo.EXE` are equally executable.

Signed-off-by: Ian Campbell <ijc@docker.com>

cli-plugins/manager/suffix_windows.go

@@ -1,17 +1,24 @@
 package manager
 
 import (
+	"path/filepath"
 	"strings"
 
 	"github.com/pkg/errors"
 )
 
+// This is made slightly more complex due to needing to be case insensitive.
 func trimExeSuffix(s string) (string, error) {
-	exe := ".exe"
+	ext := filepath.Ext(s)
-	if !strings.HasSuffix(s, exe) {
+	if ext == "" {
-		return "", errors.Errorf("lacks required %q suffix", exe)
+		return "", errors.Errorf("path %q lacks required file extension", s)
 	}
-	return strings.TrimSuffix(s, exe), nil
+
+	exe := ".exe"
+	if !strings.EqualFold(ext, exe) {
+		return "", errors.Errorf("path %q lacks required %q suffix", s, exe)
+	}
+	return strings.TrimSuffix(s, ext), nil
 }
 
 func addExeSuffix(s string) string {