Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #32407 from dnephin/fix-rw-mode-compose-files 

Support rw as a volume option in compose file
This commit is contained in:
Brian Goff 2017-04-06 16:24:20 -04:00 committed by GitHub
parent cd315197e3 95b81eb684
commit 12702bdc81
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compose/loader/volume.go
View File

@ -70,6 +70,8 @@ func populateFieldFromBuffer(char rune, buffer []rune, volume *types.ServiceVolu
switch option { switch option {
case "ro": case "ro":
volume.ReadOnly = true volume.ReadOnly = true
case "rw":
volume.ReadOnly = false
case "nocopy": case "nocopy":
volume.Volume = &types.ServiceVolumeVolume{NoCopy: true} volume.Volume = &types.ServiceVolumeVolume{NoCopy: true}
default: default:

14
compose/loader/volume_test.go
View File

@ -132,3 +132,17 @@ func TestParseVolumeWithReadOnly(t *testing.T) {
assert.DeepEqual(t, volume, expected) assert.DeepEqual(t, volume, expected)
} }
} }
func TestParseVolumeWithRW(t *testing.T) {
for _, path := range []string{"./foo", "/home/user"} {
volume, err := parseVolume(path + ":/target:rw")
expected := types.ServiceVolumeConfig{
Type: "bind",
Source: path,
Target: "/target",
ReadOnly: false,
}
assert.NilError(t, err)
assert.DeepEqual(t, volume, expected)
}
}