vendor: update fsutil 0f039a052ca1da01626278199624b62aed9b3729

full diff: 7f9f9232dd...0f039a052c

- tonistiigi/fsutil#69 receive: use filter on receive diff
    - prevents incremental transfers with userns because the metadata
      on disk is always different than the one being transferred.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2020-02-12 15:57:13 +01:00
parent 48f97602f4
commit 0fe7190d04
No known key found for this signature in database
GPG Key ID: 76698F39D527CE8C
6 changed files with 44 additions and 34 deletions

View File

@ -67,7 +67,7 @@ github.com/spf13/cobra ef82de70bb3f60c65fb8eebacbb2
github.com/spf13/pflag 4cb166e4f25ac4e8016a3595bbf7ea2e9aa85a2c https://github.com/thaJeztah/pflag.git # temporary fork with https://github.com/spf13/pflag/pull/170 applied, which isn't merged yet upstream github.com/spf13/pflag 4cb166e4f25ac4e8016a3595bbf7ea2e9aa85a2c https://github.com/thaJeztah/pflag.git # temporary fork with https://github.com/spf13/pflag/pull/170 applied, which isn't merged yet upstream
github.com/syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2 github.com/syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2
github.com/theupdateframework/notary d6e1431feb32348e0650bf7551ac5cffd01d857b # v0.6.1 github.com/theupdateframework/notary d6e1431feb32348e0650bf7551ac5cffd01d857b # v0.6.1
github.com/tonistiigi/fsutil 7f9f9232dd24c4c9c68ab3c8030c4edcaeac1c32 github.com/tonistiigi/fsutil 0f039a052ca1da01626278199624b62aed9b3729
github.com/tonistiigi/units 6950e57a87eaf136bbe44ef2ec8e75b9e3569de2 github.com/tonistiigi/units 6950e57a87eaf136bbe44ef2ec8e75b9e3569de2
github.com/xeipuuv/gojsonpointer 02993c407bfbf5f6dae44c4f4b1cf6a39b5fc5bb github.com/xeipuuv/gojsonpointer 02993c407bfbf5f6dae44c4f4b1cf6a39b5fc5bb
github.com/xeipuuv/gojsonreference bd5ef7bd5415a7ac448318e64f11a24cd21e594b github.com/xeipuuv/gojsonreference bd5ef7bd5415a7ac448318e64f11a24cd21e594b

View File

@ -5,6 +5,7 @@ import (
"hash" "hash"
"os" "os"
"github.com/pkg/errors"
"github.com/tonistiigi/fsutil/types" "github.com/tonistiigi/fsutil/types"
) )
@ -25,9 +26,14 @@ func GetWalkerFn(root string) walkerFn {
return err return err
} }
stat, ok := f.Sys().(*types.Stat)
if !ok {
return errors.Errorf("%T invalid file without stat information", f.Sys())
}
p := &currentPath{ p := &currentPath{
path: path, path: path,
f: f, stat: stat,
} }
select { select {

View File

@ -37,12 +37,12 @@ type ChangeFunc func(ChangeKind, string, os.FileInfo, error) error
type currentPath struct { type currentPath struct {
path string path string
f os.FileInfo stat *types.Stat
// fullPath string // fullPath string
} }
// doubleWalkDiff walks both directories to create a diff // doubleWalkDiff walks both directories to create a diff
func doubleWalkDiff(ctx context.Context, changeFn ChangeFunc, a, b walkerFn) (err error) { func doubleWalkDiff(ctx context.Context, changeFn ChangeFunc, a, b walkerFn, filter FilterFunc) (err error) {
g, ctx := errgroup.WithContext(ctx) g, ctx := errgroup.WithContext(ctx)
var ( var (
@ -86,14 +86,22 @@ func doubleWalkDiff(ctx context.Context, changeFn ChangeFunc, a, b walkerFn) (er
continue continue
} }
var f os.FileInfo var f *types.Stat
k, p := pathChange(f1, f2) var f2copy *currentPath
if f2 != nil {
statCopy := *f2.stat
if filter != nil {
filter(f2.path, &statCopy)
}
f2copy = &currentPath{path: f2.path, stat: &statCopy}
}
k, p := pathChange(f1, f2copy)
switch k { switch k {
case ChangeKindAdd: case ChangeKindAdd:
if rmdir != "" { if rmdir != "" {
rmdir = "" rmdir = ""
} }
f = f2.f f = f2.stat
f2 = nil f2 = nil
case ChangeKindDelete: case ChangeKindDelete:
// Check if this file is already removed by being // Check if this file is already removed by being
@ -101,30 +109,30 @@ func doubleWalkDiff(ctx context.Context, changeFn ChangeFunc, a, b walkerFn) (er
if rmdir != "" && strings.HasPrefix(f1.path, rmdir) { if rmdir != "" && strings.HasPrefix(f1.path, rmdir) {
f1 = nil f1 = nil
continue continue
} else if rmdir == "" && f1.f.IsDir() { } else if rmdir == "" && f1.stat.IsDir() {
rmdir = f1.path + string(os.PathSeparator) rmdir = f1.path + string(os.PathSeparator)
} else if rmdir != "" { } else if rmdir != "" {
rmdir = "" rmdir = ""
} }
f1 = nil f1 = nil
case ChangeKindModify: case ChangeKindModify:
same, err := sameFile(f1, f2) same, err := sameFile(f1, f2copy)
if err != nil { if err != nil {
return err return err
} }
if f1.f.IsDir() && !f2.f.IsDir() { if f1.stat.IsDir() && !f2copy.stat.IsDir() {
rmdir = f1.path + string(os.PathSeparator) rmdir = f1.path + string(os.PathSeparator)
} else if rmdir != "" { } else if rmdir != "" {
rmdir = "" rmdir = ""
} }
f = f2.f f = f2.stat
f1 = nil f1 = nil
f2 = nil f2 = nil
if same { if same {
continue loop0 continue loop0
} }
} }
if err := changeFn(k, p, f, nil); err != nil { if err := changeFn(k, p, &StatInfo{f}, nil); err != nil {
return err return err
} }
} }
@ -159,28 +167,17 @@ func pathChange(lower, upper *currentPath) (ChangeKind, string) {
func sameFile(f1, f2 *currentPath) (same bool, retErr error) { func sameFile(f1, f2 *currentPath) (same bool, retErr error) {
// If not a directory also check size, modtime, and content // If not a directory also check size, modtime, and content
if !f1.f.IsDir() { if !f1.stat.IsDir() {
if f1.f.Size() != f2.f.Size() { if f1.stat.Size_ != f2.stat.Size_ {
return false, nil return false, nil
} }
t1 := f1.f.ModTime() if f1.stat.ModTime != f2.stat.ModTime {
t2 := f2.f.ModTime()
if t1.UnixNano() != t2.UnixNano() {
return false, nil return false, nil
} }
} }
ls1, ok := f1.f.Sys().(*types.Stat) return compareStat(f1.stat, f2.stat)
if !ok {
return false, nil
}
ls2, ok := f2.f.Sys().(*types.Stat)
if !ok {
return false, nil
}
return compareStat(ls1, ls2)
} }
// compareStat returns whether the stats are equivalent, // compareStat returns whether the stats are equivalent,

View File

@ -194,7 +194,7 @@ func (dw *DiskWriter) HandleChange(kind ChangeKind, p string, fi os.FileInfo, er
if isRegularFile { if isRegularFile {
if dw.opt.AsyncDataCb != nil { if dw.opt.AsyncDataCb != nil {
dw.requestAsyncFileData(p, destPath, fi) dw.requestAsyncFileData(p, destPath, fi, &statCopy)
} }
} else { } else {
return dw.processChange(kind, p, fi, nil) return dw.processChange(kind, p, fi, nil)
@ -203,7 +203,7 @@ func (dw *DiskWriter) HandleChange(kind ChangeKind, p string, fi os.FileInfo, er
return nil return nil
} }
func (dw *DiskWriter) requestAsyncFileData(p, dest string, fi os.FileInfo) { func (dw *DiskWriter) requestAsyncFileData(p, dest string, fi os.FileInfo, st *types.Stat) {
// todo: limit worker threads // todo: limit worker threads
dw.eg.Go(func() error { dw.eg.Go(func() error {
if err := dw.processChange(ChangeKindAdd, p, fi, &lazyFileWriter{ if err := dw.processChange(ChangeKindAdd, p, fi, &lazyFileWriter{
@ -211,7 +211,7 @@ func (dw *DiskWriter) requestAsyncFileData(p, dest string, fi os.FileInfo) {
}); err != nil { }); err != nil {
return err return err
} }
return chtimes(dest, fi.ModTime().UnixNano()) // TODO: parent dirs return chtimes(dest, st.ModTime) // TODO: parent dirs
}) })
} }

View File

@ -133,7 +133,7 @@ func (r *receiver) run(ctx context.Context) error {
if !r.merge { if !r.merge {
destWalker = GetWalkerFn(r.dest) destWalker = GetWalkerFn(r.dest)
} }
err := doubleWalkDiff(ctx, dw.HandleChange, destWalker, w.fill) err := doubleWalkDiff(ctx, dw.HandleChange, destWalker, w.fill, r.filter)
if err != nil { if err != nil {
return err return err
} }
@ -180,11 +180,11 @@ func (r *receiver) run(ctx context.Context) error {
r.mu.Unlock() r.mu.Unlock()
} }
i++ i++
cp := &currentPath{path: p.Stat.Path, f: &StatInfo{p.Stat}} cp := &currentPath{path: p.Stat.Path, stat: p.Stat}
if err := r.orderValidator.HandleChange(ChangeKindAdd, cp.path, cp.f, nil); err != nil { if err := r.orderValidator.HandleChange(ChangeKindAdd, cp.path, &StatInfo{cp.stat}, nil); err != nil {
return err return err
} }
if err := r.hlValidator.HandleChange(ChangeKindAdd, cp.path, cp.f, nil); err != nil { if err := r.hlValidator.HandleChange(ChangeKindAdd, cp.path, &StatInfo{cp.stat}, nil); err != nil {
return err return err
} }
if err := w.update(cp); err != nil { if err := w.update(cp); err != nil {

7
vendor/github.com/tonistiigi/fsutil/types/stat.go generated vendored Normal file
View File

@ -0,0 +1,7 @@
package types
import "os"
func (s Stat) IsDir() bool {
return os.FileMode(s.Mode).IsDir()
}