2021-12-07 08:50:16 -05:00
name : test
2022-08-18 14:03:28 -04:00
concurrency :
group : ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress : true
2021-12-07 08:50:16 -05:00
on :
workflow_dispatch :
push :
branches :
- 'master'
- '[0-9]+.[0-9]{2}'
tags :
- 'v*'
pull_request :
jobs :
ctn :
2022-08-20 09:55:20 -04:00
runs-on : ubuntu-20.04
2021-12-07 08:50:16 -05:00
steps :
-
name : Checkout
2022-08-20 09:55:20 -04:00
uses : actions/checkout@v3
2021-12-07 08:50:16 -05:00
-
name : Set up Docker Buildx
2022-08-20 09:55:20 -04:00
uses : docker/setup-buildx-action@v2
2021-12-07 08:50:16 -05:00
-
name : Test
2022-08-20 09:55:20 -04:00
uses : docker/bake-action@v2
2021-12-07 08:50:16 -05:00
with :
targets : test-coverage
-
name : Send to Codecov
2022-08-20 09:55:20 -04:00
uses : codecov/codecov-action@v3
2021-12-07 08:50:16 -05:00
with :
file : ./build/coverage/coverage.txt
host :
runs-on : ${{ matrix.os }}
env :
GOPATH : ${{ github.workspace }}
GOBIN : ${{ github.workspace }}/bin
GO111MODULE : auto
strategy :
fail-fast : false
matrix :
os :
2022-08-20 09:55:20 -04:00
- macos-11
# - windows-2022 # FIXME: some tests are failing on the Windows runner, as well as on Appveyor since June 24, 2018: https://ci.appveyor.com/project/docker/cli/history
2021-12-07 08:50:16 -05:00
steps :
-
name : Prepare git
if : matrix.os == 'windows-latest'
run : |
git config --system core.autocrlf false
git config --system core.eol lf
-
name : Checkout
2022-08-20 09:55:20 -04:00
uses : actions/checkout@v3
2021-12-07 08:50:16 -05:00
with :
path : ${{ env.GOPATH }}/src/github.com/docker/cli
-
name : Set up Go
2022-08-20 09:55:20 -04:00
uses : actions/setup-go@v3
2021-12-07 08:50:16 -05:00
with :
update to go1.19.4
Includes security fixes for net/http (CVE-2022-41717, CVE-2022-41720),
and os (CVE-2022-41720).
These minor releases include 2 security fixes following the security policy:
- os, net/http: avoid escapes from os.DirFS and http.Dir on Windows
The os.DirFS function and http.Dir type provide access to a tree of files
rooted at a given directory. These functions permitted access to Windows
device files under that root. For example, os.DirFS("C:/tmp").Open("COM1")
would open the COM1 device.
Both os.DirFS and http.Dir only provide read-only filesystem access.
In addition, on Windows, an os.DirFS for the directory \(the root of the
current drive) can permit a maliciously crafted path to escape from the
drive and access any path on the system.
The behavior of os.DirFS("") has changed. Previously, an empty root was
treated equivalently to "/", so os.DirFS("").Open("tmp") would open the
path "/tmp". This now returns an error.
This is CVE-2022-41720 and Go issue https://go.dev/issue/56694.
- net/http: limit canonical header cache by bytes, not entries
An attacker can cause excessive memory growth in a Go server accepting
HTTP/2 requests.
HTTP/2 server connections contain a cache of HTTP header keys sent by
the client. While the total number of entries in this cache is capped,
an attacker sending very large keys can cause the server to allocate
approximately 64 MiB per open connection.
This issue is also fixed in golang.org/x/net/http2 vX.Y.Z, for users
manually configuring HTTP/2.
Thanks to Josselin Costanzi for reporting this issue.
This is CVE-2022-41717 and Go issue https://go.dev/issue/56350.
View the release notes for more information:
https://go.dev/doc/devel/release#go1.19.4
And the milestone on the issue tracker:
https://github.com/golang/go/issues?q=milestone%3AGo1.19.4+label%3ACherryPickApproved
Full diff: https://github.com/golang/go/compare/go1.19.3...go1.19.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-12-06 17:03:41 -05:00
go-version : 1.19 .4
2021-12-07 08:50:16 -05:00
-
name : Test
run : |
go test -coverprofile=/tmp/coverage.txt $(go list ./... | grep -vE '/vendor/|/e2e/')
go tool cover -func=/tmp/coverage.txt
working-directory : ${{ env.GOPATH }}/src/github.com/docker/cli
shell : bash
-
name : Send to Codecov
2022-08-20 09:55:20 -04:00
uses : codecov/codecov-action@v3
2021-12-07 08:50:16 -05:00
with :
file : /tmp/coverage.txt
working-directory : ${{ env.GOPATH }}/src/github.com/docker/cli