2016-09-08 13:11:39 -04:00
|
|
|
package formatter
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
2016-09-13 03:01:31 -04:00
|
|
|
"encoding/json"
|
2017-06-15 12:28:08 -04:00
|
|
|
"fmt"
|
2016-09-08 13:11:39 -04:00
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
2020-07-10 09:51:07 -04:00
|
|
|
"github.com/docker/cli/internal/test"
|
2022-04-29 13:26:50 -04:00
|
|
|
"github.com/docker/docker/api/types/volume"
|
2016-09-08 13:11:39 -04:00
|
|
|
"github.com/docker/docker/pkg/stringid"
|
2020-02-22 12:12:14 -05:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
is "gotest.tools/v3/assert/cmp"
|
2016-09-08 13:11:39 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestVolumeContext(t *testing.T) {
|
|
|
|
volumeName := stringid.GenerateRandomID()
|
|
|
|
|
|
|
|
var ctx volumeContext
|
|
|
|
cases := []struct {
|
|
|
|
volumeCtx volumeContext
|
|
|
|
expValue string
|
|
|
|
call func() string
|
|
|
|
}{
|
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{Name: volumeName},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, volumeName, ctx.Name},
|
2016-09-08 13:11:39 -04:00
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{Driver: "driver_name"},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "driver_name", ctx.Driver},
|
2016-09-08 13:11:39 -04:00
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{Scope: "local"},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "local", ctx.Scope},
|
2016-09-08 13:11:39 -04:00
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{Mountpoint: "mountpoint"},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "mountpoint", ctx.Mountpoint},
|
2016-09-08 13:11:39 -04:00
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "", ctx.Labels},
|
2016-09-08 13:11:39 -04:00
|
|
|
{volumeContext{
|
2022-04-29 13:26:50 -04:00
|
|
|
v: volume.Volume{Labels: map[string]string{"label1": "value1", "label2": "value2"}},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "label1=value1,label2=value2", ctx.Labels},
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
ctx = c.volumeCtx
|
|
|
|
v := c.call()
|
|
|
|
if strings.Contains(v, ",") {
|
2020-07-10 09:51:07 -04:00
|
|
|
test.CompareMultipleValues(t, v, c.expValue)
|
2016-09-08 13:11:39 -04:00
|
|
|
} else if v != c.expValue {
|
|
|
|
t.Fatalf("Expected %s, was %s\n", c.expValue, v)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestVolumeContextWrite(t *testing.T) {
|
2016-09-12 16:59:18 -04:00
|
|
|
cases := []struct {
|
|
|
|
context Context
|
2016-09-08 13:11:39 -04:00
|
|
|
expected string
|
|
|
|
}{
|
|
|
|
// Errors
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: "{{InvalidFunction}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1: function "InvalidFunction" not defined`,
|
2016-09-08 13:11:39 -04:00
|
|
|
},
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: "{{nil}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1:2: executing "" at <nil>: nil is not a command`,
|
2016-09-08 13:11:39 -04:00
|
|
|
},
|
|
|
|
// Table format
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("table", false)},
|
2020-08-28 17:00:21 -04:00
|
|
|
`DRIVER VOLUME NAME
|
|
|
|
foo foobar_baz
|
|
|
|
bar foobar_bar
|
2016-09-08 13:11:39 -04:00
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("table", true)},
|
2016-09-08 13:11:39 -04:00
|
|
|
`foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("table {{.Name}}", false)},
|
2016-10-17 14:03:31 -04:00
|
|
|
`VOLUME NAME
|
2016-09-08 13:11:39 -04:00
|
|
|
foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("table {{.Name}}", true)},
|
2016-10-17 14:03:31 -04:00
|
|
|
`VOLUME NAME
|
2016-09-08 13:11:39 -04:00
|
|
|
foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Raw Format
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("raw", false)},
|
|
|
|
`name: foobar_baz
|
2016-09-08 13:11:39 -04:00
|
|
|
driver: foo
|
|
|
|
|
|
|
|
name: foobar_bar
|
|
|
|
driver: bar
|
|
|
|
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("raw", true)},
|
2016-09-08 13:11:39 -04:00
|
|
|
`name: foobar_baz
|
|
|
|
name: foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Custom Format
|
|
|
|
{
|
2016-09-12 16:59:18 -04:00
|
|
|
Context{Format: NewVolumeFormat("{{.Name}}", false)},
|
2016-09-08 13:11:39 -04:00
|
|
|
`foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2022-04-29 13:26:50 -04:00
|
|
|
volumes := []*volume.Volume{
|
2020-08-28 17:00:21 -04:00
|
|
|
{Name: "foobar_baz", Driver: "foo"},
|
|
|
|
{Name: "foobar_bar", Driver: "bar"},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range cases {
|
|
|
|
tc := tc
|
|
|
|
t.Run(string(tc.context.Format), func(t *testing.T) {
|
|
|
|
var out bytes.Buffer
|
|
|
|
tc.context.Output = &out
|
|
|
|
err := VolumeWrite(tc.context, volumes)
|
|
|
|
if err != nil {
|
|
|
|
assert.Error(t, err, tc.expected)
|
|
|
|
} else {
|
|
|
|
assert.Equal(t, out.String(), tc.expected)
|
|
|
|
}
|
|
|
|
})
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
}
|
2016-09-13 03:01:31 -04:00
|
|
|
|
|
|
|
func TestVolumeContextWriteJSON(t *testing.T) {
|
2022-04-29 13:26:50 -04:00
|
|
|
volumes := []*volume.Volume{
|
2016-09-13 03:01:31 -04:00
|
|
|
{Driver: "foo", Name: "foobar_baz"},
|
|
|
|
{Driver: "bar", Name: "foobar_bar"},
|
|
|
|
}
|
2023-11-20 12:04:36 -05:00
|
|
|
expectedJSONs := []map[string]any{
|
2021-02-23 09:23:53 -05:00
|
|
|
{"Availability": "N/A", "Driver": "foo", "Group": "N/A", "Labels": "", "Links": "N/A", "Mountpoint": "", "Name": "foobar_baz", "Scope": "", "Size": "N/A", "Status": "N/A"},
|
|
|
|
{"Availability": "N/A", "Driver": "bar", "Group": "N/A", "Labels": "", "Links": "N/A", "Mountpoint": "", "Name": "foobar_bar", "Scope": "", "Size": "N/A", "Status": "N/A"},
|
2016-09-13 03:01:31 -04:00
|
|
|
}
|
|
|
|
out := bytes.NewBufferString("")
|
|
|
|
err := VolumeWrite(Context{Format: "{{json .}}", Output: out}, volumes)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
2017-06-15 12:28:08 -04:00
|
|
|
msg := fmt.Sprintf("Output: line %d: %s", i, line)
|
2023-11-20 12:04:36 -05:00
|
|
|
var m map[string]any
|
2017-06-15 12:28:08 -04:00
|
|
|
err := json.Unmarshal([]byte(line), &m)
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.NilError(t, err, msg)
|
|
|
|
assert.Check(t, is.DeepEqual(expectedJSONs[i], m), msg)
|
2016-09-13 03:01:31 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestVolumeContextWriteJSONField(t *testing.T) {
|
2022-04-29 13:26:50 -04:00
|
|
|
volumes := []*volume.Volume{
|
2016-09-13 03:01:31 -04:00
|
|
|
{Driver: "foo", Name: "foobar_baz"},
|
|
|
|
{Driver: "bar", Name: "foobar_bar"},
|
|
|
|
}
|
|
|
|
out := bytes.NewBufferString("")
|
|
|
|
err := VolumeWrite(Context{Format: "{{json .Name}}", Output: out}, volumes)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
2017-06-15 12:28:08 -04:00
|
|
|
msg := fmt.Sprintf("Output: line %d: %s", i, line)
|
2016-09-13 03:01:31 -04:00
|
|
|
var s string
|
2017-06-15 12:28:08 -04:00
|
|
|
err := json.Unmarshal([]byte(line), &s)
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.NilError(t, err, msg)
|
|
|
|
assert.Check(t, is.Equal(volumes[i].Name, s), msg)
|
2016-09-13 03:01:31 -04:00
|
|
|
}
|
|
|
|
}
|