Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/gometalinter.json

47 lines
906 B
JSON
Raw Normal View History

Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 15:10:03 -04:00
{
"Vendor": true,
Gometalinter: raise deadline to 3 minutes Looks like we're just on the edge of the deadline, and it's sometimes failing; ``` cli/command/image/trust.go:346:1:warning: nolint directive did not match any issue (nolint) cli/command/manifest/push.go:211:1:warning: nolint directive did not match any issue (nolint) internal/pkg/containerized/snapshot.go:95:1:warning: nolint directive did not match any issue (nolint) internal/pkg/containerized/snapshot.go:138:1:warning: nolint directive did not match any issue (nolint) WARNING: deadline exceeded by linter interfacer (try increasing --deadline) Exited with code 3 ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-10-28 07:49:41 -04:00
"Deadline": "3m",
Update gometalinter The update includes bug fixes in gometalinter and updates to linters, which discovered more linter problems. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-09-26 12:33:35 -04:00
"Sort": ["linter", "severity", "path", "line"],
gometalinter: fix configuration The configuration abused "Exclude" to exclude file-paths by filtering on the output, however, the `Skip` option was designed for that, whereas `Exclude` is for matching warnings. An explicit "Skip" was added for "vendor", because even though the vendor directory should already be ignored by the linter, in some situations, it still seemed to warn on issues, so let's explicitly ignore it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-10-24 10:28:51 -04:00
"Skip": [
Update gometalinter The update includes bug fixes in gometalinter and updates to linters, which discovered more linter problems. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-09-26 12:33:35 -04:00
"cli/compose/schema/bindata.go",
Add support for kubernetes in docker cli - Add support for kubernetes for docker stack command - Update to go 1.9 - Add kubernetes to vendors - Print orchestrator in docker version command Signed-off-by: Vincent Demeester <vincent@sbr.pm> Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
2017-11-20 09:30:52 -05:00
"cli/command/stack/kubernetes/api/openapi",
"cli/command/stack/kubernetes/api/client",
".*generated.*",
gometalinter: fix configuration The configuration abused "Exclude" to exclude file-paths by filtering on the output, however, the `Skip` option was designed for that, whereas `Exclude` is for matching warnings. An explicit "Skip" was added for "vendor", because even though the vendor directory should already be ignored by the linter, in some situations, it still seemed to warn on issues, so let's explicitly ignore it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-10-24 10:28:51 -04:00
"vendor"
],
"Exclude": [
"parameter .* always receives",
"_esc(Dir|FS|FSString|FSMustString) is unused"
Update gometalinter The update includes bug fixes in gometalinter and updates to linters, which discovered more linter problems. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-09-26 12:33:35 -04:00
],
"EnableGC": true,
Add nakedret linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-10-12 11:44:03 -04:00
"Linters": {
"nakedret": {
"Command": "nakedret",
"Pattern": "^(?P<path>.*?\\.go):(?P<line>\\d+)\\s*(?P<message>.*)$"
}
},
Update gometalinter and enable the new WarnUnmatchedDirective to warn if a nolint is unnecessary. remove some unnecessary nolint Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-10-11 12:18:27 -04:00
"WarnUnmatchedDirective": true,
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 15:10:03 -04:00
"DisableAll": true,
Add deadcode linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 15:48:52 -04:00
"Enable": [
Add ineffassign linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 16:22:13 -04:00
"deadcode",
"gocyclo",
Add deadcode linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 15:48:52 -04:00
"gofmt",
"goimports",
Add ineffassign linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 16:22:13 -04:00
"golint",
Add gosimple lint Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-06-09 17:42:16 -04:00
"gosimple",
Add ineffassign linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 16:22:13 -04:00
"ineffassign",
Add interfacer linter Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-03 17:58:52 -04:00
"interfacer",
Add line length linter Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-03 18:14:30 -04:00
"lll",
Add misspell lint Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-23 11:33:38 -04:00
"misspell",
Add nakedret linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-10-12 11:44:03 -04:00
"nakedret",
Add unconvert linter Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-06-09 16:41:53 -04:00
"unconvert",
Add unparam linter Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-06-09 17:16:56 -04:00
"unparam",
Add unused linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-06-09 12:32:14 -04:00
"unused",
Add ineffassign linter. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 16:22:13 -04:00
"vet"
Add gocycle lint Whitelist some existing offenders, and use a high limit for now. This limit should decrese over time. Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 16:14:43 -04:00
],
Refactor image commands to make use of the new trust struct for trusted pull Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-09-26 12:53:21 -04:00
"Cyclo": 16,
Add line length linter Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-03 18:14:30 -04:00
"LineLength": 200
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-05-02 15:10:03 -04:00
}