2018-10-23 11:05:44 -04:00
|
|
|
package plugin
|
2016-11-22 19:23:21 -05:00
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"encoding/json"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
2018-10-23 11:05:44 -04:00
|
|
|
"github.com/docker/cli/cli/command/formatter"
|
|
|
|
"github.com/docker/cli/internal/test"
|
2016-11-22 19:23:21 -05:00
|
|
|
"github.com/docker/docker/api/types"
|
|
|
|
"github.com/docker/docker/pkg/stringid"
|
2020-02-22 12:12:14 -05:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
is "gotest.tools/v3/assert/cmp"
|
2016-11-22 19:23:21 -05:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestPluginContext(t *testing.T) {
|
|
|
|
pluginID := stringid.GenerateRandomID()
|
|
|
|
|
|
|
|
var ctx pluginContext
|
|
|
|
cases := []struct {
|
|
|
|
pluginCtx pluginContext
|
|
|
|
expValue string
|
|
|
|
call func() string
|
|
|
|
}{
|
|
|
|
{pluginContext{
|
|
|
|
p: types.Plugin{ID: pluginID},
|
|
|
|
trunc: false,
|
2017-02-03 19:48:46 -05:00
|
|
|
}, pluginID, ctx.ID},
|
2016-11-22 19:23:21 -05:00
|
|
|
{pluginContext{
|
|
|
|
p: types.Plugin{ID: pluginID},
|
|
|
|
trunc: true,
|
2017-02-03 19:48:46 -05:00
|
|
|
}, stringid.TruncateID(pluginID), ctx.ID},
|
2016-11-22 19:23:21 -05:00
|
|
|
{pluginContext{
|
|
|
|
p: types.Plugin{Name: "plugin_name"},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "plugin_name", ctx.Name},
|
2016-11-22 19:23:21 -05:00
|
|
|
{pluginContext{
|
|
|
|
p: types.Plugin{Config: types.PluginConfig{Description: "plugin_description"}},
|
2017-02-03 19:48:46 -05:00
|
|
|
}, "plugin_description", ctx.Description},
|
2016-11-22 19:23:21 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
ctx = c.pluginCtx
|
|
|
|
v := c.call()
|
|
|
|
if strings.Contains(v, ",") {
|
2018-10-23 11:05:44 -04:00
|
|
|
test.CompareMultipleValues(t, v, c.expValue)
|
2016-11-22 19:23:21 -05:00
|
|
|
} else if v != c.expValue {
|
|
|
|
t.Fatalf("Expected %s, was %s\n", c.expValue, v)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPluginContextWrite(t *testing.T) {
|
|
|
|
cases := []struct {
|
2018-10-23 11:05:44 -04:00
|
|
|
context formatter.Context
|
2016-11-22 19:23:21 -05:00
|
|
|
expected string
|
|
|
|
}{
|
|
|
|
|
|
|
|
// Errors
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: "{{InvalidFunction}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4ab70bf61e87271ca56511172352296a202ced41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1: function "InvalidFunction" not defined`,
|
2016-11-22 19:23:21 -05:00
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: "{{nil}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4ab70bf61e87271ca56511172352296a202ced41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1:2: executing "" at <nil>: nil is not a command`,
|
2016-11-22 19:23:21 -05:00
|
|
|
},
|
|
|
|
// Table format
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("table", false)},
|
2020-08-28 17:00:21 -04:00
|
|
|
`ID NAME DESCRIPTION ENABLED
|
|
|
|
pluginID1 foobar_baz description 1 true
|
|
|
|
pluginID2 foobar_bar description 2 false
|
2016-11-22 19:23:21 -05:00
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("table", true)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`pluginID1
|
|
|
|
pluginID2
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("table {{.Name}}", false)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`NAME
|
|
|
|
foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("table {{.Name}}", true)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`NAME
|
|
|
|
foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Raw Format
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("raw", false)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`plugin_id: pluginID1
|
|
|
|
name: foobar_baz
|
|
|
|
description: description 1
|
|
|
|
enabled: true
|
|
|
|
|
|
|
|
plugin_id: pluginID2
|
|
|
|
name: foobar_bar
|
|
|
|
description: description 2
|
|
|
|
enabled: false
|
|
|
|
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("raw", true)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`plugin_id: pluginID1
|
|
|
|
plugin_id: pluginID2
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Custom Format
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewFormat("{{.Name}}", false)},
|
2016-11-22 19:23:21 -05:00
|
|
|
`foobar_baz
|
|
|
|
foobar_bar
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2020-08-28 17:00:21 -04:00
|
|
|
plugins := []*types.Plugin{
|
|
|
|
{ID: "pluginID1", Name: "foobar_baz", Config: types.PluginConfig{Description: "description 1"}, Enabled: true},
|
|
|
|
{ID: "pluginID2", Name: "foobar_bar", Config: types.PluginConfig{Description: "description 2"}, Enabled: false},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range cases {
|
|
|
|
tc := tc
|
|
|
|
t.Run(string(tc.context.Format), func(t *testing.T) {
|
|
|
|
var out bytes.Buffer
|
|
|
|
tc.context.Output = &out
|
|
|
|
|
|
|
|
err := FormatWrite(tc.context, plugins)
|
|
|
|
if err != nil {
|
|
|
|
assert.Error(t, err, tc.expected)
|
|
|
|
} else {
|
|
|
|
assert.Equal(t, out.String(), tc.expected)
|
|
|
|
}
|
|
|
|
})
|
2016-11-22 19:23:21 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPluginContextWriteJSON(t *testing.T) {
|
|
|
|
plugins := []*types.Plugin{
|
|
|
|
{ID: "pluginID1", Name: "foobar_baz"},
|
|
|
|
{ID: "pluginID2", Name: "foobar_bar"},
|
|
|
|
}
|
|
|
|
expectedJSONs := []map[string]interface{}{
|
2017-01-28 19:54:32 -05:00
|
|
|
{"Description": "", "Enabled": false, "ID": "pluginID1", "Name": "foobar_baz", "PluginReference": ""},
|
|
|
|
{"Description": "", "Enabled": false, "ID": "pluginID2", "Name": "foobar_bar", "PluginReference": ""},
|
2016-11-22 19:23:21 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
out := bytes.NewBufferString("")
|
2018-10-23 11:05:44 -04:00
|
|
|
err := FormatWrite(formatter.Context{Format: "{{json .}}", Output: out}, plugins)
|
2016-11-22 19:23:21 -05:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
|
|
|
var m map[string]interface{}
|
|
|
|
if err := json.Unmarshal([]byte(line), &m); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.Check(t, is.DeepEqual(expectedJSONs[i], m))
|
2016-11-22 19:23:21 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestPluginContextWriteJSONField(t *testing.T) {
|
|
|
|
plugins := []*types.Plugin{
|
|
|
|
{ID: "pluginID1", Name: "foobar_baz"},
|
|
|
|
{ID: "pluginID2", Name: "foobar_bar"},
|
|
|
|
}
|
|
|
|
out := bytes.NewBufferString("")
|
2018-10-23 11:05:44 -04:00
|
|
|
err := FormatWrite(formatter.Context{Format: "{{json .ID}}", Output: out}, plugins)
|
2016-11-22 19:23:21 -05:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
|
|
|
var s string
|
|
|
|
if err := json.Unmarshal([]byte(line), &s); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.Check(t, is.Equal(plugins[i].ID, s))
|
2016-11-22 19:23:21 -05:00
|
|
|
}
|
|
|
|
}
|