DockerCLI/dockerfiles/Dockerfile.lint

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.19.7
ARG ALPINE_VERSION=3.16
ARG GOLANGCI_LINT_VERSION=v1.52.2

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint
ENV GO111MODULE=off
ENV CGO_ENABLED=0
ENV GOGC=75
WORKDIR /go/src/github.com/docker/cli
COPY --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
        golangci-lint run
Dockerfile: use syntax=docker/dockerfile:1 Now that HEREDOC is included in the stable Dockerfile syntax, we can use the latest stable syntax for all Dockerfiles. The recommendation for the stable syntax is to use `:1` (which is equivalent to "latest" stable syntax. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-03-17 05:37:08 -04:00			`# syntax=docker/dockerfile:1`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
update to go1.19.7 Includes a security fix for crypto/elliptic (CVE-2023-24532). > go1.19.7 (released 2023-03-07) includes a security fix to the crypto/elliptic > package, as well as bug fixes to the linker, the runtime, and the crypto/x509 > and syscall packages. See the Go 1.19.7 milestone on our issue tracker for > details. https://go.dev/doc/devel/release#go1.19.minor From the announcement: > We have just released Go versions 1.20.2 and 1.19.7, minor point releases. > > These minor releases include 1 security fixes following the security policy: > > - crypto/elliptic: incorrect P-256 ScalarMult and ScalarBaseMult results > > The ScalarMult and ScalarBaseMult methods of the P256 Curve may return an > incorrect result if called with some specific unreduced scalars (a scalar larger > than the order of the curve). > > This does not impact usages of crypto/ecdsa or crypto/ecdh. > > This is CVE-2023-24532 and Go issue https://go.dev/issue/58647. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-03-10 04:22:54 -05:00			`ARG GO_VERSION=1.19.7`
Dockerfile: add ALPINE_VERSION build-arg This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see https://github.com/moby/moby/issues/44570 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-12-04 08:01:30 -05:00			`ARG ALPINE_VERSION=3.16`
update golangci-lint to v1.52.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-03-28 14:13:44 -04:00			`ARG GOLANGCI_LINT_VERSION=v1.52.2`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
Dockerfile: add ALPINE_VERSION build-arg This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see https://github.com/moby/moby/issues/44570 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-12-04 08:01:30 -05:00			`FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`ENV GO111MODULE=off`
			`ENV CGO_ENABLED=0`
			`ENV GOGC=75`
Remove now obsolete gometalinter and use golangci-lint instead Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2019-04-02 11:27:12 -04:00			`WORKDIR /go/src/github.com/docker/cli`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`COPY --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint`
			`RUN --mount=type=bind,target=. \`
			`--mount=type=cache,target=/root/.cache \`
			`golangci-lint run`