add //go:build directives to prevent downgrading to go1.16 language
This is a follow-up to 0e73168b7e6d1d029d76d05b843b1aaec46739a8
This repository is not yet a module (i.e., does not have a `go.mod`). This
is not problematic when building the code in GOPATH or "vendor" mode, but
when using the code as a module-dependency (in module-mode), different semantics
are applied since Go1.21, which switches Go _language versions_ on a per-module,
per-package, or even per-file base.
A condensed summary of that logic [is as follows][1]:
- For modules that have a go.mod containing a go version directive; that
version is considered a minimum _required_ version (starting with the
go1.19.13 and go1.20.8 patch releases: before those, it was only a
recommendation).
- For dependencies that don't have a go.mod (not a module), go language
version go1.16 is assumed.
- Likewise, for modules that have a go.mod, but the file does not have a
go version directive, go language version go1.16 is assumed.
- If a go.work file is present, but does not have a go version directive,
language version go1.17 is assumed.
When switching language versions, Go _downgrades_ the language version,
which means that language features (such as generics, and `any`) are not
available, and compilation fails. For example:
# github.com/docker/cli/cli/context/store
/go/pkg/mod/github.com/docker/cli@v25.0.0-beta.2+incompatible/cli/context/store/storeconfig.go:6:24: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)
/go/pkg/mod/github.com/docker/cli@v25.0.0-beta.2+incompatible/cli/context/store/store.go:74:12: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)
Note that these fallbacks are per-module, per-package, and can even be
per-file, so _(indirect) dependencies_ can still use modern language
features, as long as their respective go.mod has a version specified.
Unfortunately, these failures do not occur when building locally (using
vendor / GOPATH mode), but will affect consumers of the module.
Obviously, this situation is not ideal, and the ultimate solution is to
move to go modules (add a go.mod), but this comes with a non-insignificant
risk in other areas (due to our complex dependency tree).
We can revert to using go1.16 language features only, but this may be
limiting, and may still be problematic when (e.g.) matching signatures
of dependencies.
There is an escape hatch: adding a `//go:build` directive to files that
make use of go language features. From the [go toolchain docs][2]:
> The go line for each module sets the language version the compiler enforces
> when compiling packages in that module. The language version can be changed
> on a per-file basis by using a build constraint.
>
> For example, a module containing code that uses the Go 1.21 language version
> should have a `go.mod` file with a go line such as `go 1.21` or `go 1.21.3`.
> If a specific source file should be compiled only when using a newer Go
> toolchain, adding `//go:build go1.22` to that source file both ensures that
> only Go 1.22 and newer toolchains will compile the file and also changes
> the language version in that file to Go 1.22.
This patch adds `//go:build` directives to those files using recent additions
to the language. It's currently using go1.19 as version to match the version
in our "vendor.mod", but we can consider being more permissive ("any" requires
go1.18 or up), or more "optimistic" (force go1.21, which is the version we
currently use to build).
For completeness sake, note that any file _without_ a `//go:build` directive
will continue to use go1.16 language version when used as a module.
[1]: https://github.com/golang/go/blob/58c28ba286dd0e98fe4cca80f5d64bbcb824a685/src/cmd/go/internal/gover/version.go#L9-L56
[2]; https://go.dev/doc/toolchain#:~:text=The%20go%20line%20for,file%20to%20Go%201.22
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-12-14 07:51:57 -05:00
|
|
|
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
|
2024-11-12 06:32:30 -05:00
|
|
|
//go:build go1.22
|
add //go:build directives to prevent downgrading to go1.16 language
This is a follow-up to 0e73168b7e6d1d029d76d05b843b1aaec46739a8
This repository is not yet a module (i.e., does not have a `go.mod`). This
is not problematic when building the code in GOPATH or "vendor" mode, but
when using the code as a module-dependency (in module-mode), different semantics
are applied since Go1.21, which switches Go _language versions_ on a per-module,
per-package, or even per-file base.
A condensed summary of that logic [is as follows][1]:
- For modules that have a go.mod containing a go version directive; that
version is considered a minimum _required_ version (starting with the
go1.19.13 and go1.20.8 patch releases: before those, it was only a
recommendation).
- For dependencies that don't have a go.mod (not a module), go language
version go1.16 is assumed.
- Likewise, for modules that have a go.mod, but the file does not have a
go version directive, go language version go1.16 is assumed.
- If a go.work file is present, but does not have a go version directive,
language version go1.17 is assumed.
When switching language versions, Go _downgrades_ the language version,
which means that language features (such as generics, and `any`) are not
available, and compilation fails. For example:
# github.com/docker/cli/cli/context/store
/go/pkg/mod/github.com/docker/cli@v25.0.0-beta.2+incompatible/cli/context/store/storeconfig.go:6:24: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)
/go/pkg/mod/github.com/docker/cli@v25.0.0-beta.2+incompatible/cli/context/store/store.go:74:12: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod)
Note that these fallbacks are per-module, per-package, and can even be
per-file, so _(indirect) dependencies_ can still use modern language
features, as long as their respective go.mod has a version specified.
Unfortunately, these failures do not occur when building locally (using
vendor / GOPATH mode), but will affect consumers of the module.
Obviously, this situation is not ideal, and the ultimate solution is to
move to go modules (add a go.mod), but this comes with a non-insignificant
risk in other areas (due to our complex dependency tree).
We can revert to using go1.16 language features only, but this may be
limiting, and may still be problematic when (e.g.) matching signatures
of dependencies.
There is an escape hatch: adding a `//go:build` directive to files that
make use of go language features. From the [go toolchain docs][2]:
> The go line for each module sets the language version the compiler enforces
> when compiling packages in that module. The language version can be changed
> on a per-file basis by using a build constraint.
>
> For example, a module containing code that uses the Go 1.21 language version
> should have a `go.mod` file with a go line such as `go 1.21` or `go 1.21.3`.
> If a specific source file should be compiled only when using a newer Go
> toolchain, adding `//go:build go1.22` to that source file both ensures that
> only Go 1.22 and newer toolchains will compile the file and also changes
> the language version in that file to Go 1.22.
This patch adds `//go:build` directives to those files using recent additions
to the language. It's currently using go1.19 as version to match the version
in our "vendor.mod", but we can consider being more permissive ("any" requires
go1.18 or up), or more "optimistic" (force go1.21, which is the version we
currently use to build).
For completeness sake, note that any file _without_ a `//go:build` directive
will continue to use go1.16 language version when used as a module.
[1]: https://github.com/golang/go/blob/58c28ba286dd0e98fe4cca80f5d64bbcb824a685/src/cmd/go/internal/gover/version.go#L9-L56
[2]; https://go.dev/doc/toolchain#:~:text=The%20go%20line%20for,file%20to%20Go%201.22
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-12-14 07:51:57 -05:00
|
|
|
|
2016-09-08 13:11:39 -04:00
|
|
|
package command
|
|
|
|
|
|
|
|
import (
|
2017-02-03 19:07:04 -05:00
|
|
|
"bufio"
|
2024-02-21 10:36:17 -05:00
|
|
|
"context"
|
2016-09-08 13:11:39 -04:00
|
|
|
"fmt"
|
|
|
|
"io"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
2016-12-09 17:21:45 -05:00
|
|
|
"runtime"
|
2016-09-08 13:11:39 -04:00
|
|
|
"strings"
|
2017-01-11 18:55:43 -05:00
|
|
|
|
2019-01-28 08:30:31 -05:00
|
|
|
"github.com/docker/cli/cli/streams"
|
2017-02-04 12:10:05 -05:00
|
|
|
"github.com/docker/docker/api/types/filters"
|
2023-07-20 09:50:14 -04:00
|
|
|
mounttypes "github.com/docker/docker/api/types/mount"
|
|
|
|
"github.com/docker/docker/api/types/versions"
|
2024-03-12 07:38:47 -04:00
|
|
|
"github.com/docker/docker/errdefs"
|
2022-08-27 08:49:24 -04:00
|
|
|
"github.com/moby/sys/sequential"
|
2024-06-18 08:18:49 -04:00
|
|
|
"github.com/moby/term"
|
2019-02-07 03:17:35 -05:00
|
|
|
"github.com/pkg/errors"
|
2017-08-02 20:31:32 -04:00
|
|
|
"github.com/spf13/pflag"
|
2016-09-08 13:11:39 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
// CopyToFile writes the content of the reader to the specified file
|
|
|
|
func CopyToFile(outfile string, r io.Reader) error {
|
2017-01-11 18:55:43 -05:00
|
|
|
// We use sequential file access here to avoid depleting the standby list
|
2022-04-08 08:56:48 -04:00
|
|
|
// on Windows. On Linux, this is a call directly to os.CreateTemp
|
2022-08-27 08:49:24 -04:00
|
|
|
tmpFile, err := sequential.CreateTemp(filepath.Dir(outfile), ".docker_temp_")
|
2016-09-08 13:11:39 -04:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
tmpPath := tmpFile.Name()
|
|
|
|
|
|
|
|
_, err = io.Copy(tmpFile, r)
|
|
|
|
tmpFile.Close()
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
os.Remove(tmpPath)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err = os.Rename(tmpPath, outfile); err != nil {
|
|
|
|
os.Remove(tmpPath)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// capitalizeFirst capitalizes the first character of string
|
|
|
|
func capitalizeFirst(s string) string {
|
|
|
|
switch l := len(s); l {
|
|
|
|
case 0:
|
|
|
|
return s
|
|
|
|
case 1:
|
|
|
|
return strings.ToLower(s)
|
|
|
|
default:
|
|
|
|
return strings.ToUpper(string(s[0])) + strings.ToLower(s[1:])
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// PrettyPrint outputs arbitrary data for human formatted output by uppercasing the first letter.
|
2023-11-20 12:04:36 -05:00
|
|
|
func PrettyPrint(i any) string {
|
2016-09-08 13:11:39 -04:00
|
|
|
switch t := i.(type) {
|
|
|
|
case nil:
|
|
|
|
return "None"
|
|
|
|
case string:
|
|
|
|
return capitalizeFirst(t)
|
|
|
|
default:
|
|
|
|
return capitalizeFirst(fmt.Sprintf("%s", t))
|
|
|
|
}
|
|
|
|
}
|
2016-09-22 17:04:34 -04:00
|
|
|
|
2024-03-12 07:38:47 -04:00
|
|
|
var ErrPromptTerminated = errdefs.Cancelled(errors.New("prompt terminated"))
|
2024-02-21 10:36:17 -05:00
|
|
|
|
2024-06-18 08:18:49 -04:00
|
|
|
// DisableInputEcho disables input echo on the provided streams.In.
|
|
|
|
// This is useful when the user provides sensitive information like passwords.
|
|
|
|
// The function returns a restore function that should be called to restore the
|
|
|
|
// terminal state.
|
|
|
|
func DisableInputEcho(ins *streams.In) (restore func() error, err error) {
|
|
|
|
oldState, err := term.SaveState(ins.FD())
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
restore = func() error {
|
|
|
|
return term.RestoreTerminal(ins.FD(), oldState)
|
|
|
|
}
|
|
|
|
return restore, term.DisableEcho(ins.FD(), oldState)
|
|
|
|
}
|
|
|
|
|
|
|
|
// PromptForInput requests input from the user.
|
|
|
|
//
|
|
|
|
// If the user terminates the CLI with SIGINT or SIGTERM while the prompt is
|
|
|
|
// active, the prompt will return an empty string ("") with an ErrPromptTerminated error.
|
|
|
|
// When the prompt returns an error, the caller should propagate the error up
|
|
|
|
// the stack and close the io.Reader used for the prompt which will prevent the
|
|
|
|
// background goroutine from blocking indefinitely.
|
|
|
|
func PromptForInput(ctx context.Context, in io.Reader, out io.Writer, message string) (string, error) {
|
|
|
|
_, _ = fmt.Fprint(out, message)
|
|
|
|
|
|
|
|
result := make(chan string)
|
|
|
|
go func() {
|
|
|
|
scanner := bufio.NewScanner(in)
|
|
|
|
if scanner.Scan() {
|
|
|
|
result <- strings.TrimSpace(scanner.Text())
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
select {
|
|
|
|
case <-ctx.Done():
|
|
|
|
_, _ = fmt.Fprintln(out, "")
|
|
|
|
return "", ErrPromptTerminated
|
|
|
|
case r := <-result:
|
|
|
|
return r, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-02-21 10:36:17 -05:00
|
|
|
// PromptForConfirmation requests and checks confirmation from the user.
|
|
|
|
// This will display the provided message followed by ' [y/N] '. If the user
|
|
|
|
// input 'y' or 'Y' it returns true otherwise false. If no message is provided,
|
|
|
|
// "Are you sure you want to proceed? [y/N] " will be used instead.
|
|
|
|
//
|
|
|
|
// If the user terminates the CLI with SIGINT or SIGTERM while the prompt is
|
|
|
|
// active, the prompt will return false with an ErrPromptTerminated error.
|
|
|
|
// When the prompt returns an error, the caller should propagate the error up
|
|
|
|
// the stack and close the io.Reader used for the prompt which will prevent the
|
|
|
|
// background goroutine from blocking indefinitely.
|
|
|
|
func PromptForConfirmation(ctx context.Context, ins io.Reader, outs io.Writer, message string) (bool, error) {
|
2016-09-22 17:04:34 -04:00
|
|
|
if message == "" {
|
2016-10-08 22:29:58 -04:00
|
|
|
message = "Are you sure you want to proceed?"
|
2016-09-22 17:04:34 -04:00
|
|
|
}
|
|
|
|
message += " [y/N] "
|
|
|
|
|
2019-10-29 05:10:03 -04:00
|
|
|
_, _ = fmt.Fprint(outs, message)
|
2016-09-22 17:04:34 -04:00
|
|
|
|
2016-12-09 17:21:45 -05:00
|
|
|
// On Windows, force the use of the regular OS stdin stream.
|
|
|
|
if runtime.GOOS == "windows" {
|
2019-01-28 08:30:31 -05:00
|
|
|
ins = streams.NewIn(os.Stdin)
|
2016-12-09 17:21:45 -05:00
|
|
|
}
|
|
|
|
|
2024-02-21 10:36:17 -05:00
|
|
|
result := make(chan bool)
|
|
|
|
|
|
|
|
go func() {
|
|
|
|
var res bool
|
|
|
|
scanner := bufio.NewScanner(ins)
|
|
|
|
if scanner.Scan() {
|
|
|
|
answer := strings.TrimSpace(scanner.Text())
|
|
|
|
if strings.EqualFold(answer, "y") {
|
|
|
|
res = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
result <- res
|
|
|
|
}()
|
|
|
|
|
|
|
|
select {
|
2024-04-08 04:11:09 -04:00
|
|
|
case <-ctx.Done():
|
2024-04-02 09:44:23 -04:00
|
|
|
_, _ = fmt.Fprintln(outs, "")
|
2024-02-21 10:36:17 -05:00
|
|
|
return false, ErrPromptTerminated
|
|
|
|
case r := <-result:
|
|
|
|
return r, nil
|
|
|
|
}
|
2016-09-22 17:04:34 -04:00
|
|
|
}
|
2017-02-04 12:10:05 -05:00
|
|
|
|
|
|
|
// PruneFilters returns consolidated prune filters obtained from config.json and cli
|
|
|
|
func PruneFilters(dockerCli Cli, pruneFilters filters.Args) filters.Args {
|
|
|
|
if dockerCli.ConfigFile() == nil {
|
|
|
|
return pruneFilters
|
|
|
|
}
|
|
|
|
for _, f := range dockerCli.ConfigFile().PruneFilters {
|
2022-12-27 10:29:21 -05:00
|
|
|
k, v, ok := strings.Cut(f, "=")
|
|
|
|
if !ok {
|
2017-02-04 12:10:05 -05:00
|
|
|
continue
|
|
|
|
}
|
2022-12-27 10:29:21 -05:00
|
|
|
if k == "label" {
|
2017-02-04 12:10:05 -05:00
|
|
|
// CLI label filter supersede config.json.
|
|
|
|
// If CLI label filter conflict with config.json,
|
|
|
|
// skip adding label! filter in config.json.
|
2022-12-27 10:29:21 -05:00
|
|
|
if pruneFilters.Contains("label!") && pruneFilters.ExactMatch("label!", v) {
|
2017-02-04 12:10:05 -05:00
|
|
|
continue
|
|
|
|
}
|
2022-12-27 10:29:21 -05:00
|
|
|
} else if k == "label!" {
|
2017-02-04 12:10:05 -05:00
|
|
|
// CLI label! filter supersede config.json.
|
|
|
|
// If CLI label! filter conflict with config.json,
|
|
|
|
// skip adding label filter in config.json.
|
2022-12-27 10:29:21 -05:00
|
|
|
if pruneFilters.Contains("label") && pruneFilters.ExactMatch("label", v) {
|
2017-02-04 12:10:05 -05:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
2022-12-27 10:29:21 -05:00
|
|
|
pruneFilters.Add(k, v)
|
2017-02-04 12:10:05 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
return pruneFilters
|
|
|
|
}
|
2017-08-02 20:31:32 -04:00
|
|
|
|
|
|
|
// AddPlatformFlag adds `platform` to a set of flags for API version 1.32 and later.
|
|
|
|
func AddPlatformFlag(flags *pflag.FlagSet, target *string) {
|
|
|
|
flags.StringVar(target, "platform", os.Getenv("DOCKER_DEFAULT_PLATFORM"), "Set platform if server is multi-platform capable")
|
2024-10-20 11:51:36 -04:00
|
|
|
_ = flags.SetAnnotation("platform", "version", []string{"1.32"})
|
2017-08-02 20:31:32 -04:00
|
|
|
}
|
2019-02-07 03:17:35 -05:00
|
|
|
|
|
|
|
// ValidateOutputPath validates the output paths of the `export` and `save` commands.
|
|
|
|
func ValidateOutputPath(path string) error {
|
2019-10-30 15:07:18 -04:00
|
|
|
dir := filepath.Dir(filepath.Clean(path))
|
2019-02-07 03:17:35 -05:00
|
|
|
if dir != "" && dir != "." {
|
|
|
|
if _, err := os.Stat(dir); os.IsNotExist(err) {
|
|
|
|
return errors.Errorf("invalid output path: directory %q does not exist", dir)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// check whether `path` points to a regular file
|
|
|
|
// (if the path exists and doesn't point to a directory)
|
|
|
|
if fileInfo, err := os.Stat(path); !os.IsNotExist(err) {
|
2019-12-09 09:32:02 -05:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-02-07 03:17:35 -05:00
|
|
|
if fileInfo.Mode().IsDir() || fileInfo.Mode().IsRegular() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := ValidateOutputPathFileMode(fileInfo.Mode()); err != nil {
|
2024-08-26 07:52:49 -04:00
|
|
|
return errors.Wrapf(err, "invalid output path: %q must be a directory or a regular file", path)
|
2019-02-07 03:17:35 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateOutputPathFileMode validates the output paths of the `cp` command and serves as a
|
|
|
|
// helper to `ValidateOutputPath`
|
|
|
|
func ValidateOutputPathFileMode(fileMode os.FileMode) error {
|
|
|
|
switch {
|
|
|
|
case fileMode&os.ModeDevice != 0:
|
|
|
|
return errors.New("got a device")
|
|
|
|
case fileMode&os.ModeIrregular != 0:
|
|
|
|
return errors.New("got an irregular file")
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
2019-04-17 18:09:29 -04:00
|
|
|
|
|
|
|
func stringSliceIndex(s, subs []string) int {
|
|
|
|
j := 0
|
|
|
|
if len(subs) > 0 {
|
|
|
|
for i, x := range s {
|
|
|
|
if j < len(subs) && subs[j] == x {
|
|
|
|
j++
|
|
|
|
} else {
|
|
|
|
j = 0
|
|
|
|
}
|
|
|
|
if len(subs) == j {
|
|
|
|
return i + 1 - j
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
|
2023-11-20 05:15:36 -05:00
|
|
|
// StringSliceReplaceAt replaces the sub-slice find, with the sub-slice replace, in the string
|
2019-04-17 18:09:29 -04:00
|
|
|
// slice s, returning a new slice and a boolean indicating if the replacement happened.
|
|
|
|
// requireIdx is the index at which old needs to be found at (or -1 to disregard that).
|
2023-11-20 05:15:36 -05:00
|
|
|
func StringSliceReplaceAt(s, find, replace []string, requireIndex int) ([]string, bool) {
|
|
|
|
idx := stringSliceIndex(s, find)
|
2019-04-17 18:09:29 -04:00
|
|
|
if (requireIndex != -1 && requireIndex != idx) || idx == -1 {
|
|
|
|
return s, false
|
|
|
|
}
|
|
|
|
out := append([]string{}, s[:idx]...)
|
2023-11-20 05:15:36 -05:00
|
|
|
out = append(out, replace...)
|
|
|
|
out = append(out, s[idx+len(find):]...)
|
2019-04-17 18:09:29 -04:00
|
|
|
return out, true
|
|
|
|
}
|
2023-07-20 09:50:14 -04:00
|
|
|
|
|
|
|
// ValidateMountWithAPIVersion validates a mount with the server API version.
|
|
|
|
func ValidateMountWithAPIVersion(m mounttypes.Mount, serverAPIVersion string) error {
|
|
|
|
if m.BindOptions != nil {
|
|
|
|
if m.BindOptions.NonRecursive && versions.LessThan(serverAPIVersion, "1.40") {
|
|
|
|
return errors.Errorf("bind-recursive=disabled requires API v1.40 or later")
|
|
|
|
}
|
|
|
|
// ReadOnlyNonRecursive can be safely ignored when API < 1.44
|
|
|
|
if m.BindOptions.ReadOnlyForceRecursive && versions.LessThan(serverAPIVersion, "1.44") {
|
|
|
|
return errors.Errorf("bind-recursive=readonly requires API v1.44 or later")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|