2018-10-23 11:05:44 -04:00
|
|
|
package registry
|
2017-08-15 06:58:49 -04:00
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"encoding/json"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
2018-10-23 11:05:44 -04:00
|
|
|
"github.com/docker/cli/cli/command/formatter"
|
|
|
|
"github.com/docker/cli/internal/test"
|
2017-08-15 06:58:49 -04:00
|
|
|
registrytypes "github.com/docker/docker/api/types/registry"
|
2020-02-22 12:12:14 -05:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
is "gotest.tools/v3/assert/cmp"
|
|
|
|
"gotest.tools/v3/golden"
|
2017-08-15 06:58:49 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestSearchContext(t *testing.T) {
|
|
|
|
name := "nginx"
|
|
|
|
starCount := 5000
|
|
|
|
|
|
|
|
var ctx searchContext
|
|
|
|
cases := []struct {
|
|
|
|
searchCtx searchContext
|
|
|
|
expValue string
|
|
|
|
call func() string
|
|
|
|
}{
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Name: name},
|
|
|
|
}, name, ctx.Name},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{StarCount: starCount},
|
|
|
|
}, "5000", ctx.StarCount},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{IsOfficial: true},
|
|
|
|
}, "[OK]", ctx.IsOfficial},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{IsOfficial: false},
|
|
|
|
}, "", ctx.IsOfficial},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{IsAutomated: true},
|
|
|
|
}, "[OK]", ctx.IsAutomated},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{IsAutomated: false},
|
|
|
|
}, "", ctx.IsAutomated},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
ctx = c.searchCtx
|
|
|
|
v := c.call()
|
|
|
|
if strings.Contains(v, ",") {
|
2018-10-23 11:05:44 -04:00
|
|
|
test.CompareMultipleValues(t, v, c.expValue)
|
2017-08-15 06:58:49 -04:00
|
|
|
} else if v != c.expValue {
|
|
|
|
t.Fatalf("Expected %s, was %s\n", c.expValue, v)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSearchContextDescription(t *testing.T) {
|
|
|
|
shortDescription := "Official build of Nginx."
|
|
|
|
longDescription := "Automated Nginx reverse proxy for docker containers"
|
|
|
|
descriptionWReturns := "Automated\nNginx reverse\rproxy\rfor docker\ncontainers"
|
|
|
|
|
|
|
|
var ctx searchContext
|
|
|
|
cases := []struct {
|
|
|
|
searchCtx searchContext
|
|
|
|
expValue string
|
|
|
|
call func() string
|
|
|
|
}{
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: shortDescription},
|
|
|
|
trunc: true,
|
|
|
|
}, shortDescription, ctx.Description},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: shortDescription},
|
|
|
|
trunc: false,
|
|
|
|
}, shortDescription, ctx.Description},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: longDescription},
|
|
|
|
trunc: false,
|
|
|
|
}, longDescription, ctx.Description},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: longDescription},
|
|
|
|
trunc: true,
|
2018-10-23 11:05:44 -04:00
|
|
|
}, formatter.Ellipsis(longDescription, 45), ctx.Description},
|
2017-08-15 06:58:49 -04:00
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: descriptionWReturns},
|
|
|
|
trunc: false,
|
|
|
|
}, longDescription, ctx.Description},
|
|
|
|
{searchContext{
|
|
|
|
s: registrytypes.SearchResult{Description: descriptionWReturns},
|
|
|
|
trunc: true,
|
2018-10-23 11:05:44 -04:00
|
|
|
}, formatter.Ellipsis(longDescription, 45), ctx.Description},
|
2017-08-15 06:58:49 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, c := range cases {
|
|
|
|
ctx = c.searchCtx
|
|
|
|
v := c.call()
|
|
|
|
if strings.Contains(v, ",") {
|
2018-10-23 11:05:44 -04:00
|
|
|
test.CompareMultipleValues(t, v, c.expValue)
|
2017-08-15 06:58:49 -04:00
|
|
|
} else if v != c.expValue {
|
|
|
|
t.Fatalf("Expected %s, was %s\n", c.expValue, v)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSearchContextWrite(t *testing.T) {
|
|
|
|
cases := []struct {
|
2018-10-23 11:05:44 -04:00
|
|
|
context formatter.Context
|
2017-08-15 06:58:49 -04:00
|
|
|
expected string
|
|
|
|
}{
|
|
|
|
|
|
|
|
// Errors
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: "{{InvalidFunction}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4ab70bf61e87271ca56511172352296a202ced41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1: function "InvalidFunction" not defined`,
|
2017-08-15 06:58:49 -04:00
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: "{{nil}}"},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4ab70bf61e87271ca56511172352296a202ced41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
`template parsing error: template: :1:2: executing "" at <nil>: nil is not a command`,
|
2017-08-15 06:58:49 -04:00
|
|
|
},
|
|
|
|
// Table format
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewSearchFormat("table")},
|
2017-09-07 17:50:44 -04:00
|
|
|
string(golden.Get(t, "search-context-write-table.golden")),
|
2017-08-15 06:58:49 -04:00
|
|
|
},
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewSearchFormat("table {{.Name}}")},
|
2017-08-15 06:58:49 -04:00
|
|
|
`NAME
|
|
|
|
result1
|
|
|
|
result2
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Custom Format
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewSearchFormat("{{.Name}}")},
|
2017-08-15 06:58:49 -04:00
|
|
|
`result1
|
|
|
|
result2
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
// Custom Format with CreatedAt
|
|
|
|
{
|
2018-10-23 11:05:44 -04:00
|
|
|
formatter.Context{Format: NewSearchFormat("{{.Name}} {{.StarCount}}")},
|
2017-08-15 06:58:49 -04:00
|
|
|
`result1 5000
|
|
|
|
result2 5
|
|
|
|
`,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
2020-08-28 17:00:21 -04:00
|
|
|
results := []registrytypes.SearchResult{
|
|
|
|
{Name: "result1", Description: "Official build", StarCount: 5000, IsOfficial: true, IsAutomated: false},
|
|
|
|
{Name: "result2", Description: "Not official", StarCount: 5, IsOfficial: false, IsAutomated: true},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range cases {
|
|
|
|
tc := tc
|
|
|
|
t.Run(string(tc.context.Format), func(t *testing.T) {
|
|
|
|
var out bytes.Buffer
|
|
|
|
tc.context.Output = &out
|
|
|
|
|
|
|
|
err := SearchWrite(tc.context, results)
|
|
|
|
if err != nil {
|
|
|
|
assert.Error(t, err, tc.expected)
|
|
|
|
} else {
|
|
|
|
assert.Equal(t, out.String(), tc.expected)
|
|
|
|
}
|
|
|
|
})
|
2017-08-15 06:58:49 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSearchContextWriteJSON(t *testing.T) {
|
|
|
|
results := []registrytypes.SearchResult{
|
|
|
|
{Name: "result1", Description: "Official build", StarCount: 5000, IsOfficial: true, IsAutomated: false},
|
|
|
|
{Name: "result2", Description: "Not official", StarCount: 5, IsOfficial: false, IsAutomated: true},
|
|
|
|
}
|
|
|
|
expectedJSONs := []map[string]interface{}{
|
|
|
|
{"Name": "result1", "Description": "Official build", "StarCount": "5000", "IsOfficial": "true", "IsAutomated": "false"},
|
|
|
|
{"Name": "result2", "Description": "Not official", "StarCount": "5", "IsOfficial": "false", "IsAutomated": "true"},
|
|
|
|
}
|
|
|
|
|
|
|
|
out := bytes.NewBufferString("")
|
2020-02-13 11:18:10 -05:00
|
|
|
err := SearchWrite(formatter.Context{Format: "{{json .}}", Output: out}, results)
|
2017-08-15 06:58:49 -04:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
|
|
|
t.Logf("Output: line %d: %s", i, line)
|
|
|
|
var m map[string]interface{}
|
|
|
|
if err := json.Unmarshal([]byte(line), &m); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.Check(t, is.DeepEqual(m, expectedJSONs[i]))
|
2017-08-15 06:58:49 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSearchContextWriteJSONField(t *testing.T) {
|
|
|
|
results := []registrytypes.SearchResult{
|
|
|
|
{Name: "result1", Description: "Official build", StarCount: 5000, IsOfficial: true, IsAutomated: false},
|
|
|
|
{Name: "result2", Description: "Not official", StarCount: 5, IsOfficial: false, IsAutomated: true},
|
|
|
|
}
|
|
|
|
out := bytes.NewBufferString("")
|
2020-02-13 11:18:10 -05:00
|
|
|
err := SearchWrite(formatter.Context{Format: "{{json .Name}}", Output: out}, results)
|
2017-08-15 06:58:49 -04:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
for i, line := range strings.Split(strings.TrimSpace(out.String()), "\n") {
|
|
|
|
t.Logf("Output: line %d: %s", i, line)
|
|
|
|
var s string
|
|
|
|
if err := json.Unmarshal([]byte(line), &s); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2018-03-05 18:53:52 -05:00
|
|
|
assert.Check(t, is.Equal(s, results[i].Name))
|
2017-08-15 06:58:49 -04:00
|
|
|
}
|
|
|
|
}
|