2017-05-24 00:45:38 -04:00
|
|
|
package command_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"testing"
|
|
|
|
|
2023-10-23 08:51:01 -04:00
|
|
|
"github.com/docker/cli/cli/command"
|
2023-07-10 11:24:07 -04:00
|
|
|
"github.com/docker/cli/cli/config/configfile"
|
2017-10-15 15:39:56 -04:00
|
|
|
configtypes "github.com/docker/cli/cli/config/types"
|
2023-02-07 20:31:59 -05:00
|
|
|
"github.com/docker/docker/api/types/registry"
|
2023-03-21 11:55:34 -04:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
is "gotest.tools/v3/assert/cmp"
|
2017-05-24 00:45:38 -04:00
|
|
|
)
|
|
|
|
|
2023-02-07 20:31:59 -05:00
|
|
|
var testAuthConfigs = []registry.AuthConfig{
|
2017-05-30 17:36:15 -04:00
|
|
|
{
|
|
|
|
ServerAddress: "https://index.docker.io/v1/",
|
|
|
|
Username: "u0",
|
|
|
|
Password: "p0",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
ServerAddress: "server1.io",
|
|
|
|
Username: "u1",
|
|
|
|
Password: "p1",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetDefaultAuthConfig(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
checkCredStore bool
|
|
|
|
inputServerAddress string
|
2023-02-07 20:31:59 -05:00
|
|
|
expectedAuthConfig registry.AuthConfig
|
2017-05-30 17:36:15 -04:00
|
|
|
}{
|
|
|
|
{
|
|
|
|
checkCredStore: false,
|
|
|
|
inputServerAddress: "",
|
2023-02-07 20:31:59 -05:00
|
|
|
expectedAuthConfig: registry.AuthConfig{
|
2017-05-30 17:36:15 -04:00
|
|
|
ServerAddress: "",
|
|
|
|
Username: "",
|
|
|
|
Password: "",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
checkCredStore: true,
|
|
|
|
inputServerAddress: testAuthConfigs[0].ServerAddress,
|
|
|
|
expectedAuthConfig: testAuthConfigs[0],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
checkCredStore: true,
|
|
|
|
inputServerAddress: testAuthConfigs[1].ServerAddress,
|
|
|
|
expectedAuthConfig: testAuthConfigs[1],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
checkCredStore: true,
|
linting: fmt.Sprintf can be replaced with string concatenation (perfsprint)
cli/registry/client/endpoint.go:128:34: fmt.Sprintf can be replaced with string concatenation (perfsprint)
req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", th.token))
^
cli/command/telemetry_docker.go:88:14: fmt.Sprintf can be replaced with string concatenation (perfsprint)
endpoint = fmt.Sprintf("unix://%s", path.Join(u.Host, u.Path))
^
cli/command/cli_test.go:195:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
opts := &flags.ClientOptions{Hosts: []string{fmt.Sprintf("unix://%s", socket)}}
^
cli/command/registry_test.go:59:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
inputServerAddress: fmt.Sprintf("https://%s", testAuthConfigs[1].ServerAddress),
^
cli/command/container/opts_test.go:338:35: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if config, _, _ := mustParse(t, fmt.Sprintf("--hostname=%s", hostname)); config.Hostname != expectedHostname {
^
cli/command/context/options.go:79:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("%s: unrecognized config key", k))
^
cli/command/image/build.go:461:68: fmt.Sprintf can be replaced with string concatenation (perfsprint)
line = dockerfileFromLinePattern.ReplaceAllLiteralString(line, fmt.Sprintf("FROM %s", reference.FamiliarString(trustedRef)))
^
cli/command/image/remove_test.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("Error: No such image: %s", n.imageID)
^
cli/command/image/build/context.go:229:102: fmt.Sprintf can be replaced with string concatenation (perfsprint)
progReader := progress.NewProgressReader(response.Body, progressOutput, response.ContentLength, "", fmt.Sprintf("Downloading build context from remote url: %s", remoteURL))
^
cli/command/service/logs.go:215:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", task.ID)
^
cli/command/service/logs.go:217:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
taskName += fmt.Sprintf(".%s", stringid.TruncateID(task.ID))
^
cli/command/service/progress/progress_test.go:877:18: fmt.Sprintf can be replaced with string concatenation (perfsprint)
ID: fmt.Sprintf("task%s", nodeID),
^
cli/command/stack/swarm/remove.go:61:24: fmt.Sprintf can be replaced with string concatenation (perfsprint)
errs = append(errs, fmt.Sprintf("Failed to remove some resources from stack: %s", namespace))
^
cli/command/swarm/ipnet_slice_test.go:32:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
arg := fmt.Sprintf("--cidrs=%s", strings.Join(vals, ","))
^
cli/command/swarm/ipnet_slice_test.go:137:30: fmt.Sprintf can be replaced with string concatenation (perfsprint)
if err := f.Parse([]string{fmt.Sprintf("--cidrs=%s", strings.Join(test.FlagArg, ","))}); err != nil {
^
cli/compose/schema/schema.go:105:11: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("must be a %s", humanReadableType(expectedType))
^
cli/manifest/store/store.go:165:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("No such manifest: %s", n.object)
^
e2e/image/push_test.go:340:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_ROOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:341:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_TARGETS_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:342:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_SNAPSHOT_PASSPHRASE=%s", pwd),
^
e2e/image/push_test.go:343:4: fmt.Sprintf can be replaced with string concatenation (perfsprint)
fmt.Sprintf("NOTARY_DELEGATION_PASSPHRASE=%s", pwd),
^
e2e/plugin/trust_test.go:23:16: fmt.Sprintf can be replaced with string concatenation (perfsprint)
pluginName := fmt.Sprintf("%s/plugin-content-trust", registryPrefix)
^
e2e/plugin/trust_test.go:53:8: fmt.Sprintf can be replaced with string concatenation (perfsprint)
Out: fmt.Sprintf("Installed plugin %s", pluginName),
^
e2e/trust/revoke_test.go:62:57: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.AlpineImage, fmt.Sprintf("%s:v1", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:64:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v1", revokeRepo)),
^
e2e/trust/revoke_test.go:68:58: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.RunCommand("docker", "tag", fixtures.BusyboxImage, fmt.Sprintf("%s:v2", revokeRepo)).Assert(t, icmd.Success)
^
e2e/trust/revoke_test.go:70:49: fmt.Sprintf can be replaced with string concatenation (perfsprint)
icmd.Command("docker", "-D", "trust", "sign", fmt.Sprintf("%s:v2", revokeRepo)),
^
e2e/trust/sign_test.go:36:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
e2e/trust/sign_test.go:53:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.BusyboxSha)))
^
e2e/trust/sign_test.go:65:47: fmt.Sprintf can be replaced with string concatenation (perfsprint)
assert.Check(t, is.Contains(result.Stdout(), fmt.Sprintf("v1: digest: sha256:%s", fixtures.AlpineSha)))
^
opts/file.go:21:9: fmt.Sprintf can be replaced with string concatenation (perfsprint)
return fmt.Sprintf("poorly formatted environment: %s", e.msg)
^
opts/hosts_test.go:26:31: fmt.Sprintf can be replaced with string concatenation (perfsprint)
"tcp://host:": fmt.Sprintf("tcp://host:%s", defaultHTTPPort),
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-06-10 15:07:37 -04:00
|
|
|
inputServerAddress: "https://" + testAuthConfigs[1].ServerAddress,
|
2017-05-30 17:36:15 -04:00
|
|
|
expectedAuthConfig: testAuthConfigs[1],
|
|
|
|
},
|
|
|
|
}
|
2023-07-10 11:24:07 -04:00
|
|
|
cfg := configfile.New("filename")
|
2017-05-30 17:36:15 -04:00
|
|
|
for _, authconfig := range testAuthConfigs {
|
2023-10-23 08:51:01 -04:00
|
|
|
assert.Check(t, cfg.GetCredentialsStore(authconfig.ServerAddress).Store(configtypes.AuthConfig(authconfig)))
|
2017-05-30 17:36:15 -04:00
|
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
|
|
serverAddress := tc.inputServerAddress
|
2023-10-23 08:51:01 -04:00
|
|
|
authconfig, err := command.GetDefaultAuthConfig(cfg, tc.checkCredStore, serverAddress, serverAddress == "https://index.docker.io/v1/")
|
2024-06-10 14:53:13 -04:00
|
|
|
assert.NilError(t, err)
|
|
|
|
assert.Check(t, is.DeepEqual(tc.expectedAuthConfig, authconfig))
|
2017-05-30 17:36:15 -04:00
|
|
|
}
|
|
|
|
}
|
2021-07-21 20:59:42 -04:00
|
|
|
|
|
|
|
func TestGetDefaultAuthConfig_HelperError(t *testing.T) {
|
2023-07-10 11:24:07 -04:00
|
|
|
cfg := configfile.New("filename")
|
|
|
|
cfg.CredentialsStore = "fake-does-not-exist"
|
|
|
|
|
|
|
|
const serverAddress = "test-server-address"
|
2023-02-07 20:31:59 -05:00
|
|
|
expectedAuthConfig := registry.AuthConfig{
|
2021-07-21 20:59:42 -04:00
|
|
|
ServerAddress: serverAddress,
|
|
|
|
}
|
2023-10-23 08:51:01 -04:00
|
|
|
const isDefaultRegistry = false // registry is not "https://index.docker.io/v1/"
|
|
|
|
authconfig, err := command.GetDefaultAuthConfig(cfg, true, serverAddress, isDefaultRegistry)
|
2021-07-21 20:59:42 -04:00
|
|
|
assert.Check(t, is.DeepEqual(expectedAuthConfig, authconfig))
|
|
|
|
assert.Check(t, is.ErrorContains(err, "docker-credential-fake-does-not-exist"))
|
|
|
|
}
|