2016-09-08 13:11:39 -04:00
|
|
|
package container
|
|
|
|
|
|
|
|
import (
|
2016-12-24 19:05:37 -05:00
|
|
|
"errors"
|
2016-09-08 13:11:39 -04:00
|
|
|
"fmt"
|
|
|
|
"io"
|
|
|
|
"net/http/httputil"
|
|
|
|
"os"
|
|
|
|
"runtime"
|
|
|
|
"strings"
|
|
|
|
"syscall"
|
|
|
|
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
|
|
"github.com/docker/docker/cli"
|
|
|
|
"github.com/docker/docker/cli/command"
|
|
|
|
opttypes "github.com/docker/docker/opts"
|
|
|
|
"github.com/docker/docker/pkg/promise"
|
|
|
|
"github.com/docker/docker/pkg/signal"
|
|
|
|
"github.com/docker/libnetwork/resolvconf/dns"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/spf13/pflag"
|
2016-12-24 19:05:37 -05:00
|
|
|
"golang.org/x/net/context"
|
2016-09-08 13:11:39 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
type runOptions struct {
|
|
|
|
detach bool
|
|
|
|
sigProxy bool
|
|
|
|
name string
|
|
|
|
detachKeys string
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewRunCommand create a new `docker run` command
|
|
|
|
func NewRunCommand(dockerCli *command.DockerCli) *cobra.Command {
|
|
|
|
var opts runOptions
|
2016-12-23 14:09:12 -05:00
|
|
|
var copts *containerOptions
|
2016-09-08 13:11:39 -04:00
|
|
|
|
|
|
|
cmd := &cobra.Command{
|
|
|
|
Use: "run [OPTIONS] IMAGE [COMMAND] [ARG...]",
|
|
|
|
Short: "Run a command in a new container",
|
|
|
|
Args: cli.RequiresMinArgs(1),
|
|
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
|
|
copts.Image = args[0]
|
|
|
|
if len(args) > 1 {
|
|
|
|
copts.Args = args[1:]
|
|
|
|
}
|
|
|
|
return runRun(dockerCli, cmd.Flags(), &opts, copts)
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
flags := cmd.Flags()
|
|
|
|
flags.SetInterspersed(false)
|
|
|
|
|
|
|
|
// These are flags not stored in Config/HostConfig
|
|
|
|
flags.BoolVarP(&opts.detach, "detach", "d", false, "Run container in background and print container ID")
|
|
|
|
flags.BoolVar(&opts.sigProxy, "sig-proxy", true, "Proxy received signals to the process")
|
|
|
|
flags.StringVar(&opts.name, "name", "", "Assign a name to the container")
|
|
|
|
flags.StringVar(&opts.detachKeys, "detach-keys", "", "Override the key sequence for detaching a container")
|
|
|
|
|
|
|
|
// Add an explicit help that doesn't have a `-h` to prevent the conflict
|
|
|
|
// with hostname
|
|
|
|
flags.Bool("help", false, "Print usage")
|
|
|
|
|
2017-01-17 09:46:07 -05:00
|
|
|
command.AddTrustVerificationFlags(flags)
|
2016-12-23 14:09:12 -05:00
|
|
|
copts = addFlags(flags)
|
2016-09-08 13:11:39 -04:00
|
|
|
return cmd
|
|
|
|
}
|
|
|
|
|
2016-12-23 14:09:12 -05:00
|
|
|
func runRun(dockerCli *command.DockerCli, flags *pflag.FlagSet, opts *runOptions, copts *containerOptions) error {
|
2016-09-08 13:11:39 -04:00
|
|
|
stdout, stderr, stdin := dockerCli.Out(), dockerCli.Err(), dockerCli.In()
|
|
|
|
client := dockerCli.Client()
|
|
|
|
// TODO: pass this as an argument
|
|
|
|
cmdPath := "run"
|
|
|
|
|
|
|
|
var (
|
Don't use AutoRemove on older daemons
Docker 1.13 moves the `--rm` flag to the daemon,
through an AutoRemove option in HostConfig.
When using API 1.24 and under, AutoRemove should not be
used, even if the daemon is version 1.13 or above and
"supports" this feature.
This patch fixes a situation where an 1.13 client,
talking to an 1.13 daemon, but using the 1.24 API
version, still set the AutoRemove property.
As a result, both the client _and_ the daemon
were attempting to remove the container, resulting
in an error:
ERRO[0000] error removing container: Error response from daemon:
removal of container ce0976ad22495c7cbe9487752ea32721a282164862db036b2f3377bd07461c3a
is already in progress
In addition, the validation of conflicting options
is moved from `docker run` to `opts.parse()`, so
that conflicting options are also detected when
running `docker create` and `docker start` separately.
To resolve the issue, the `AutoRemove` option is now
always set to `false` both by the client and the
daemon, if API version 1.24 or under is used.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-01-12 19:05:39 -05:00
|
|
|
flAttach *opttypes.ListOpts
|
|
|
|
ErrConflictAttachDetach = errors.New("Conflicting options: -a and -d")
|
2016-09-08 13:11:39 -04:00
|
|
|
)
|
|
|
|
|
2016-12-23 14:09:12 -05:00
|
|
|
config, hostConfig, networkingConfig, err := parse(flags, copts)
|
2016-09-08 13:11:39 -04:00
|
|
|
|
2016-12-23 14:09:12 -05:00
|
|
|
// just in case the parse does not exit
|
2016-09-08 13:11:39 -04:00
|
|
|
if err != nil {
|
|
|
|
reportError(stderr, cmdPath, err.Error(), true)
|
|
|
|
return cli.StatusError{StatusCode: 125}
|
|
|
|
}
|
|
|
|
|
|
|
|
if hostConfig.OomKillDisable != nil && *hostConfig.OomKillDisable && hostConfig.Memory == 0 {
|
2016-12-24 19:05:37 -05:00
|
|
|
fmt.Fprintln(stderr, "WARNING: Disabling the OOM killer on containers without setting a '-m/--memory' limit may be dangerous.")
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
if len(hostConfig.DNS) > 0 {
|
|
|
|
// check the DNS settings passed via --dns against
|
|
|
|
// localhost regexp to warn if they are trying to
|
|
|
|
// set a DNS to a localhost address
|
|
|
|
for _, dnsIP := range hostConfig.DNS {
|
|
|
|
if dns.IsLocalhost(dnsIP) {
|
|
|
|
fmt.Fprintf(stderr, "WARNING: Localhost DNS setting (--dns=%s) may fail in containers.\n", dnsIP)
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
config.ArgsEscaped = false
|
|
|
|
|
|
|
|
if !opts.detach {
|
|
|
|
if err := dockerCli.In().CheckTty(config.AttachStdin, config.Tty); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if fl := flags.Lookup("attach"); fl != nil {
|
|
|
|
flAttach = fl.Value.(*opttypes.ListOpts)
|
|
|
|
if flAttach.Len() != 0 {
|
|
|
|
return ErrConflictAttachDetach
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
config.AttachStdin = false
|
|
|
|
config.AttachStdout = false
|
|
|
|
config.AttachStderr = false
|
|
|
|
config.StdinOnce = false
|
|
|
|
}
|
|
|
|
|
|
|
|
// Disable sigProxy when in TTY mode
|
|
|
|
if config.Tty {
|
|
|
|
opts.sigProxy = false
|
|
|
|
}
|
|
|
|
|
|
|
|
// Telling the Windows daemon the initial size of the tty during start makes
|
|
|
|
// a far better user experience rather than relying on subsequent resizes
|
|
|
|
// to cause things to catch up.
|
|
|
|
if runtime.GOOS == "windows" {
|
2016-09-20 15:01:04 -04:00
|
|
|
hostConfig.ConsoleSize[0], hostConfig.ConsoleSize[1] = dockerCli.Out().GetTtySize()
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
ctx, cancelFun := context.WithCancel(context.Background())
|
|
|
|
|
|
|
|
createResponse, err := createContainer(ctx, dockerCli, config, hostConfig, networkingConfig, hostConfig.ContainerIDFile, opts.name)
|
|
|
|
if err != nil {
|
|
|
|
reportError(stderr, cmdPath, err.Error(), true)
|
|
|
|
return runStartContainerErr(err)
|
|
|
|
}
|
|
|
|
if opts.sigProxy {
|
|
|
|
sigc := ForwardAllSignals(ctx, dockerCli, createResponse.ID)
|
|
|
|
defer signal.StopCatch(sigc)
|
|
|
|
}
|
|
|
|
var (
|
|
|
|
waitDisplayID chan struct{}
|
|
|
|
errCh chan error
|
|
|
|
)
|
|
|
|
if !config.AttachStdout && !config.AttachStderr {
|
|
|
|
// Make this asynchronous to allow the client to write to stdin before having to read the ID
|
|
|
|
waitDisplayID = make(chan struct{})
|
|
|
|
go func() {
|
|
|
|
defer close(waitDisplayID)
|
2016-12-24 19:05:37 -05:00
|
|
|
fmt.Fprintln(stdout, createResponse.ID)
|
2016-09-08 13:11:39 -04:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
attach := config.AttachStdin || config.AttachStdout || config.AttachStderr
|
|
|
|
if attach {
|
|
|
|
var (
|
|
|
|
out, cerr io.Writer
|
|
|
|
in io.ReadCloser
|
|
|
|
)
|
|
|
|
if config.AttachStdin {
|
|
|
|
in = stdin
|
|
|
|
}
|
|
|
|
if config.AttachStdout {
|
|
|
|
out = stdout
|
|
|
|
}
|
|
|
|
if config.AttachStderr {
|
|
|
|
if config.Tty {
|
|
|
|
cerr = stdout
|
|
|
|
} else {
|
|
|
|
cerr = stderr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if opts.detachKeys != "" {
|
|
|
|
dockerCli.ConfigFile().DetachKeys = opts.detachKeys
|
|
|
|
}
|
|
|
|
|
|
|
|
options := types.ContainerAttachOptions{
|
|
|
|
Stream: true,
|
|
|
|
Stdin: config.AttachStdin,
|
|
|
|
Stdout: config.AttachStdout,
|
|
|
|
Stderr: config.AttachStderr,
|
|
|
|
DetachKeys: dockerCli.ConfigFile().DetachKeys,
|
|
|
|
}
|
|
|
|
|
|
|
|
resp, errAttach := client.ContainerAttach(ctx, createResponse.ID, options)
|
|
|
|
if errAttach != nil && errAttach != httputil.ErrPersistEOF {
|
|
|
|
// ContainerAttach returns an ErrPersistEOF (connection closed)
|
|
|
|
// means server met an error and put it in Hijacked connection
|
|
|
|
// keep the error and read detailed error message from hijacked connection later
|
|
|
|
return errAttach
|
|
|
|
}
|
|
|
|
defer resp.Close()
|
|
|
|
|
|
|
|
errCh = promise.Go(func() error {
|
2016-12-24 19:05:37 -05:00
|
|
|
if errHijack := holdHijackedConnection(ctx, dockerCli, config.Tty, in, out, cerr, resp); errHijack != nil {
|
|
|
|
return errHijack
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
2016-12-24 19:05:37 -05:00
|
|
|
return errAttach
|
2016-09-08 13:11:39 -04:00
|
|
|
})
|
|
|
|
}
|
|
|
|
|
Don't use AutoRemove on older daemons
Docker 1.13 moves the `--rm` flag to the daemon,
through an AutoRemove option in HostConfig.
When using API 1.24 and under, AutoRemove should not be
used, even if the daemon is version 1.13 or above and
"supports" this feature.
This patch fixes a situation where an 1.13 client,
talking to an 1.13 daemon, but using the 1.24 API
version, still set the AutoRemove property.
As a result, both the client _and_ the daemon
were attempting to remove the container, resulting
in an error:
ERRO[0000] error removing container: Error response from daemon:
removal of container ce0976ad22495c7cbe9487752ea32721a282164862db036b2f3377bd07461c3a
is already in progress
In addition, the validation of conflicting options
is moved from `docker run` to `opts.parse()`, so
that conflicting options are also detected when
running `docker create` and `docker start` separately.
To resolve the issue, the `AutoRemove` option is now
always set to `false` both by the client and the
daemon, if API version 1.24 or under is used.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-01-12 19:05:39 -05:00
|
|
|
statusChan := waitExitOrRemoved(ctx, dockerCli, createResponse.ID, copts.autoRemove)
|
2016-09-08 13:11:39 -04:00
|
|
|
|
|
|
|
//start the container
|
|
|
|
if err := client.ContainerStart(ctx, createResponse.ID, types.ContainerStartOptions{}); err != nil {
|
|
|
|
// If we have holdHijackedConnection, we should notify
|
|
|
|
// holdHijackedConnection we are going to exit and wait
|
|
|
|
// to avoid the terminal are not restored.
|
|
|
|
if attach {
|
|
|
|
cancelFun()
|
|
|
|
<-errCh
|
|
|
|
}
|
|
|
|
|
|
|
|
reportError(stderr, cmdPath, err.Error(), false)
|
Don't use AutoRemove on older daemons
Docker 1.13 moves the `--rm` flag to the daemon,
through an AutoRemove option in HostConfig.
When using API 1.24 and under, AutoRemove should not be
used, even if the daemon is version 1.13 or above and
"supports" this feature.
This patch fixes a situation where an 1.13 client,
talking to an 1.13 daemon, but using the 1.24 API
version, still set the AutoRemove property.
As a result, both the client _and_ the daemon
were attempting to remove the container, resulting
in an error:
ERRO[0000] error removing container: Error response from daemon:
removal of container ce0976ad22495c7cbe9487752ea32721a282164862db036b2f3377bd07461c3a
is already in progress
In addition, the validation of conflicting options
is moved from `docker run` to `opts.parse()`, so
that conflicting options are also detected when
running `docker create` and `docker start` separately.
To resolve the issue, the `AutoRemove` option is now
always set to `false` both by the client and the
daemon, if API version 1.24 or under is used.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-01-12 19:05:39 -05:00
|
|
|
if copts.autoRemove {
|
2016-09-08 13:11:39 -04:00
|
|
|
// wait container to be removed
|
|
|
|
<-statusChan
|
|
|
|
}
|
|
|
|
return runStartContainerErr(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if (config.AttachStdin || config.AttachStdout || config.AttachStderr) && config.Tty && dockerCli.Out().IsTerminal() {
|
|
|
|
if err := MonitorTtySize(ctx, dockerCli, createResponse.ID, false); err != nil {
|
2016-12-24 19:05:37 -05:00
|
|
|
fmt.Fprintln(stderr, "Error monitoring TTY size:", err)
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if errCh != nil {
|
|
|
|
if err := <-errCh; err != nil {
|
|
|
|
logrus.Debugf("Error hijack: %s", err)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Detached mode: wait for the id to be displayed and return.
|
|
|
|
if !config.AttachStdout && !config.AttachStderr {
|
|
|
|
// Detached mode
|
|
|
|
<-waitDisplayID
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
status := <-statusChan
|
|
|
|
if status != 0 {
|
|
|
|
return cli.StatusError{StatusCode: status}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// reportError is a utility method that prints a user-friendly message
|
|
|
|
// containing the error that occurred during parsing and a suggestion to get help
|
|
|
|
func reportError(stderr io.Writer, name string, str string, withHelp bool) {
|
2016-12-28 12:09:25 -05:00
|
|
|
str = strings.TrimSuffix(str, ".") + "."
|
2016-09-08 13:11:39 -04:00
|
|
|
if withHelp {
|
2016-12-28 12:09:25 -05:00
|
|
|
str += "\nSee '" + os.Args[0] + " " + name + " --help'."
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
2016-12-28 12:09:25 -05:00
|
|
|
fmt.Fprintf(stderr, "%s: %s\n", os.Args[0], str)
|
2016-09-08 13:11:39 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
// if container start fails with 'not found'/'no such' error, return 127
|
|
|
|
// if container start fails with 'permission denied' error, return 126
|
|
|
|
// return 125 for generic docker daemon failures
|
|
|
|
func runStartContainerErr(err error) error {
|
|
|
|
trimmedErr := strings.TrimPrefix(err.Error(), "Error response from daemon: ")
|
|
|
|
statusError := cli.StatusError{StatusCode: 125}
|
|
|
|
if strings.Contains(trimmedErr, "executable file not found") ||
|
|
|
|
strings.Contains(trimmedErr, "no such file or directory") ||
|
|
|
|
strings.Contains(trimmedErr, "system cannot find the file specified") {
|
|
|
|
statusError = cli.StatusError{StatusCode: 127}
|
|
|
|
} else if strings.Contains(trimmedErr, syscall.EACCES.Error()) {
|
|
|
|
statusError = cli.StatusError{StatusCode: 126}
|
|
|
|
}
|
|
|
|
|
|
|
|
return statusError
|
|
|
|
}
|