DockerCLI/dockerfiles/Dockerfile.lint

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.21.11
ARG ALPINE_VERSION=3.18
ARG GOLANGCI_LINT_VERSION=v1.55.2

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint
ENV GOTOOLCHAIN=local
ENV GO111MODULE=off
ENV CGO_ENABLED=0
ENV GOGC=75
WORKDIR /go/src/github.com/docker/cli
COPY --link --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
        golangci-lint run
Dockerfile: use syntax=docker/dockerfile:1 Now that HEREDOC is included in the stable Dockerfile syntax, we can use the latest stable syntax for all Dockerfiles. The recommendation for the stable syntax is to use `:1` (which is equivalent to "latest" stable syntax. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-03-17 05:37:08 -04:00			`# syntax=docker/dockerfile:1`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
update to go1.21.11 go1.21.11 (released 2024-06-04) includes security fixes to the archive/zip and net/netip packages, as well as bug fixes to the compiler, the go command, the runtime, and the os package. See the Go 1.21.11 milestone on our issue tracker for details; - https://github.com/golang/go/issues?q=milestone%3AGo1.21.11+label%3ACherryPickApproved - full diff: https://github.com/golang/go/compare/go1.21.10...go1.21.11 From the security announcement; We have just released Go versions 1.22.4 and 1.21.11, minor point releases. These minor releases include 2 security fixes following the security policy: - archive/zip: mishandling of corrupt central directory record The archive/zip package's handling of certain types of invalid zip files differed from the behavior of most zip implementations. This misalignment could be exploited to create an zip file with contents that vary depending on the implementation reading the file. The archive/zip package now rejects files containing these errors. Thanks to Yufan You for reporting this issue. This is CVE-2024-24789 and Go issue https://go.dev/issue/66869. - net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses The various Is methods (IsPrivate, IsLoopback, etc) did not work as expected for IPv4-mapped IPv6 addresses, returning false for addresses which would return true in their traditional IPv4 forms. Thanks to Enze Wang of Alioth and Jianjun Chen of Zhongguancun Lab for reporting this issue. This is CVE-2024-24790 and Go issue https://go.dev/issue/67680. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 630e1d3e95b18da36dbb53f516c54ee00f2e421f) Signed-off-by: Austin Vazquez <macedonv@amazon.com> 2024-06-04 17:39:27 -04:00			`ARG GO_VERSION=1.21.11`
Dockerfile: update ALPINE_VERSION to 3.18 This also moves `musl-dev` to the alpine-base stage, due to changes in Alpine 3.18 causing gotestsum build to fail because stdlib.h was missing; #17 5.065 # runtime/cgo #17 5.065 In file included from _cgo_export.c:3: #17 5.065 /usr/include/fortify/stdlib.h:23:15: fatal error: stdlib.h: No such file or directory #17 5.065 23 \| #include_next <stdlib.h> #17 5.065 \| ^~~~~~~~~~ alpine 3.17: / # find / \| grep stdlib.h /usr/include/c++/12.2.1/tr1/stdlib.h /usr/include/c++/12.2.1/stdlib.h alpine 3.18 / # find / \| grep stdlib.h /usr/lib/llvm16/lib/clang/16/include/__clang_hip_stdlib.h /usr/include/fortify/stdlib.h /usr/include/c++/12.2.1/tr1/stdlib.h /usr/include/c++/12.2.1/stdlib.h Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-06-14 07:30:40 -04:00			`ARG ALPINE_VERSION=3.18`
dockerfiles: update golangci-lint to v1.55.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-11-20 04:04:36 -05:00			`ARG GOLANGCI_LINT_VERSION=v1.55.2`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
Dockerfile: add ALPINE_VERSION build-arg This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see https://github.com/moby/moby/issues/44570 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-12-04 08:01:30 -05:00			`FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint`
Dockerfile: use GOTOOLCHAIN=local This may find its way into the official images, but until it does, let's make sure we don't get unexpected updates of go. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-09-26 06:43:38 -04:00			`ENV GOTOOLCHAIN=local`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`ENV GO111MODULE=off`
			`ENV CGO_ENABLED=0`
			`ENV GOGC=75`
Remove now obsolete gometalinter and use golangci-lint instead Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2019-04-02 11:27:12 -04:00			`WORKDIR /go/src/github.com/docker/cli`
Dockerfile: use COPY --link where possible Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-08-24 19:56:35 -04:00			`COPY --link --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`RUN --mount=type=bind,target=. \`
			`--mount=type=cache,target=/root/.cache \`
			`golangci-lint run`