2016-09-08 13:11:39 -04:00
package system
import (
"fmt"
2016-11-03 14:23:58 -04:00
"sort"
2016-09-08 13:11:39 -04:00
"strings"
"time"
2017-04-17 18:07:56 -04:00
"github.com/docker/cli/cli"
"github.com/docker/cli/cli/command"
"github.com/docker/cli/cli/debug"
2016-09-08 13:11:39 -04:00
"github.com/docker/docker/api/types"
"github.com/docker/docker/api/types/swarm"
"github.com/docker/docker/pkg/ioutils"
2016-12-12 03:34:03 -05:00
"github.com/docker/docker/pkg/templates"
2016-09-08 13:11:39 -04:00
"github.com/docker/go-units"
"github.com/spf13/cobra"
add d_type warning to docker info, and optimize output
The overlay(2) drivers were moved up in the list of storage drivers,
and are known to have problems if the backing filesystem does not
support d_type.
Commit 2e20e63da2a8a0ffbbb3f2146f87559e17f43046 added a warning,
which is logged in the daemon logs, however, many users do not
check those logs, and may overlook this warning.
This patch adds the same warning to the output of `docker info`
so that the warning is more easily found.
In addition, the output of warnings printed by `docker info` is
optimized, by;
- moving all warnings to the _end_ of the output, instead of
mixing them with the regular output
- wrapping the storage-driver warnings, so that they are more
easily readable
Example output with this patch applied
============================================
devicemapper using loopback devices:
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
overlay2 on xfs without d_type support;
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: overlay2: the backing xfs filesystem is formatted without d_type support, which leads to incorrect behavior.
Reformat the filesystem with ftype=1 to enable d_type support.
Running without d_type support will not be supported in future releases.
WARNING: bridge-nf-call-iptables is disabled
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-02-23 07:36:57 -05:00
"golang.org/x/net/context"
2016-09-08 13:11:39 -04:00
)
type infoOptions struct {
format string
}
// NewInfoCommand creates a new cobra.Command for `docker info`
func NewInfoCommand ( dockerCli * command . DockerCli ) * cobra . Command {
var opts infoOptions
cmd := & cobra . Command {
Use : "info [OPTIONS]" ,
Short : "Display system-wide information" ,
Args : cli . NoArgs ,
RunE : func ( cmd * cobra . Command , args [ ] string ) error {
return runInfo ( dockerCli , & opts )
} ,
}
flags := cmd . Flags ( )
2016-10-18 06:50:11 -04:00
flags . StringVarP ( & opts . format , "format" , "f" , "" , "Format the output using the given Go template" )
2016-09-08 13:11:39 -04:00
return cmd
}
func runInfo ( dockerCli * command . DockerCli , opts * infoOptions ) error {
ctx := context . Background ( )
info , err := dockerCli . Client ( ) . Info ( ctx )
if err != nil {
return err
}
if opts . format == "" {
return prettyPrintInfo ( dockerCli , info )
}
return formatInfo ( dockerCli , info , opts . format )
}
2017-05-02 16:14:43 -04:00
// nolint: gocyclo
2016-09-08 13:11:39 -04:00
func prettyPrintInfo ( dockerCli * command . DockerCli , info types . Info ) error {
fmt . Fprintf ( dockerCli . Out ( ) , "Containers: %d\n" , info . Containers )
fmt . Fprintf ( dockerCli . Out ( ) , " Running: %d\n" , info . ContainersRunning )
fmt . Fprintf ( dockerCli . Out ( ) , " Paused: %d\n" , info . ContainersPaused )
fmt . Fprintf ( dockerCli . Out ( ) , " Stopped: %d\n" , info . ContainersStopped )
fmt . Fprintf ( dockerCli . Out ( ) , "Images: %d\n" , info . Images )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Server Version: %s\n" , info . ServerVersion )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Storage Driver: %s\n" , info . Driver )
if info . DriverStatus != nil {
for _ , pair := range info . DriverStatus {
fmt . Fprintf ( dockerCli . Out ( ) , " %s: %s\n" , pair [ 0 ] , pair [ 1 ] )
}
}
if info . SystemStatus != nil {
for _ , pair := range info . SystemStatus {
fmt . Fprintf ( dockerCli . Out ( ) , "%s: %s\n" , pair [ 0 ] , pair [ 1 ] )
}
}
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Logging Driver: %s\n" , info . LoggingDriver )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Cgroup Driver: %s\n" , info . CgroupDriver )
fmt . Fprintf ( dockerCli . Out ( ) , "Plugins: \n" )
fmt . Fprintf ( dockerCli . Out ( ) , " Volume:" )
fmt . Fprintf ( dockerCli . Out ( ) , " %s" , strings . Join ( info . Plugins . Volume , " " ) )
fmt . Fprintf ( dockerCli . Out ( ) , "\n" )
fmt . Fprintf ( dockerCli . Out ( ) , " Network:" )
fmt . Fprintf ( dockerCli . Out ( ) , " %s" , strings . Join ( info . Plugins . Network , " " ) )
fmt . Fprintf ( dockerCli . Out ( ) , "\n" )
if len ( info . Plugins . Authorization ) != 0 {
fmt . Fprintf ( dockerCli . Out ( ) , " Authorization:" )
fmt . Fprintf ( dockerCli . Out ( ) , " %s" , strings . Join ( info . Plugins . Authorization , " " ) )
fmt . Fprintf ( dockerCli . Out ( ) , "\n" )
}
2017-04-11 17:21:21 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , " Log:" )
fmt . Fprintf ( dockerCli . Out ( ) , " %s" , strings . Join ( info . Plugins . Log , " " ) )
fmt . Fprintf ( dockerCli . Out ( ) , "\n" )
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , "Swarm: %v\n" , info . Swarm . LocalNodeState )
2016-10-21 21:07:55 -04:00
if info . Swarm . LocalNodeState != swarm . LocalNodeStateInactive && info . Swarm . LocalNodeState != swarm . LocalNodeStateLocked {
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , " NodeID: %s\n" , info . Swarm . NodeID )
if info . Swarm . Error != "" {
fmt . Fprintf ( dockerCli . Out ( ) , " Error: %v\n" , info . Swarm . Error )
}
fmt . Fprintf ( dockerCli . Out ( ) , " Is Manager: %v\n" , info . Swarm . ControlAvailable )
2017-03-28 17:20:25 -04:00
if info . Swarm . Cluster != nil && info . Swarm . ControlAvailable && info . Swarm . Error == "" && info . Swarm . LocalNodeState != swarm . LocalNodeStateError {
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , " ClusterID: %s\n" , info . Swarm . Cluster . ID )
fmt . Fprintf ( dockerCli . Out ( ) , " Managers: %d\n" , info . Swarm . Managers )
fmt . Fprintf ( dockerCli . Out ( ) , " Nodes: %d\n" , info . Swarm . Nodes )
fmt . Fprintf ( dockerCli . Out ( ) , " Orchestration:\n" )
2016-08-26 00:08:53 -04:00
taskHistoryRetentionLimit := int64 ( 0 )
if info . Swarm . Cluster . Spec . Orchestration . TaskHistoryRetentionLimit != nil {
taskHistoryRetentionLimit = * info . Swarm . Cluster . Spec . Orchestration . TaskHistoryRetentionLimit
}
fmt . Fprintf ( dockerCli . Out ( ) , " Task History Retention Limit: %d\n" , taskHistoryRetentionLimit )
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , " Raft:\n" )
fmt . Fprintf ( dockerCli . Out ( ) , " Snapshot Interval: %d\n" , info . Swarm . Cluster . Spec . Raft . SnapshotInterval )
2016-11-02 15:29:51 -04:00
if info . Swarm . Cluster . Spec . Raft . KeepOldSnapshots != nil {
fmt . Fprintf ( dockerCli . Out ( ) , " Number of Old Snapshots to Retain: %d\n" , * info . Swarm . Cluster . Spec . Raft . KeepOldSnapshots )
}
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , " Heartbeat Tick: %d\n" , info . Swarm . Cluster . Spec . Raft . HeartbeatTick )
fmt . Fprintf ( dockerCli . Out ( ) , " Election Tick: %d\n" , info . Swarm . Cluster . Spec . Raft . ElectionTick )
fmt . Fprintf ( dockerCli . Out ( ) , " Dispatcher:\n" )
fmt . Fprintf ( dockerCli . Out ( ) , " Heartbeat Period: %s\n" , units . HumanDuration ( time . Duration ( info . Swarm . Cluster . Spec . Dispatcher . HeartbeatPeriod ) ) )
fmt . Fprintf ( dockerCli . Out ( ) , " CA Configuration:\n" )
fmt . Fprintf ( dockerCli . Out ( ) , " Expiry Duration: %s\n" , units . HumanDuration ( info . Swarm . Cluster . Spec . CAConfig . NodeCertExpiry ) )
if len ( info . Swarm . Cluster . Spec . CAConfig . ExternalCAs ) > 0 {
fmt . Fprintf ( dockerCli . Out ( ) , " External CAs:\n" )
for _ , entry := range info . Swarm . Cluster . Spec . CAConfig . ExternalCAs {
fmt . Fprintf ( dockerCli . Out ( ) , " %s: %s\n" , entry . Protocol , entry . URL )
}
}
}
fmt . Fprintf ( dockerCli . Out ( ) , " Node Address: %s\n" , info . Swarm . NodeAddr )
2016-11-03 14:23:58 -04:00
managers := [ ] string { }
for _ , entry := range info . Swarm . RemoteManagers {
managers = append ( managers , entry . Addr )
}
if len ( managers ) > 0 {
sort . Strings ( managers )
fmt . Fprintf ( dockerCli . Out ( ) , " Manager Addresses:\n" )
for _ , entry := range managers {
fmt . Fprintf ( dockerCli . Out ( ) , " %s\n" , entry )
}
}
2016-09-08 13:11:39 -04:00
}
if len ( info . Runtimes ) > 0 {
fmt . Fprintf ( dockerCli . Out ( ) , "Runtimes:" )
for name := range info . Runtimes {
fmt . Fprintf ( dockerCli . Out ( ) , " %s" , name )
}
fmt . Fprint ( dockerCli . Out ( ) , "\n" )
fmt . Fprintf ( dockerCli . Out ( ) , "Default Runtime: %s\n" , info . DefaultRuntime )
}
2016-09-07 14:14:49 -04:00
if info . OSType == "linux" {
2016-10-24 18:18:58 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , "Init Binary: %v\n" , info . InitBinary )
for _ , ci := range [ ] struct {
Name string
Commit types . Commit
} {
{ "containerd" , info . ContainerdCommit } ,
{ "runc" , info . RuncCommit } ,
{ "init" , info . InitCommit } ,
} {
fmt . Fprintf ( dockerCli . Out ( ) , "%s version: %s" , ci . Name , ci . Commit . ID )
if ci . Commit . ID != ci . Commit . Expected {
fmt . Fprintf ( dockerCli . Out ( ) , " (expected: %s)" , ci . Commit . Expected )
}
fmt . Fprintf ( dockerCli . Out ( ) , "\n" )
}
2016-09-02 09:20:54 -04:00
if len ( info . SecurityOptions ) != 0 {
2016-11-16 16:30:29 -05:00
kvs , err := types . DecodeSecurityOptions ( info . SecurityOptions )
if err != nil {
return err
}
2016-09-02 09:20:54 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , "Security Options:\n" )
2016-11-16 16:30:29 -05:00
for _ , so := range kvs {
fmt . Fprintf ( dockerCli . Out ( ) , " %s\n" , so . Name )
for _ , o := range so . Options {
switch o . Key {
case "profile" :
if o . Value != "default" {
fmt . Fprintf ( dockerCli . Err ( ) , " WARNING: You're not using the default seccomp profile\n" )
}
fmt . Fprintf ( dockerCli . Out ( ) , " Profile: %s\n" , o . Value )
2016-09-02 09:20:54 -04:00
}
}
}
}
2016-09-07 14:14:49 -04:00
}
2016-09-08 13:11:39 -04:00
2016-09-07 18:10:00 -04:00
// Isolation only has meaning on a Windows daemon.
if info . OSType == "windows" {
fmt . Fprintf ( dockerCli . Out ( ) , "Default Isolation: %v\n" , info . Isolation )
}
2016-09-08 13:11:39 -04:00
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Kernel Version: %s\n" , info . KernelVersion )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Operating System: %s\n" , info . OperatingSystem )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "OSType: %s\n" , info . OSType )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Architecture: %s\n" , info . Architecture )
fmt . Fprintf ( dockerCli . Out ( ) , "CPUs: %d\n" , info . NCPU )
fmt . Fprintf ( dockerCli . Out ( ) , "Total Memory: %s\n" , units . BytesSize ( float64 ( info . MemTotal ) ) )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Name: %s\n" , info . Name )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "ID: %s\n" , info . ID )
fmt . Fprintf ( dockerCli . Out ( ) , "Docker Root Dir: %s\n" , info . DockerRootDir )
2016-12-12 03:33:58 -05:00
fmt . Fprintf ( dockerCli . Out ( ) , "Debug Mode (client): %v\n" , debug . IsEnabled ( ) )
2016-09-08 13:11:39 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , "Debug Mode (server): %v\n" , info . Debug )
if info . Debug {
fmt . Fprintf ( dockerCli . Out ( ) , " File Descriptors: %d\n" , info . NFd )
fmt . Fprintf ( dockerCli . Out ( ) , " Goroutines: %d\n" , info . NGoroutines )
fmt . Fprintf ( dockerCli . Out ( ) , " System Time: %s\n" , info . SystemTime )
fmt . Fprintf ( dockerCli . Out ( ) , " EventsListeners: %d\n" , info . NEventsListener )
}
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Http Proxy: %s\n" , info . HTTPProxy )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "Https Proxy: %s\n" , info . HTTPSProxy )
ioutils . FprintfIfNotEmpty ( dockerCli . Out ( ) , "No Proxy: %s\n" , info . NoProxy )
if info . IndexServerAddress != "" {
u := dockerCli . ConfigFile ( ) . AuthConfigs [ info . IndexServerAddress ] . Username
if len ( u ) > 0 {
fmt . Fprintf ( dockerCli . Out ( ) , "Username: %v\n" , u )
}
fmt . Fprintf ( dockerCli . Out ( ) , "Registry: %v\n" , info . IndexServerAddress )
}
if info . Labels != nil {
fmt . Fprintln ( dockerCli . Out ( ) , "Labels:" )
for _ , attribute := range info . Labels {
fmt . Fprintf ( dockerCli . Out ( ) , " %s\n" , attribute )
}
2016-07-12 08:08:05 -04:00
// TODO: Engine labels with duplicate keys has been deprecated in 1.13 and will be error out
2017-02-28 12:28:33 -05:00
// after 3 release cycles (17.12). For now, a WARNING will be generated. The following will
2016-07-12 08:08:05 -04:00
// be removed eventually.
labelMap := map [ string ] string { }
for _ , label := range info . Labels {
stringSlice := strings . SplitN ( label , "=" , 2 )
if len ( stringSlice ) > 1 {
2016-12-19 01:45:48 -05:00
// If there is a conflict we will throw out a warning
2016-07-12 08:08:05 -04:00
if v , ok := labelMap [ stringSlice [ 0 ] ] ; ok && v != stringSlice [ 1 ] {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: labels with duplicate keys and conflicting values have been deprecated" )
break
}
labelMap [ stringSlice [ 0 ] ] = stringSlice [ 1 ]
}
}
2016-09-08 13:11:39 -04:00
}
2016-10-06 10:09:54 -04:00
fmt . Fprintf ( dockerCli . Out ( ) , "Experimental: %v\n" , info . ExperimentalBuild )
2016-09-08 13:11:39 -04:00
if info . ClusterStore != "" {
fmt . Fprintf ( dockerCli . Out ( ) , "Cluster Store: %s\n" , info . ClusterStore )
}
if info . ClusterAdvertise != "" {
fmt . Fprintf ( dockerCli . Out ( ) , "Cluster Advertise: %s\n" , info . ClusterAdvertise )
}
if info . RegistryConfig != nil && ( len ( info . RegistryConfig . InsecureRegistryCIDRs ) > 0 || len ( info . RegistryConfig . IndexConfigs ) > 0 ) {
fmt . Fprintln ( dockerCli . Out ( ) , "Insecure Registries:" )
for _ , registry := range info . RegistryConfig . IndexConfigs {
if registry . Secure == false {
fmt . Fprintf ( dockerCli . Out ( ) , " %s\n" , registry . Name )
}
}
for _ , registry := range info . RegistryConfig . InsecureRegistryCIDRs {
mask , _ := registry . Mask . Size ( )
fmt . Fprintf ( dockerCli . Out ( ) , " %s/%d\n" , registry . IP . String ( ) , mask )
}
}
if info . RegistryConfig != nil && len ( info . RegistryConfig . Mirrors ) > 0 {
fmt . Fprintln ( dockerCli . Out ( ) , "Registry Mirrors:" )
for _ , mirror := range info . RegistryConfig . Mirrors {
fmt . Fprintf ( dockerCli . Out ( ) , " %s\n" , mirror )
}
}
add d_type warning to docker info, and optimize output
The overlay(2) drivers were moved up in the list of storage drivers,
and are known to have problems if the backing filesystem does not
support d_type.
Commit 2e20e63da2a8a0ffbbb3f2146f87559e17f43046 added a warning,
which is logged in the daemon logs, however, many users do not
check those logs, and may overlook this warning.
This patch adds the same warning to the output of `docker info`
so that the warning is more easily found.
In addition, the output of warnings printed by `docker info` is
optimized, by;
- moving all warnings to the _end_ of the output, instead of
mixing them with the regular output
- wrapping the storage-driver warnings, so that they are more
easily readable
Example output with this patch applied
============================================
devicemapper using loopback devices:
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
overlay2 on xfs without d_type support;
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: overlay2: the backing xfs filesystem is formatted without d_type support, which leads to incorrect behavior.
Reformat the filesystem with ftype=1 to enable d_type support.
Running without d_type support will not be supported in future releases.
WARNING: bridge-nf-call-iptables is disabled
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-02-23 07:36:57 -05:00
fmt . Fprintf ( dockerCli . Out ( ) , "Live Restore Enabled: %v\n\n" , info . LiveRestoreEnabled )
// Only output these warnings if the server does not support these features
if info . OSType != "windows" {
printStorageDriverWarnings ( dockerCli , info )
if ! info . MemoryLimit {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No memory limit support" )
}
if ! info . SwapLimit {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No swap limit support" )
}
if ! info . KernelMemory {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No kernel memory limit support" )
}
if ! info . OomKillDisable {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No oom kill disable support" )
}
if ! info . CPUCfsQuota {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No cpu cfs quota support" )
}
if ! info . CPUCfsPeriod {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No cpu cfs period support" )
}
if ! info . CPUShares {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No cpu shares support" )
}
if ! info . CPUSet {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: No cpuset support" )
}
if ! info . IPv4Forwarding {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: IPv4 forwarding is disabled" )
}
if ! info . BridgeNfIptables {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: bridge-nf-call-iptables is disabled" )
}
if ! info . BridgeNfIP6tables {
fmt . Fprintln ( dockerCli . Err ( ) , "WARNING: bridge-nf-call-ip6tables is disabled" )
}
}
2016-09-08 13:11:39 -04:00
return nil
}
add d_type warning to docker info, and optimize output
The overlay(2) drivers were moved up in the list of storage drivers,
and are known to have problems if the backing filesystem does not
support d_type.
Commit 2e20e63da2a8a0ffbbb3f2146f87559e17f43046 added a warning,
which is logged in the daemon logs, however, many users do not
check those logs, and may overlook this warning.
This patch adds the same warning to the output of `docker info`
so that the warning is more easily found.
In addition, the output of warnings printed by `docker info` is
optimized, by;
- moving all warnings to the _end_ of the output, instead of
mixing them with the regular output
- wrapping the storage-driver warnings, so that they are more
easily readable
Example output with this patch applied
============================================
devicemapper using loopback devices:
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
overlay2 on xfs without d_type support;
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: overlay2: the backing xfs filesystem is formatted without d_type support, which leads to incorrect behavior.
Reformat the filesystem with ftype=1 to enable d_type support.
Running without d_type support will not be supported in future releases.
WARNING: bridge-nf-call-iptables is disabled
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-02-23 07:36:57 -05:00
func printStorageDriverWarnings ( dockerCli * command . DockerCli , info types . Info ) {
if info . DriverStatus == nil {
return
}
for _ , pair := range info . DriverStatus {
if pair [ 0 ] == "Data loop file" {
2017-05-03 18:14:30 -04:00
fmt . Fprintf ( dockerCli . Err ( ) , "WARNING: %s: usage of loopback devices is " +
"strongly discouraged for production use.\n " +
"Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.\n" , info . Driver )
add d_type warning to docker info, and optimize output
The overlay(2) drivers were moved up in the list of storage drivers,
and are known to have problems if the backing filesystem does not
support d_type.
Commit 2e20e63da2a8a0ffbbb3f2146f87559e17f43046 added a warning,
which is logged in the daemon logs, however, many users do not
check those logs, and may overlook this warning.
This patch adds the same warning to the output of `docker info`
so that the warning is more easily found.
In addition, the output of warnings printed by `docker info` is
optimized, by;
- moving all warnings to the _end_ of the output, instead of
mixing them with the regular output
- wrapping the storage-driver warnings, so that they are more
easily readable
Example output with this patch applied
============================================
devicemapper using loopback devices:
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use.
Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
overlay2 on xfs without d_type support;
...
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: false
WARNING: overlay2: the backing xfs filesystem is formatted without d_type support, which leads to incorrect behavior.
Reformat the filesystem with ftype=1 to enable d_type support.
Running without d_type support will not be supported in future releases.
WARNING: bridge-nf-call-iptables is disabled
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-02-23 07:36:57 -05:00
}
if pair [ 0 ] == "Supports d_type" && pair [ 1 ] == "false" {
backingFs := getBackingFs ( info )
msg := fmt . Sprintf ( "WARNING: %s: the backing %s filesystem is formatted without d_type support, which leads to incorrect behavior.\n" , info . Driver , backingFs )
if backingFs == "xfs" {
msg += " Reformat the filesystem with ftype=1 to enable d_type support.\n"
}
msg += " Running without d_type support will not be supported in future releases."
fmt . Fprintln ( dockerCli . Err ( ) , msg )
}
}
}
func getBackingFs ( info types . Info ) string {
if info . DriverStatus == nil {
return ""
}
for _ , pair := range info . DriverStatus {
if pair [ 0 ] == "Backing Filesystem" {
return pair [ 1 ]
}
}
return ""
}
2016-09-08 13:11:39 -04:00
func formatInfo ( dockerCli * command . DockerCli , info types . Info , format string ) error {
tmpl , err := templates . Parse ( format )
if err != nil {
return cli . StatusError { StatusCode : 64 ,
Status : "Template parsing error: " + err . Error ( ) }
}
err = tmpl . Execute ( dockerCli . Out ( ) , info )
dockerCli . Out ( ) . Write ( [ ] byte { '\n' } )
return err
}