2019-04-02 11:27:12 -04:00
|
|
|
# syntax=docker/dockerfile:1.1.3-experimental
|
2017-05-02 15:10:03 -04:00
|
|
|
|
2020-04-03 20:23:13 -04:00
|
|
|
ARG GO_VERSION=1.13.9
|
2019-04-02 11:27:12 -04:00
|
|
|
ARG GOLANGCI_LINTER_SHA="v1.21.0"
|
2017-05-02 15:10:03 -04:00
|
|
|
|
2019-04-02 11:27:12 -04:00
|
|
|
FROM golang:${GO_VERSION}-alpine AS build
|
|
|
|
|
ENV CGO_ENABLED=0
|
|
|
|
|
RUN apk add --no-cache git
|
|
|
|
|
ARG GOLANGCI_LINTER_SHA
|
|
|
|
|
ARG GO111MODULE=on
|
|
|
|
|
RUN --mount=type=cache,target=/root/.cache/go-build \
|
|
|
|
|
--mount=type=cache,target=/go/pkg/mod \
|
|
|
|
|
go get github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINTER_SHA}
|
2017-05-02 15:10:03 -04:00
|
|
|
|
2019-04-02 11:27:12 -04:00
|
|
|
FROM golang:${GO_VERSION}-alpine AS lint
|
2017-06-09 12:32:14 -04:00
|
|
|
ENV CGO_ENABLED=0
|
2017-08-15 14:32:44 -04:00
|
|
|
ENV DISABLE_WARN_OUTSIDE_CONTAINER=1
|
2019-04-02 11:27:12 -04:00
|
|
|
COPY --from=build /go/bin/golangci-lint /usr/local/bin
|
|
|
|
|
WORKDIR /go/src/github.com/docker/cli
|
|
|
|
|
ENV GOGC=75
|
|
|
|
|
ENTRYPOINT ["/usr/local/bin/golangci-lint"]
|
|
|
|
|
CMD ["run", "--config=.golangci.yml"]
|
Do not patch Dockerfiles in CI
When building the Dockerfiles for development, those images are mainly used to
create a reproducible build-environment. The source code is bind-mounted into
the image at runtime; there is no need to create an image with the actual
source code, and copying the source code into the image would lead to a new
image being created for each code-change (possibly leading up to many "dangling"
images for previous code-changes).
However, when building (and using) the development images in CI, bind-mounting
is not an option, because the daemon is running remotely.
To make this work, the circle-ci script patched the Dockerfiles when CI is run;
adding a `COPY` to the respective Dockerfiles.
Patching Dockerfiles is not really a "best practice" and, even though the source
code does not and up in the image, the source would still be _sent_ to the daemon
for each build (unless BuildKit is used).
This patch updates the makefiles, circle-ci script, and Dockerfiles;
- When building the Dockerfiles locally, pipe the Dockerfile through stdin.
Doing so, prevents the build-context from being sent to the daemon. This speeds
up the build, and doesn't fill up the Docker "temp" directory with content that's
not used
- Now that no content is sent, add the COPY instructions to the Dockerfiles, and
remove the code in the circle-ci script to "live patch" the Dockerfiles.
Before this patch is applied (with cache):
```
$ time make -f docker.Makefile build_shell_validate_image
docker build -t docker-cli-shell-validate -f ./dockerfiles/Dockerfile.shellcheck .
Sending build context to Docker daemon 41MB
Step 1/2 : FROM debian:stretch-slim
...
Successfully built 81e14e8ad856
Successfully tagged docker-cli-shell-validate:latest
2.75 real 0.45 user 0.56 sys
```
After this patch is applied (with cache)::
```
$ time make -f docker.Makefile build_shell_validate_image
cat ./dockerfiles/Dockerfile.shellcheck | docker build -t docker-cli-shell-validate -
Sending build context to Docker daemon 2.048kB
Step 1/2 : FROM debian:stretch-slim
...
Successfully built 81e14e8ad856
Successfully tagged docker-cli-shell-validate:latest
0.33 real 0.07 user 0.08 sys
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2018-11-28 19:06:10 -05:00
|
|
|
COPY . .
|
