DockerCLI/dockerfiles/Dockerfile.lint

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.18.5
ARG GOLANGCI_LINT_VERSION=v1.49.0

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine AS lint
ENV GO111MODULE=off
ENV CGO_ENABLED=0
ENV GOGC=75
WORKDIR /go/src/github.com/docker/cli
COPY --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
        golangci-lint run
Dockerfile: use syntax=docker/dockerfile:1 Now that HEREDOC is included in the stable Dockerfile syntax, we can use the latest stable syntax for all Dockerfiles. The recommendation for the stable syntax is to use `:1` (which is equivalent to "latest" stable syntax. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-03-17 05:37:08 -04:00			`# syntax=docker/dockerfile:1`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
Update golang to 1.18.5 Update Go runtime to 1.18.5 to address CVE-2022-32189. Full diff: https://github.com/golang/go/compare/go1.18.4...go1.18.5 -------------------------------------------------------- From the security announcement: https://groups.google.com/g/golang-announce/c/YqYYG87xB10 We have just released Go versions 1.18.5 and 1.17.13, minor point releases. These minor releases include 1 security fixes following the security policy: encoding/gob & math/big: decoding big.Float and big.Rat can panic Decoding big.Float and big.Rat types can panic if the encoded message is too short. This is CVE-2022-32189 and Go issue https://go.dev/issue/53871. View the release notes for more information: https://go.dev/doc/devel/release#go1.18.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-08-03 14:15:57 -04:00			`ARG GO_VERSION=1.18.5`
golangci-lint: update to v1.49.0 for compatibilty with go1.19 Remove the "deadcode", "structcheck", and "varcheck" linters, as they are deprecated: WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. And ignore gosec G113, which only affects gp < 1.16.14. and go < 1.17.7 opts/opts.go:398:13: G113: Potential uncontrolled memory consumption in Rat.SetString (CVE-2022-23772) (gosec) cpu, ok := new(big.Rat).SetString(value) ^ Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-09-02 15:24:26 -04:00			`ARG GOLANGCI_LINT_VERSION=v1.49.0`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`FROM golang:${GO_VERSION}-alpine AS lint`
			`ENV GO111MODULE=off`
			`ENV CGO_ENABLED=0`
			`ENV GOGC=75`
Remove now obsolete gometalinter and use golangci-lint instead Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2019-04-02 11:27:12 -04:00			`WORKDIR /go/src/github.com/docker/cli`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 02:44:16 -04:00			`COPY --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint`
			`RUN --mount=type=bind,target=. \`
			`--mount=type=cache,target=/root/.cache \`
			`golangci-lint run`