2017-02-27 12:39:35 -05:00
|
|
|
package volume
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"io/ioutil"
|
|
|
|
"testing"
|
|
|
|
|
2017-08-21 16:30:09 -04:00
|
|
|
"github.com/docker/cli/internal/test"
|
2019-04-02 11:20:21 -04:00
|
|
|
. "github.com/docker/cli/internal/test/builders" // Import builders to get the builder function as package function
|
2017-02-27 12:39:35 -05:00
|
|
|
"github.com/docker/docker/api/types"
|
2017-03-09 13:23:45 -05:00
|
|
|
"github.com/pkg/errors"
|
2020-02-22 12:12:14 -05:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
"gotest.tools/v3/golden"
|
2017-02-27 12:39:35 -05:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestVolumeInspectErrors(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
args []string
|
|
|
|
flags map[string]string
|
|
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
|
|
expectedError string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
expectedError: "requires at least 1 argument",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"foo"},
|
|
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
2017-03-09 13:23:45 -05:00
|
|
|
return types.Volume{}, errors.Errorf("error while inspecting the volume")
|
2017-02-27 12:39:35 -05:00
|
|
|
},
|
|
|
|
expectedError: "error while inspecting the volume",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"foo"},
|
|
|
|
flags: map[string]string{
|
|
|
|
"format": "{{invalid format}}",
|
|
|
|
},
|
linting: fix incorrectly formatted errors (revive)
cli/compose/interpolation/interpolation.go:102:4: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
"invalid interpolation format for %s: %#v. You may need to escape any $ with another $.",
^
cli/command/stack/loader/loader.go:30:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return nil, errors.Errorf("Compose file contains unsupported options:\n\n%s\n",
^
cli/command/formatter/formatter.go:76:30: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return tmpl, errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/formatter/formatter.go:97:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Template parsing error: %v\n", err)
^
cli/command/image/build.go:257:25: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("error checking context: '%s'.", err)
^
cli/command/volume/create.go:35:27: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("Conflicting options: either specify --name or provide positional arg, not both\n")
^
cli/command/container/create.go:160:24: error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
return errors.Errorf("failed to remove the CID file '%s': %s \n", cid.path, err)
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 4ab70bf61e87271ca56511172352296a202ced41)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-03-27 15:13:03 -04:00
|
|
|
expectedError: "template parsing error",
|
2017-02-27 12:39:35 -05:00
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"foo", "bar"},
|
|
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
|
|
if volumeID == "foo" {
|
|
|
|
return types.Volume{
|
|
|
|
Name: "foo",
|
|
|
|
}, nil
|
|
|
|
}
|
2017-03-09 13:23:45 -05:00
|
|
|
return types.Volume{}, errors.Errorf("error while inspecting the volume")
|
2017-02-27 12:39:35 -05:00
|
|
|
},
|
|
|
|
expectedError: "error while inspecting the volume",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
|
|
cmd := newInspectCommand(
|
2017-08-16 13:50:28 -04:00
|
|
|
test.NewFakeCli(&fakeClient{
|
2017-02-27 12:39:35 -05:00
|
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
2017-08-16 13:50:28 -04:00
|
|
|
}),
|
2017-02-27 12:39:35 -05:00
|
|
|
)
|
|
|
|
cmd.SetArgs(tc.args)
|
|
|
|
for key, value := range tc.flags {
|
|
|
|
cmd.Flags().Set(key, value)
|
|
|
|
}
|
2020-05-07 08:25:59 -04:00
|
|
|
cmd.SetOut(ioutil.Discard)
|
2018-03-06 14:03:47 -05:00
|
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
2017-02-27 12:39:35 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestVolumeInspectWithoutFormat(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
args []string
|
|
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
name: "single-volume",
|
|
|
|
args: []string{"foo"},
|
|
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
|
|
if volumeID != "foo" {
|
2017-03-09 13:23:45 -05:00
|
|
|
return types.Volume{}, errors.Errorf("Invalid volumeID, expected %s, got %s", "foo", volumeID)
|
2017-02-27 12:39:35 -05:00
|
|
|
}
|
|
|
|
return *Volume(), nil
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "multiple-volume-with-labels",
|
|
|
|
args: []string{"foo", "bar"},
|
|
|
|
volumeInspectFunc: func(volumeID string) (types.Volume, error) {
|
|
|
|
return *Volume(VolumeName(volumeID), VolumeLabels(map[string]string{
|
|
|
|
"foo": "bar",
|
|
|
|
})), nil
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for _, tc := range testCases {
|
2017-08-16 13:50:28 -04:00
|
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
|
|
|
})
|
|
|
|
cmd := newInspectCommand(cli)
|
2017-02-27 12:39:35 -05:00
|
|
|
cmd.SetArgs(tc.args)
|
2018-03-06 15:13:00 -05:00
|
|
|
assert.NilError(t, cmd.Execute())
|
2017-08-16 13:50:28 -04:00
|
|
|
golden.Assert(t, cli.OutBuffer().String(), fmt.Sprintf("volume-inspect-without-format.%s.golden", tc.name))
|
2017-02-27 12:39:35 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestVolumeInspectWithFormat(t *testing.T) {
|
|
|
|
volumeInspectFunc := func(volumeID string) (types.Volume, error) {
|
|
|
|
return *Volume(VolumeLabels(map[string]string{
|
|
|
|
"foo": "bar",
|
|
|
|
})), nil
|
|
|
|
}
|
|
|
|
testCases := []struct {
|
|
|
|
name string
|
|
|
|
format string
|
|
|
|
args []string
|
|
|
|
volumeInspectFunc func(volumeID string) (types.Volume, error)
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
name: "simple-template",
|
|
|
|
format: "{{.Name}}",
|
|
|
|
args: []string{"foo"},
|
|
|
|
volumeInspectFunc: volumeInspectFunc,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "json-template",
|
|
|
|
format: "{{json .Labels}}",
|
|
|
|
args: []string{"foo"},
|
|
|
|
volumeInspectFunc: volumeInspectFunc,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
for _, tc := range testCases {
|
2017-08-16 13:50:28 -04:00
|
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
|
|
volumeInspectFunc: tc.volumeInspectFunc,
|
|
|
|
})
|
|
|
|
cmd := newInspectCommand(cli)
|
2017-02-27 12:39:35 -05:00
|
|
|
cmd.SetArgs(tc.args)
|
|
|
|
cmd.Flags().Set("format", tc.format)
|
2018-03-06 15:13:00 -05:00
|
|
|
assert.NilError(t, cmd.Execute())
|
2017-08-16 13:50:28 -04:00
|
|
|
golden.Assert(t, cli.OutBuffer().String(), fmt.Sprintf("volume-inspect-with-format.%s.golden", tc.name))
|
2017-02-27 12:39:35 -05:00
|
|
|
}
|
|
|
|
}
|