2017-06-20 14:00:01 -04:00
|
|
|
package stack
|
|
|
|
|
|
|
|
import (
|
2022-02-25 08:31:31 -05:00
|
|
|
"io"
|
2017-06-20 14:00:01 -04:00
|
|
|
"testing"
|
|
|
|
"time"
|
|
|
|
|
|
|
|
"github.com/docker/cli/cli/config/configfile"
|
2017-08-21 16:30:09 -04:00
|
|
|
"github.com/docker/cli/internal/test"
|
2023-10-23 08:51:01 -04:00
|
|
|
"github.com/docker/cli/internal/test/builders"
|
2017-06-20 14:00:01 -04:00
|
|
|
"github.com/docker/docker/api/types"
|
|
|
|
"github.com/docker/docker/api/types/swarm"
|
|
|
|
"github.com/pkg/errors"
|
2020-02-22 12:12:14 -05:00
|
|
|
"gotest.tools/v3/assert"
|
|
|
|
is "gotest.tools/v3/assert/cmp"
|
|
|
|
"gotest.tools/v3/golden"
|
2017-06-20 14:00:01 -04:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestStackPsErrors(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
args []string
|
|
|
|
taskListFunc func(options types.TaskListOptions) ([]swarm.Task, error)
|
|
|
|
expectedError string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
args: []string{},
|
2024-07-04 20:49:31 -04:00
|
|
|
expectedError: "requires 1 argument",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"foo", "bar"},
|
2024-07-04 20:49:31 -04:00
|
|
|
expectedError: "requires 1 argument",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
|
|
|
{
|
|
|
|
args: []string{"foo"},
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
|
|
|
return nil, errors.Errorf("error getting tasks")
|
|
|
|
},
|
|
|
|
expectedError: "error getting tasks",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range testCases {
|
test spring-cleaning
This makes a quick pass through our tests;
Discard output/err
----------------------------------------------
Many tests were testing for error-conditions, but didn't discard output.
This produced a lot of noise when running the tests, and made it hard
to discover if there were actual failures, or if the output was expected.
For example:
=== RUN TestConfigCreateErrors
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: error creating config
--- PASS: TestConfigCreateErrors (0.00s)
And after discarding output:
=== RUN TestConfigCreateErrors
--- PASS: TestConfigCreateErrors (0.00s)
Use sub-tests where possible
----------------------------------------------
Some tests were already set-up to use test-tables, and even had a usable
name (or in some cases "error" to check for). Change them to actual sub-
tests. Same test as above, but now with sub-tests and output discarded:
=== RUN TestConfigCreateErrors
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments#01
=== RUN TestConfigCreateErrors/error_creating_config
--- PASS: TestConfigCreateErrors (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments#01 (0.00s)
--- PASS: TestConfigCreateErrors/error_creating_config (0.00s)
PASS
It's not perfect in all cases (in the above, there's duplicate "expected"
errors, but Go conveniently adds "#01" for the duplicate). There's probably
also various tests I missed that could still use the same changes applied;
we can improve these in follow-ups.
Set cmd.Args to prevent test-failures
----------------------------------------------
When running tests from my IDE, it compiles the tests before running,
then executes the compiled binary to run the tests. Cobra doesn't like
that, because in that situation `os.Args` is taken as argument for the
command that's executed. The command that's tested now sees the test-
flags as arguments (`-test.v -test.run ..`), which causes various tests
to fail ("Command XYZ does not accept arguments").
# compile the tests:
go test -c -o foo.test
# execute the test:
./foo.test -test.v -test.run TestFoo
=== RUN TestFoo
Error: "foo" accepts no arguments.
The Cobra maintainers ran into the same situation, and for their own
use have added a special case to ignore `os.Args` in these cases;
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1078-L1083
args := c.args
// Workaround FAIL with "go test -v" or "cobra.test -test.v", see #155
if c.args == nil && filepath.Base(os.Args[0]) != "cobra.test" {
args = os.Args[1:]
}
Unfortunately, that exception is too specific (only checks for `cobra.test`),
so doesn't automatically fix the issue for other test-binaries. They did
provide a `cmd.SetArgs()` utility for this purpose
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L276-L280
// SetArgs sets arguments for the command. It is set to os.Args[1:] by default, if desired, can be overridden
// particularly useful when testing.
func (c *Command) SetArgs(a []string) {
c.args = a
}
And the fix is to explicitly set the command's args to an empty slice to
prevent Cobra from falling back to using `os.Args[1:]` as arguments.
cmd := newSomeThingCommand()
cmd.SetArgs([]string{})
Some tests already take this issue into account, and I updated some tests
for this, but there's likely many other ones that can use the same treatment.
Perhaps the Cobra maintainers would accept a contribution to make their
condition less specific and to look for binaries ending with a `.test`
suffix (which is what compiled binaries usually are named as).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-07-03 19:29:04 -04:00
|
|
|
t.Run(tc.expectedError, func(t *testing.T) {
|
|
|
|
cmd := newPsCommand(test.NewFakeCli(&fakeClient{
|
|
|
|
taskListFunc: tc.taskListFunc,
|
|
|
|
}))
|
|
|
|
cmd.SetArgs(tc.args)
|
|
|
|
cmd.SetOut(io.Discard)
|
|
|
|
cmd.SetErr(io.Discard)
|
|
|
|
assert.ErrorContains(t, cmd.Execute(), tc.expectedError)
|
|
|
|
})
|
2017-06-20 14:00:01 -04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-10 14:55:51 -04:00
|
|
|
func TestStackPs(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
doc string
|
|
|
|
taskListFunc func(types.TaskListOptions) ([]swarm.Task, error)
|
|
|
|
nodeInspectWithRaw func(string) (swarm.Node, []byte, error)
|
|
|
|
config configfile.ConfigFile
|
|
|
|
args []string
|
|
|
|
flags map[string]string
|
|
|
|
expectedErr string
|
|
|
|
golden string
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
doc: "WithEmptyName",
|
|
|
|
args: []string{"' '"},
|
|
|
|
expectedErr: `invalid stack name: "' '"`,
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithEmptyStack",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
|
|
|
return []swarm.Task{}, nil
|
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
expectedErr: "nothing found in stack: foo",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithQuietOption",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(builders.TaskID("id-foo"))}, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
flags: map[string]string{
|
|
|
|
"quiet": "true",
|
|
|
|
},
|
|
|
|
golden: "stack-ps-with-quiet-option.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithNoTruncOption",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(builders.TaskID("xn4cypcov06f2w8gsbaf2lst3"))}, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
flags: map[string]string{
|
|
|
|
"no-trunc": "true",
|
|
|
|
"format": "{{ .ID }}",
|
|
|
|
},
|
|
|
|
golden: "stack-ps-with-no-trunc-option.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithNoResolveOption",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(
|
|
|
|
builders.TaskNodeID("id-node-foo"),
|
2018-08-10 14:55:51 -04:00
|
|
|
)}, nil
|
|
|
|
},
|
|
|
|
nodeInspectWithRaw: func(ref string) (swarm.Node, []byte, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return *builders.Node(builders.NodeName("node-name-bar")), nil, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
flags: map[string]string{
|
|
|
|
"no-resolve": "true",
|
|
|
|
"format": "{{ .Node }}",
|
|
|
|
},
|
|
|
|
golden: "stack-ps-with-no-resolve-option.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithFormat",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(builders.TaskServiceID("service-id-foo"))}, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
flags: map[string]string{
|
|
|
|
"format": "{{ .Name }}",
|
|
|
|
},
|
|
|
|
golden: "stack-ps-with-format.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithConfigFormat",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(builders.TaskServiceID("service-id-foo"))}, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
config: configfile.ConfigFile{
|
|
|
|
TasksFormat: "{{ .Name }}",
|
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
golden: "stack-ps-with-config-format.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
{
|
|
|
|
doc: "WithoutFormat",
|
|
|
|
taskListFunc: func(options types.TaskListOptions) ([]swarm.Task, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return []swarm.Task{*builders.Task(
|
|
|
|
builders.TaskID("id-foo"),
|
|
|
|
builders.TaskServiceID("service-id-foo"),
|
|
|
|
builders.TaskNodeID("id-node"),
|
|
|
|
builders.WithTaskSpec(builders.TaskImage("myimage:mytag")),
|
|
|
|
builders.TaskDesiredState(swarm.TaskStateReady),
|
|
|
|
builders.WithStatus(builders.TaskState(swarm.TaskStateFailed), builders.Timestamp(time.Now().Add(-2*time.Hour))),
|
2018-08-10 14:55:51 -04:00
|
|
|
)}, nil
|
|
|
|
},
|
|
|
|
nodeInspectWithRaw: func(ref string) (swarm.Node, []byte, error) {
|
2023-10-23 08:51:01 -04:00
|
|
|
return *builders.Node(builders.NodeName("node-name-bar")), nil, nil
|
2018-08-10 14:55:51 -04:00
|
|
|
},
|
|
|
|
args: []string{"foo"},
|
|
|
|
golden: "stack-ps-without-format.golden",
|
2017-06-20 14:00:01 -04:00
|
|
|
},
|
2018-08-10 14:55:51 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range testCases {
|
|
|
|
t.Run(tc.doc, func(t *testing.T) {
|
|
|
|
cli := test.NewFakeCli(&fakeClient{
|
|
|
|
taskListFunc: tc.taskListFunc,
|
|
|
|
nodeInspectWithRaw: tc.nodeInspectWithRaw,
|
|
|
|
})
|
|
|
|
cli.SetConfigFile(&tc.config)
|
|
|
|
|
2022-02-22 07:46:35 -05:00
|
|
|
cmd := newPsCommand(cli)
|
2018-08-10 14:55:51 -04:00
|
|
|
cmd.SetArgs(tc.args)
|
|
|
|
for key, value := range tc.flags {
|
2023-10-23 08:51:01 -04:00
|
|
|
assert.Check(t, cmd.Flags().Set(key, value))
|
2018-08-10 14:55:51 -04:00
|
|
|
}
|
2022-02-25 08:31:31 -05:00
|
|
|
cmd.SetOut(io.Discard)
|
test spring-cleaning
This makes a quick pass through our tests;
Discard output/err
----------------------------------------------
Many tests were testing for error-conditions, but didn't discard output.
This produced a lot of noise when running the tests, and made it hard
to discover if there were actual failures, or if the output was expected.
For example:
=== RUN TestConfigCreateErrors
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: "create" requires exactly 2 arguments.
See 'create --help'.
Usage: create [OPTIONS] CONFIG file|- [flags]
Create a config from a file or STDIN
Error: error creating config
--- PASS: TestConfigCreateErrors (0.00s)
And after discarding output:
=== RUN TestConfigCreateErrors
--- PASS: TestConfigCreateErrors (0.00s)
Use sub-tests where possible
----------------------------------------------
Some tests were already set-up to use test-tables, and even had a usable
name (or in some cases "error" to check for). Change them to actual sub-
tests. Same test as above, but now with sub-tests and output discarded:
=== RUN TestConfigCreateErrors
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments
=== RUN TestConfigCreateErrors/requires_exactly_2_arguments#01
=== RUN TestConfigCreateErrors/error_creating_config
--- PASS: TestConfigCreateErrors (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments (0.00s)
--- PASS: TestConfigCreateErrors/requires_exactly_2_arguments#01 (0.00s)
--- PASS: TestConfigCreateErrors/error_creating_config (0.00s)
PASS
It's not perfect in all cases (in the above, there's duplicate "expected"
errors, but Go conveniently adds "#01" for the duplicate). There's probably
also various tests I missed that could still use the same changes applied;
we can improve these in follow-ups.
Set cmd.Args to prevent test-failures
----------------------------------------------
When running tests from my IDE, it compiles the tests before running,
then executes the compiled binary to run the tests. Cobra doesn't like
that, because in that situation `os.Args` is taken as argument for the
command that's executed. The command that's tested now sees the test-
flags as arguments (`-test.v -test.run ..`), which causes various tests
to fail ("Command XYZ does not accept arguments").
# compile the tests:
go test -c -o foo.test
# execute the test:
./foo.test -test.v -test.run TestFoo
=== RUN TestFoo
Error: "foo" accepts no arguments.
The Cobra maintainers ran into the same situation, and for their own
use have added a special case to ignore `os.Args` in these cases;
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L1078-L1083
args := c.args
// Workaround FAIL with "go test -v" or "cobra.test -test.v", see #155
if c.args == nil && filepath.Base(os.Args[0]) != "cobra.test" {
args = os.Args[1:]
}
Unfortunately, that exception is too specific (only checks for `cobra.test`),
so doesn't automatically fix the issue for other test-binaries. They did
provide a `cmd.SetArgs()` utility for this purpose
https://github.com/spf13/cobra/blob/v1.8.1/command.go#L276-L280
// SetArgs sets arguments for the command. It is set to os.Args[1:] by default, if desired, can be overridden
// particularly useful when testing.
func (c *Command) SetArgs(a []string) {
c.args = a
}
And the fix is to explicitly set the command's args to an empty slice to
prevent Cobra from falling back to using `os.Args[1:]` as arguments.
cmd := newSomeThingCommand()
cmd.SetArgs([]string{})
Some tests already take this issue into account, and I updated some tests
for this, but there's likely many other ones that can use the same treatment.
Perhaps the Cobra maintainers would accept a contribution to make their
condition less specific and to look for binaries ending with a `.test`
suffix (which is what compiled binaries usually are named as).
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-07-03 19:29:04 -04:00
|
|
|
cmd.SetErr(io.Discard)
|
2018-08-10 14:55:51 -04:00
|
|
|
|
|
|
|
if tc.expectedErr != "" {
|
|
|
|
assert.Error(t, cmd.Execute(), tc.expectedErr)
|
|
|
|
assert.Check(t, is.Equal("", cli.OutBuffer().String()))
|
|
|
|
return
|
|
|
|
}
|
|
|
|
assert.NilError(t, cmd.Execute())
|
|
|
|
golden.Assert(t, cli.OutBuffer().String(), tc.golden)
|
|
|
|
})
|
|
|
|
}
|
2017-06-20 14:00:01 -04:00
|
|
|
}
|