OpenGL: Ensure framebuffer binding is restored if completion check fails

This commit is contained in:
Yuri Kunde Schlesner 2016-12-04 05:16:14 -08:00
parent ba7f213655
commit 2600633b89
1 changed files with 7 additions and 10 deletions

View File

@ -158,24 +158,21 @@ bool RasterizerCacheOpenGL::BlitTextures(GLuint src_tex, GLuint dst_tex,
buffers = GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT; buffers = GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT;
} }
if (OpenGLState::CheckFBStatus(GL_READ_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) { bool can_blit = OpenGLState::CheckFBStatus(GL_READ_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE &&
return false; OpenGLState::CheckFBStatus(GL_DRAW_FRAMEBUFFER) == GL_FRAMEBUFFER_COMPLETE;
}
if (OpenGLState::CheckFBStatus(GL_DRAW_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) { if (can_blit) {
return false; glBlitFramebuffer(src_rect.left, src_rect.top, src_rect.right, src_rect.bottom,
} dst_rect.left, dst_rect.top, dst_rect.right, dst_rect.bottom, buffers,
glBlitFramebuffer(src_rect.left, src_rect.top, src_rect.right, src_rect.bottom, dst_rect.left,
dst_rect.top, dst_rect.right, dst_rect.bottom, buffers,
buffers == GL_COLOR_BUFFER_BIT ? GL_LINEAR : GL_NEAREST); buffers == GL_COLOR_BUFFER_BIT ? GL_LINEAR : GL_NEAREST);
}
// Restore previous framebuffer bindings // Restore previous framebuffer bindings
cur_state.draw.read_framebuffer = old_fbs[0]; cur_state.draw.read_framebuffer = old_fbs[0];
cur_state.draw.draw_framebuffer = old_fbs[1]; cur_state.draw.draw_framebuffer = old_fbs[1];
cur_state.Apply(); cur_state.Apply();
return true; return can_blit;
} }
bool RasterizerCacheOpenGL::TryBlitSurfaces(CachedSurface* src_surface, bool RasterizerCacheOpenGL::TryBlitSurfaces(CachedSurface* src_surface,