CyberGroup
/
yuzu
12
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

aes_util: Add static assertion to Transcode() and XTSTranscode() to ensure well-defined behavior 

These functions should only be given trivially-copyable types.
This commit is contained in:
Lioncash 2018-08-04 16:56:26 -04:00
parent 64c8212ae1
commit 0d04ee97dc
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/crypto/aes_util.h
View File

@ -39,6 +39,8 @@ public:
template <typename Source, typename Dest> template <typename Source, typename Dest>
void Transcode(const Source* src, size_t size, Dest* dest, Op op) const { void Transcode(const Source* src, size_t size, Dest* dest, Op op) const {
static_assert(std::is_trivially_copyable_v<Source> && std::is_trivially_copyable_v<Dest>,
"Transcode source and destination types must be trivially copyable.");
Transcode(reinterpret_cast<const u8*>(src), size, reinterpret_cast<u8*>(dest), op); Transcode(reinterpret_cast<const u8*>(src), size, reinterpret_cast<u8*>(dest), op);
} }
@ -47,6 +49,8 @@ public:
template <typename Source, typename Dest> template <typename Source, typename Dest>
void XTSTranscode(const Source* src, size_t size, Dest* dest, size_t sector_id, void XTSTranscode(const Source* src, size_t size, Dest* dest, size_t sector_id,
size_t sector_size, Op op) { size_t sector_size, Op op) {
static_assert(std::is_trivially_copyable_v<Source> && std::is_trivially_copyable_v<Dest>,
"XTSTranscode source and destination types must be trivially copyable.");
XTSTranscode(reinterpret_cast<const u8*>(src), size, reinterpret_cast<u8*>(dest), sector_id, XTSTranscode(reinterpret_cast<const u8*>(src), size, reinterpret_cast<u8*>(dest), sector_id,
sector_size, op); sector_size, op);
} }