CyberGroup
/
yuzu
12
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use UNREACHABLE macro for impossible cases in previous commit 

Use the UNREACHABLE macro instead of `ASSERT(false, ...);`.
This commit is contained in:
Benjamin Barenblat 2015-08-02 18:30:24 -04:00
parent 9ff23da255
commit 0298b7bedd
No known key found for this signature in database
GPG Key ID: 9E730149EB91C53B
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/common/logging/backend.cpp
View File

@ -80,8 +80,7 @@ const char* GetLevelName(Level log_level) {
LVL(Error); LVL(Error);
LVL(Critical); LVL(Critical);
case Level::Count: case Level::Count:
ASSERT_MSG(false, "invalid log level"); UNREACHABLE();
return "Unknown";
} }
#undef LVL #undef LVL
} }

4
src/common/logging/text_formatter.cpp
View File

@ -84,7 +84,7 @@ void PrintColoredMessage(const Entry& entry) {
case Level::Critical: // Bright magenta case Level::Critical: // Bright magenta
color = FOREGROUND_RED | FOREGROUND_BLUE | FOREGROUND_INTENSITY; break; color = FOREGROUND_RED | FOREGROUND_BLUE | FOREGROUND_INTENSITY; break;
case Level::Count: case Level::Count:
ASSERT_MSG(false, "invalid log level"); break; UNREACHABLE();
} }
SetConsoleTextAttribute(console_handle, color); SetConsoleTextAttribute(console_handle, color);
@ -105,7 +105,7 @@ void PrintColoredMessage(const Entry& entry) {
case Level::Critical: // Bright magenta case Level::Critical: // Bright magenta
color = ESC "[1;35m"; break; color = ESC "[1;35m"; break;
case Level::Count: case Level::Count:
ASSERT_MSG(false, "invalid log level"); break; UNREACHABLE();
} }
fputs(color, stderr); fputs(color, stderr);