Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/cli/command/container
History
Laura Brehm c7f3031f74
tests/run: fix flaky `RunAttachTermination` test 
This test was just incorrect (and testing incorrect
behavior): it was checking that `docker run` exited with a `context
canceled` error after signalling the CLI/cancelling the command's
context, but this was incorrect (and was fixed in
991b1303da - which was when this test
started failing).

However, since this test assertion was happening inside of a goroutine,
it would sometimes pass if this assertion didn't get to run before the
test suite terminated. It was flaky because sometimes this assertion
inside the goroutine did get to execute, but after the test finished
execution, which is a big no-no.

As an aside, assertions inside goroutines are generally bad, and `govet`
even has a linter for this (but it only catches `t.Fatal` and `t.FailNow`
calls and not `assert.Xx`.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
(cherry picked from commit eac83574c1)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
 		2024-08-07 12:05:30 +02:00
..
testdata docker ps: always use --quiet, also combined with --format 2023-04-10 01:12:00 +02:00
attach.go attach: wait for exit code from `ContainerWait` 2024-07-26 15:48:37 +01:00
attach_test.go attach: wait for exit code from `ContainerWait` 2024-07-26 15:48:37 +01:00
client_test.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
cmd.go Update gometalinter 2017-10-26 12:21:02 -04:00
commit.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
completion.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
cp.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
cp_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
create.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
create_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
diff.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
exec.go cli/command/completion: add EnvVarNames utility 2024-07-19 01:56:24 +02:00
exec_test.go cli/command: Don't copy fakeClient 2024-06-20 14:59:38 +02:00
export.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
export_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
formatter_diff.go linting: address else/if/elseif statements found by gocritic 2023-11-20 16:02:16 +01:00
formatter_diff_test.go vendor: github.com/docker/docker v24.0.0-rc.1.0.20230505222407-8d9a40a82034 2023-05-06 00:34:34 +02:00
formatter_stats.go golangci-lint: enable dupword linter 2023-11-20 16:02:18 +01:00
formatter_stats_test.go cli/command/container: add BenchmarkStatsFormat() 2022-05-13 21:26:38 +02:00
hijack.go cli/command/container: hijackedIOStreamer: explicitly ignore err 2023-05-03 17:01:08 +02:00
inspect.go Update go:build comments to go1.21 2024-06-18 12:17:13 +02:00
kill.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
list.go cli/command: don't use pflags.XXXVarP for flags without shorthand 2024-01-29 11:16:38 +01:00
list_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
logs.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
logs_test.go cli/command: Don't copy fakeClient 2024-06-20 14:59:38 +02:00
opts.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
opts_test.go linting: fmt.Sprintf can be replaced with string concatenation (perfsprint) 2024-06-10 21:19:32 +02:00
pause.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
port.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
port_test.go cli/command/container: runPort: sort ports before printing 2022-12-01 10:58:40 +01:00
prune.go chore: remove backticks and resolve linting issues 2024-04-02 15:54:29 +02:00
prune_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
rename.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
restart.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
rm.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
rm_test.go test spring-cleaning 2024-07-19 13:37:27 +02:00
run.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
run_test.go tests/run: fix flaky `RunAttachTermination` test 2024-08-07 12:05:30 +02:00
signals.go cli/command/container: ForwardAllSignals: rewrite to use ContainerAPIClient 2023-11-08 15:15:09 +01:00
signals_test.go cli/command/container: ForwardAllSignals: rewrite to use ContainerAPIClient 2023-11-08 15:15:09 +01:00
signals_unix.go remove pre-go1.17 build-tags 2023-05-05 18:23:03 +02:00
signals_unix_test.go cli/command/container: ForwardAllSignals: rewrite to use ContainerAPIClient 2023-11-08 15:15:09 +01:00
signals_windows.go Ignore SIGURG on Darwin too 2021-05-24 19:37:53 +01:00
start.go feat: global signal handling with context cancellation 2024-06-07 16:56:34 +02:00
stats.go linting: fmt.Errorf can be replaced with errors.New (perfsprint) 2024-06-10 21:19:31 +02:00
stats_helpers.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00
stats_helpers_test.go vendor: github.com/docker/docker 1a1f3cff45ec (master, v27.0-dev) 2024-06-20 13:04:54 +02:00
stop.go cli/command/container: add completion for --stop-signal 2024-07-19 01:56:26 +02:00
top.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
tty.go golangci-lint: revive: enable import-shadowing 2023-11-20 19:52:41 +01:00
tty_test.go vendor: github.com/docker/docker cdb3f9fb8dca (v25.0.0-dev) 2023-10-13 22:09:04 +02:00
unpause.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00
update.go cli/command/container: add completion for --restart 2024-07-19 01:56:25 +02:00
utils.go vendor: github.com/docker/docker a736d0701c41 (master, v27.0.0-dev) 2024-06-10 17:41:09 +02:00
utils_test.go cli/command/container: waitExitOrRemoved: take APIClient as argument 2023-07-24 09:54:11 +02:00
wait.go Plumb contexts through commands 2023-12-12 22:30:16 +01:00