mirror of https://github.com/docker/cli.git
e6ebaf55dd
When adding a network using `docker service update --network-add`,
the new network was added by _name_.
Existing entries in a service spec are listed by network ID, which
resulted in the CLI not detecting duplicate entries for the same
network.
This patch changes the behavior to always use the network-ID,
so that duplicate entries are correctly caught.
Before this change;
$ docker network create -d overlay foo
$ docker service create --name=test --network=foo nginx:alpine
$ docker service update --network-add foo test
$ docker service inspect --format '{{ json .Spec.TaskTemplate.Networks}}' test
[
{
"Target": "9ot0ieagg5xv1gxd85m7y33eq"
},
{
"Target": "9ot0ieagg5xv1gxd85m7y33eq"
}
]
After this change:
$ docker network create -d overlay foo
$ docker service create --name=test --network=foo nginx:alpine
$ docker service update --network-add foo test
service is already attached to network foo
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
||
|---|---|---|
| .. | ||
| progress | ||
| testdata | ||
| client_test.go | ||
| cmd.go | ||
| create.go | ||
| generic_resource_opts.go | ||
| generic_resource_opts_test.go | ||
| helpers.go | ||
| inspect.go | ||
| inspect_test.go | ||
| list.go | ||
| list_test.go | ||
| logs.go | ||
| opts.go | ||
| opts_test.go | ||
| parse.go | ||
| ps.go | ||
| ps_test.go | ||
| remove.go | ||
| rollback.go | ||
| rollback_test.go | ||
| scale.go | ||
| trust.go | ||
| update.go | ||
| update_test.go | ||