DockerCLI/cli-plugins
Ian Campbell baabf6e8ad Ensure that plugins are only listed once in help outputs.
They were listed twice in `docker --help` (but not `docker help`), since the
stubs were added in both `tryRunPluginHelp` and the `setHelpFunc` closure.

Calling `AddPluginStubCommands` earlier in `setHelpFunc` before the call to
`tryRunPluginHelp` is sufficient. Also it is no longer necessary to add just
valid plugins (`tryRunPluginHelp` handles invalid plugins correctly) so remove
that logic (which was in any case broken for e.g. `docker --help`).

Update the e2e test to check for duplicate entries and also to test `docker
--help` which was previously missed.

Signed-off-by: Ian Campbell <ijc@docker.com>
2019-01-30 13:55:42 +00:00
..
examples/helloworld Ignore unknown arguments on the top-level command. 2019-01-30 13:45:26 +00:00
manager Ensure that plugins are only listed once in help outputs. 2019-01-30 13:55:42 +00:00
plugin Allow plugins to make use of the cobra `PersistentPreRun` hooks. 2019-01-30 13:45:26 +00:00