Guest24897
/
DockerCLI
mirror of https://github.com/docker/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
DockerCLI/cli/command/container
History
Kir Kolyshkin 395957155f cli/command/container: don't leak context 
Switch from x/net/context to context made "go vet" see the previously
unseen errors:

> cli/command/container/start.go:57::error: the cancelFun function is
> not used on all paths (possible context leak) (vet)
> cli/command/container/start.go:63::error: this return statement may be
> reached without using the cancelFun var defined on line 57 (vet)

> cli/command/container/run.go:159::error: the cancelFun function is not
> used on all paths (possible context leak) (vet)
> cli/command/container/run.go:164::error: this return statement may be
> reached without using the cancelFun var defined on line 159 (vet)

Do call the cancel function.

Note we might end up calling it twice which is fine as long as I can see
from the Go 1.10 source code.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 		2018-05-11 16:50:04 -07:00
..
testdata Add unit tests to docker container ls 2018-02-19 11:22:36 +01:00
attach.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
attach_test.go Fixed gometalinter errors on test files 2018-04-10 16:03:56 +02:00
client_test.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
cmd.go Update gometalinter 2017-10-26 12:21:02 -04:00
commit.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
cp.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
cp_test.go Fixes some unit tests to be able to run them on windows 2018-03-07 18:18:13 +01:00
create.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
create_test.go Add more content trust tests 2018-03-19 10:02:40 +01:00
diff.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
exec.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
exec_test.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
export.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
hijack.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
inspect.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
kill.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
list.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
list_test.go Convert assert.Check with 2018-03-06 15:43:53 -05:00
logs.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
logs_test.go Remove testutil 2018-03-06 14:38:35 -05:00
opts.go Fix `--label` behavior on run 2018-02-27 12:14:07 +01:00
opts_test.go Convert to assert.NilError 2018-03-06 15:27:34 -05:00
pause.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
port.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
prune.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
ps_test.go Convert assert.Check with 2018-03-06 15:43:53 -05:00
rename.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
restart.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
rm.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
run.go cli/command/container: don't leak context 2018-05-11 16:50:04 -07:00
run_test.go Add more content trust tests 2018-03-19 10:02:40 +01:00
start.go cli/command/container: don't leak context 2018-05-11 16:50:04 -07:00
stats.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
stats_helpers.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
stats_helpers_test.go Post migration fixes 2018-03-05 19:41:17 -05:00
stats_unit_test.go Add line length linter 2017-05-08 15:57:56 -04:00
stop.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
top.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
tty.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
unpause.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
update.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
utils.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
utils_test.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00
wait.go Switch from x/net/context to context 2018-05-11 16:49:43 -07:00