mirror of https://github.com/docker/cli.git
48d30b5b32
On Windows, the os/exec.{Command,CommandContext,LookPath} functions
resolve command names that have neither path separators nor file extension
(e.g., "git") by first looking in the current working directory before
looking in the PATH environment variable.
Go maintainers intended to match cmd.exe's historical behavior.
However, this is pretty much never the intended behavior and as an abundance of precaution
this patch prevents that when executing commands.
Example of commands that docker.exe may execute: `git`, `docker-buildx` (or other cli plugin), `docker-credential-wincred`, `docker`.
Note that this was prompted by the [Go 1.15.7 security fixes](https://blog.golang.org/path-security), but unlike in `go.exe`,
the windows path lookups in docker are not in a code path allowing remote code execution, thus there is no security impact on docker.
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| command | ||
| compose | ||
| config | ||
| connhelper | ||
| context | ||
| debug | ||
| flags | ||
| manifest | ||
| registry/client | ||
| streams | ||
| trust | ||
| version | ||
| winresources | ||
| cobra.go | ||
| cobra_test.go | ||
| error.go | ||
| required.go | ||
| required_test.go | ||