5 Commits

Author	SHA1	Message	Date
Sebastiaan van Stijn	e6ebaf55dd	Fix --network-add adding duplicate networks ... When adding a network using `docker service update --network-add`, the new network was added by _name_. Existing entries in a service spec are listed by network ID, which resulted in the CLI not detecting duplicate entries for the same network. This patch changes the behavior to always use the network-ID, so that duplicate entries are correctly caught. Before this change; $ docker network create -d overlay foo $ docker service create --name=test --network=foo nginx:alpine $ docker service update --network-add foo test $ docker service inspect --format '{{ json .Spec.TaskTemplate.Networks}}' test [ { "Target": "9ot0ieagg5xv1gxd85m7y33eq" }, { "Target": "9ot0ieagg5xv1gxd85m7y33eq" } ] After this change: $ docker network create -d overlay foo $ docker service create --name=test --network=foo nginx:alpine $ docker service update --network-add foo test service is already attached to network foo Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2018-01-09 20:42:09 +01:00
Renaud Gaubert	51c7cd91cf	Added Generic Resource tests ... Signed-off-by: Renaud Gaubert <renaud.gaubert@gmail.com>	2017-11-28 18:03:10 +01:00
Vincent Demeester	b5182ba17f	Move duration opts into an opts package ... They have nothing to do with service and could be used on their own. Signed-off-by: Vincent Demeester <vincent@sbr.pm>	2017-05-16 17:49:40 +02:00
Vincent Demeester	d7f6563efc	Update cli imports to using local package ... Also, rename a bunch of variable to not *shadow* the `opts` package name. Signed-off-by: Vincent Demeester <vincent@sbr.pm>	2017-05-15 14:45:19 +02:00
Daniel Nephin	1630fc40f8	Import docker/docker/cli ... Signed-off-by: Daniel Nephin <dnephin@gmail.com>	2017-04-17 17:40:59 -04:00