4 Commits

Author	SHA1	Message	Date
Sebastiaan van Stijn	5aba4860de	cli-plugins/manager: TestPluginError: don't use yaml.Marshal ... The test used `gopkg.in/yaml.v2` to verify the TextMarshaller implementation, which was implemented to allow printing the errors in JSON formatted output; > This exists primarily to implement encoding.TextMarshaller such that > rendering a plugin as JSON (e.g. for `docker info -f '{{json .CLIPlugins}}'`) > renders the Err field as a useful string and not just `{}`. Given that both yaml.Marshal and json.Marshal use this, we may as well use Go's stdlib. While updating, also changed some of the assertions to checks, so that we don't fail the test early. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2022-11-17 13:17:51 +01:00
Sebastiaan van Stijn	bb7ef2cb3a	Update some uses of errors.Cause() to errors.Is() ... Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2020-05-10 19:56:35 +02:00
Sebastiaan van Stijn	2c0e93063b	bump gotest.tools v3.0.1 for compatibility with Go 1.14 ... full diff: https://github.com/gotestyourself/gotest.tools/compare/v2.3.0...v3.0.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2020-02-23 00:28:55 +01:00
Ian Campbell	1c576e9043	Integrate CLI plugins into `docker info` ... Fairly straight forward. It became necessary to wrap `Plugin.Err` with a type which implements `encoding.MarshalText` in order to have that field rendered properly in the `docker info -f '{{json}}'` output. Since I changed the type somewhat I also added a unit test for `formatInfo`. Signed-off-by: Ian Campbell <ijc@docker.com>	2019-01-30 13:45:26 +00:00