Guest24897/DockerCLI

Commit Graph

Author	SHA1	Message	Date
Brian Goff	bcb7147ae5	Fixes a race condition in client events monitoring In cases where there is high latency (ie, not-local network) `waitExitOrRemoved` was not receiving events for short-lived containers. This caused the client to hang while waiting for a notification that the container has stopped. This happens because `client.Events()` returns immediately and spins a goroutine up to process events. The problem here is it returns before the request to the events endpoint is even made. Even without high-latency issues, there is no guarantee that the goroutine is even scheduled by the time the function returns. Signed-off-by: Brian Goff <cpuguy83@gmail.com>	2016-12-16 10:11:53 -05:00
Josh Horwitz	9acc93282e	Refactor to new events api Signed-off-by: Josh Horwitz <horwitzja@gmail.com>	2016-09-22 14:42:06 -04:00
Michael Crosby	3fff6acaa1	Move engine-api client package This moves the engine-api client package to `/docker/docker/client`. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>	2016-09-07 11:05:58 -07:00

Author

SHA1

Message

Date

Brian Goff

bcb7147ae5

Fixes a race condition in client events monitoring

In cases where there is high latency (ie, not-local network)
`waitExitOrRemoved` was not receiving events for short-lived containers.
This caused the client to hang while waiting for a notification that the
container has stopped.

This happens because `client.Events()` returns immediately and spins a
goroutine up to process events. The problem here is it returns before
the request to the events endpoint is even made.
Even without high-latency issues, there is no guarantee that the
goroutine is even scheduled by the time the function returns.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

2016-12-16 10:11:53 -05:00

Josh Horwitz

9acc93282e

Refactor to new events api

Signed-off-by: Josh Horwitz <horwitzja@gmail.com>

2016-09-22 14:42:06 -04:00

Michael Crosby

3fff6acaa1

Move engine-api client package

This moves the engine-api client package to `/docker/docker/client`.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

2016-09-07 11:05:58 -07:00

3 Commits