Guest24897/DockerCLI

Commit Graph

Author	SHA1	Message	Date
Sebastiaan van Stijn	c2f1671595	Use gofumpt if available, and enable gofumpt linter gofumpt provides a supserset of gofmt / go fmt, but not every developer may have it installed, so for situations where it's not available, fall back to gofmt. As our code has been formatted with gofumpt already, in most cases contributions will follow those formatting rules, but in some cases there may be a difference, which would already be flagged by manual code review, but let's also enable the gofumpt linter. With this change, `make fmt` will use gofumpt is available; gofumpt has been added to the dev-container, so `make -f docker.Makefile fmt` will always use it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2022-09-30 19:14:36 +02:00
Sebastiaan van Stijn	7c87175d88	Fix broken link in CONTRIBUTING Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2020-03-19 15:03:59 +01:00
Riyaz Faizullabhoy	fedbc5861b	Add Contribution guidelines Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>	2017-07-28 11:33:19 -07:00

Author

SHA1

Message

Date

Sebastiaan van Stijn

c2f1671595

Use gofumpt if available, and enable gofumpt linter

gofumpt provides a supserset of gofmt / go fmt, but not every developer may have
it installed, so for situations where it's not available, fall back to gofmt.

As our code has been formatted with gofumpt already, in most cases contributions
will follow those formatting rules, but in some cases there may be a difference,
which would already be flagged by manual code review, but let's also enable the
gofumpt linter.

With this change, `make fmt` will use gofumpt is available; gofumpt has been
added to the dev-container, so `make -f docker.Makefile fmt` will always use it.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2022-09-30 19:14:36 +02:00

Sebastiaan van Stijn

7c87175d88

Fix broken link in CONTRIBUTING

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2020-03-19 15:03:59 +01:00

Riyaz Faizullabhoy

fedbc5861b

Add Contribution guidelines

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>

2017-07-28 11:33:19 -07:00

3 Commits